Error while Insert Record into database from VB From

Question

0.00/5 (No votes)

See more:

Hai All,
I am developing VB Application in VS2010. When i read the data base by using select and display it on Datagrid view , here i didn't get any problem. But when i insert the new record into that database have an error...
Here is my code for insert new record...

SQL

cmdInsert.CommandText = "INSERT INTO Alarm (Alarm, Date,Time) VALUES ('" & al & "', '" & dt & "', '" & tm & "')"
            MsgBox(cmdInsert.CommandText)
            cmdInsert.CommandType = CommandType.Text
            cmdInsert.Connection = cnnOLEDB
            cmdInsert.ExecuteNonQuery()
            cmdInsert.Dispose()

dt,tm and al are strings

error is occur at runtime just like INSERT INTO Statement error

Posted 2-Jan-12 21:03pm

Himachandra

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Abhinav S · Answer 1 · 2012-01-02T21:10:00

Solution 1

Ensure that the type of values you are storing into the tables and the type that you are passing into the query are correct. Alarm may be an int (number) type and not string.

Posted 2-Jan-12 21:10pm

Abhinav S

Updated 2-Jan-12 21:11pm

v2

Comments

Himachandra 3-Jan-12 3:53am

Conformly Alarm is text type

Himachandra 4-Jan-12 0:37am

Thank U Abhinav S

Tom Moody · Answer 2 · 2012-01-03T04:56:00

Solution 2

VALUES ('" & al & "', '" & dt & "', '" & tm & "')"

Try This ''''

dim S= "(" & chr(34) & al & Chr(34) & "," & chr(34) & dt & Chr(34) & "," & chr(34) & tm & Chr(34) & ")"

Values & S

Posted 3-Jan-12 4:56am

Tom Moody

v2

Comments

Himachandra 4-Jan-12 0:37am

Thank U Tom Moody

Wendelius · Answer 3 · 2012-01-03T10:05:00

Never concatenate actual values to the SQL statement. Instead use OleDbParameter[^].

So your code could look something like:

VB

cmdInsert.CommandText = "INSERT INTO Alarm (Alarm, Date,Time) VALUES (?, ?, ?)"
MsgBox(cmdInsert.CommandText)
cmdInsert.CommandType = CommandType.Text
cmdInsert.Connection = cnnOLEDB
cmdInsert.Parameters.AddWithValue("@alarm", al);
cmdInsert.Parameters.AddWithValue("@date", dt);
cmdInsert.Parameters.AddWithValue("@time", tm);
cmdInsert.ExecuteNonQuery()
cmdInsert.Dispose()

That would help you against conversion problems and SQL injections.

Also don't use string data for dates or times. Instead use the native data types. As you're having both date and time separately, I'd suggest that you define only one field in the table and the data type would be datetime2. See: http://msdn.microsoft.com/en-us/library/bb677335.aspx[^]