i am looking this error in my statment

Question

0.00/5 (No votes)

See more:

VB

ssql = "insert into inward_master(inwardno,inwdate,intype,site,dept,sguard,vehno,str_recby,enterby) values" & _
           "('" & Me.txtinward.Text & "' ,'" & Format(Me.dtinward.Value, "MM/dd/yyyy") & "'," & _
           "'" & Me.cmbintype.Text & "'," & _
           "'" & loginsite & "','" & Me.txtdeptno.Text & "'," & _
           "'" & Me.txtsg.Text & "'" & _
           "'" & Me.txtveh.Text.Trim & "'" & _
           ",'" & Me.txtrec.Text & "', '" & login & "')"

when i execute query then it says.there are more col in ur insert statment.then values.

plz help me

Posted 31-Oct-11 22:25pm

prince_rumeel

Add a Solution

2 solutions

Solution 1

There is 10 items in your columns list but you are inserting only 9.

The str could be extra.

Posted 31-Oct-11 22:32pm

Mehdi Gholam

Comments

André Kraak 1-Nov-11 4:43am

Are you sure? I only counted eight ',' in the columns list.

I did find one missing ',' in the values list, see my solution.

Mehdi Gholam 1-Nov-11 4:51am

It's a pain to see code like this, you get cross eyed :)

André Kraak 1-Nov-11 4:56am

You are right, I had to count it three times.

prince_rumeel 1-Nov-11 5:16am

thanks alot all of u

Espen Harlinn 1-Nov-11 13:27pm

5'ed!

Mehdi Gholam 1-Nov-11 13:50pm

Thanks Espen.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

André Kraak · Accepted Answer · 2011-10-31T22:34:00

Solution 2

First start by changing this line

VB

"'" & Me.txtsg.Text & "'" & _

and adding a ',' to them

VB

"'" & Me.txtsg.Text & "'," & _

Now see what happens.

You might want to change your code so that you are consistent in how you add the ' and , to the statement. The way it is now is very hard to read.

Also you might want to look into to parameterized queries[^].

And as a final note do not store date as a string but use the datetime type[^].

Posted 31-Oct-11 22:34pm

André Kraak

Updated 31-Oct-11 22:44pm

v3

Comments

Mehdi Gholam 1-Nov-11 4:51am

5'ed

André Kraak 1-Nov-11 4:56am

Thank you.

RaisKazi 1-Nov-11 5:11am

A 5!

prince_rumeel 1-Nov-11 5:16am

thanks andre kraak

Espen Harlinn 1-Nov-11 13:27pm

5'ed!

André Kraak 1-Nov-11 15:44pm

Thanks.