Moving A File From One Directory

Question

2.00/5 (1 vote)

See more:

I'm trying to move a file from one directory to another. I have this code that copies the entire directory (works) but when I try to move a file over, it fails. If I directly put the files name in, it works. So I think that its the syntax on the string. Having said all that, I still have the problem of removing the file from the old directory. Is there an easier way in C++ to just move the file from one directory to another? Thank you.

What I am using now....

C++

SHFILEOPSTRUCT fileop;
fileop.hwnd = NULL;
fileop.wFunc = FO_MOVE;
fileop.pFrom = (string("c:\\mapper\\").append(string(iter->cFileName)).c_str());
fileop.pTo = "c:\\FAIL\\";
fileop.fFlags = FOF_ALLOWUNDO|FOF_NOCONFIRMATION|FOF_NOCONFIRMMKDIR;

Andre, why would you delete this? I didn't even have time to get your answer!
I thought you had a good answer! Please repost it! I got the move part but I didn't get the string part. Thank you.

Posted 7-Oct-11 10:00am

Member 7766180

Updated 7-Oct-11 15:43pm

Deeksha Shenoy

v8

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2011-10-07T10:35:00

Solution 1

Don't copy — it can take too much time and even failed due to insufficient space of the disk. Instead, rename whole thing using int rename ( const char * oldname, const char * newname ). See http://www.cplusplus.com/reference/clibrary/cstdio/rename/[^].

On Windows 7, you may need to run your program with elevated privileges as administrator; if you just log in as administrator, this is not enough (and not even required). Using a directory like "c:\mapper\" is bad, it won't be legal at Windows 7; you need to work with "special" directories under user accounts.

This is a good description of options you can use: http://www.sevenforums.com/tutorials/11841-run-administrator.html[^].

—SA

Posted 7-Oct-11 10:35am

Sergey Alexandrovich Kryukov

Updated 7-Oct-11 10:54am

v2

Comments

CPallini 7-Oct-11 16:39pm

5.

Sergey Alexandrovich Kryukov 7-Oct-11 16:45pm

Thank you.
--SA

Member 7766180 7-Oct-11 16:42pm

Holy Cow! That is a wonderful answer! My 100. If I could do it, so I guess I'll have settle on a 5. Thank you.

Sergey Alexandrovich Kryukov 7-Oct-11 16:44pm

Your understanding and good words is more important than a vote of 9000 :-)
--SA

Chuck O'Toole 7-Oct-11 20:43pm

I don't know why directories in the root (e.g. C:\Mapper\ or C:\Fail\) would be illegal under Windows 7, I use them all the time (running Windows 7 Enterprise).

Philippe Mori 8-Oct-11 8:10am

Even though it works, I guess it would a requirement to have the Windows 7 logo to not use arbitrary directories...

Chuck O'Toole · Accepted Answer · 2011-10-07T14:39:00

Solution 2

You (and SA) are doing things the hard way. Use the MoveFile() or MoveFileEx() APIs provided by windows.

MoveFile uses the most efficient method, depending on if the files are on the same drive (rename) or different drives (copy).

Posted 7-Oct-11 14:39pm

Chuck O'Toole

Comments

Member 7766180 7-Oct-11 21:32pm

Thank you!