checking menu items visibility

Question

1.00/5 (1 vote)

See more:

Hi to all!

Here I create a code to check the menuitems

C#

private void formm_display_function(string display_form_str)
       {
       foreach (ToolStripMenuItem menuItem in this.menuStrip1.Items)
       {
           if (menuItem.Text.Trim() == display_form_str){
           menuItem.Visible = true;
           break;
       }
   }

In this code only the first menu is checking

I have five items

display_form_str contains one of the items from menu

but its checking only the first menu items

Posted 6-Aug-11 18:54pm

kami124

Updated 6-Aug-11 19:01pm

JOAT-MON

v2

Add a Solution

Comments

JOAT-MON 7-Aug-11 1:02am

Added code block.

Sergey Alexandrovich Kryukov 7-Aug-11 13:58pm

Re-post! I already answered the previous question. Please don't re-post. Use "Improve question", post comments on existing solutions.
--SA

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

JOAT-MON · Accepted Answer · 2011-08-06T19:09:00

Solution 1

Looks like you only have half of the curly braces showing, this would indicate that the break; command is being hit during every pass. Make sure you encapsulate the entire statement:

C#

private void formm_display_function(string display_form_str)
{
       foreach (ToolStripMenuItem menuItem in this.menuStrip1.Items)
       {
           if (menuItem.Text.Trim() == display_form_str)
           {
               menuItem.Visible = true;
               break;
           } // <-- added to encapsulate 'break;' command so it only fires when a match is made
       }
}

[EDIT]

ToolStripMenuItems are derived from ToolStripDropDownItem, so if the menu items you are trying to compare against are in the same menu drop down (meaning they show vertically), then what you have is one ToolStripMenuItem containing the other ToolStripMenuItems. To access these, you need to iterate through the ToolStripMenuItems in the DropDownItems property.

C#

private void formm_display_function(string display_form_str)
{
       foreach (ToolStripMenuItem menuItem in this.menuStrip1.Items)
       {
           foreach(ToolStripMenuItem subitem in menuitem.DropDownItems)
           {
                if (subitem.Text.Trim() == display_form_str)
                {
                     subitem.Visible = true;
                     break;
                }
           }
       }
}

[/EDIT]

Posted 6-Aug-11 19:09pm

JOAT-MON

Updated 6-Aug-11 20:31pm

v4

Comments

kami124 7-Aug-11 1:17am

what you have update you write the same code which i wrote
i think you did not understand my question
see again

i have menustrip1
having items
item1
item2
item3
item4

and in dispaly_form_str has
item1 or item2 or item3 or item4

JOAT-MON 7-Aug-11 1:41am

I understand your problem, maybe you misunderstood my solution? Notice that I have added an ending curly brace in there. It looked to me like you were missing this in your code, which would cause the foreach loop to break out of its iteration after the first comparison, whether it matched or not.

kami124 7-Aug-11 1:48am

ok that currly bracket i already make it

the problem is some where else

JOAT-MON 7-Aug-11 2:08am

Are your menu items in the same drop down menu? Do they go down like this:
item1
item2
item3
item4
item5

or are they across the MenuStrip like this:
item1 item2 item3 item4 item5

JOAT-MON 7-Aug-11 2:27am

If they are vertical, then see my [EDIT] section above.

kami124 7-Aug-11 2:41am

menu items are drop down menu
yes they are like this item1 item2 item3 item4 item5

kami124 7-Aug-11 2:48am

ya now its working now its checking but i want to check by its name
not by its text

kami124 7-Aug-11 2:52am

subitem.Name
i done it like this is this ok

kami124 7-Aug-11 2:56am

but the problem here is its visibility is not changed
by the default i set all items visibility false

kami124 7-Aug-11 3:02am

ok very nice now evert thing is working properly
but the problem is with visibility
subitem.Visible=true;
is executed but its visibility is not changed
can u help that whats the problem

JOAT-MON 8-Aug-11 12:52pm

I am not sure offhand, but if I think of anything I will post it.

JOAT-MON 8-Aug-11 15:29pm

I just created a test app that mimics this scenario and the visibility worked fine. I think I will need more info from you about what you are doing to be able to see why the visibility does not work for you.

JOAT-MON 8-Aug-11 15:53pm

Nevermind, I see you have another thread started to focus on the visibility. I will add to it if I think of anything that hasn't been addressed already there.