what to do to improve performance and reduce memory allocation in this code snippet?

Question

4.00/5 (1 vote)

See more:

kindly help me out so as to improve performance and dispose memory allocation in this code snippet

public static void GetBuildingCount(int marineCount, int[,] marinePositions)
       {
               int x = 0;
               int i = 0;
               int j = 0;
               bool processed = false;
               if (marineCount == (marinePositions.Length / 2))
               {
                   for (j = 1; j <= 8; j++)
                   {
                       processed = false;
                       for (i = 0; i <= marinePositions.Length / 2 - 1; i++)
                       {
                           if (j == marinePositions[i, 0] && processed == false)
                           {
                               x++;
                               output1 = output1 + 8;
                               processed = true;
                           }
                       }

                   }
                   for (j = 1; j <= 8; j++)
                   {
                       processed = false;
                       for (i = 0; i <= marinePositions.Length / 2 - 1; i++)
                       {
                           if (j == marinePositions[i, 1] && processed == false)
                           {
                               output1 = output1 + 8 - x;
                               processed = true;
                           }
                       }
                   }
               }

               System.GC.Collect();
               System.GC.WaitForPendingFinalizers();

           }

Posted 28-Jun-11 23:43pm

AshwinMendon

Updated 28-Jun-11 23:45pm

Toniyo Jackson

v2

Add a Solution

3 solutions

Solution 1

If you want to improve performance, the first thing you should look at is to stop performing the same loop twice. Is there a reason you cannot combine the two together?

Also, don't force a garbage collection. In all the time I've been coding apps in .NET, I have never needed to force the garbage collector to process (and doing so causes a performance hit).

Posted 28-Jun-11 23:59pm

Pete O'Hanlon

Comments

Tarun.K.S 29-Jun-11 6:01am

Excellent suggestion.

Sergey Alexandrovich Kryukov 30-Jun-11 5:03am

Agree, my 5.
--SA

Solution 3

If you're looking in Task Manager to see how muchmemory your app is using, stop it. TM isn't showing you how much memory your app is using, but is showing you how much memory is RESERVED by the .NET CLR running your app. You've got nothing to worry about. The CLR does a great job at managing memory and returning any unused memory back to Windows when necessary.

Posted 29-Jun-11 7:49am

Dave Kreskowiak

Comments

Sergey Alexandrovich Kryukov 30-Jun-11 5:02am

Agree, my 5. I also advices not to do manual collection, please see my answer.
--SA

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2011-06-29T00:02:00

Firstly, ditch your processed variable, and use break instead. This will cause that loop to terminate immediately, instead of running through after you have found what you want.

for (j = 1; j <= 8; j++)
{
    for (i = 0; i <= marinePositions.Length / 2 - 1; i++)
    {
        if (j == marinePositions[i, 0])
        {
            x++;
            output1 = output1 + 8;
            break;
        }
    }
}

This applies to both "j" loops.
Secondly, dump the Garbage Collection stuff - this routine does not create or dispose any data that the GC can handle - it is all local stack based variables.