How do I end the if-else loop when the user enter (y)?

Question

1.00/5 (1 vote)

See more:

Java

public static void main(String[] args)
{
    boolean runAgain = true;
    while(runAgain)
    { 
        runMyCode();
  
        JOptionPane.showInputDialog( null, " Would you like to exit the application? Enter (y) to exit or any other key to continue ");
    }

    String Answer = " ";
    char answer = Answer.charAt(0);
    if (answer == 'y')
    {
      runAgain = true;
    }
    else
    {
        runAgain = false;
    }   
}

What I have tried:

I have tried swapping the true and false around but no matter what the user enters it still loops even when (y) is selected

Posted 1-Jun-21 9:17am

Ashwari Pillay

Updated 1-Jun-21 9:43am

Dave Kreskowiak

v2

Add a Solution

Comments

Dave Kreskowiak 1-Jun-21 15:40pm

You can start by fixing your indentation. It'll make the code far easier to read and debug.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2021-06-01T09:39:00

If you actually take care to correct the indentation of your code the problem will likely show itself:

Java

public static void main(String[] args) 
{
    boolean runAgain = true;
    while(runAgain){ // start of the while loop
        runMyCode();
        
        JOptionPane.showInputDialog( null, " Would you like to exit the application? Enter (y) to exit or any other key to continue ");
        
    } // end of the while loop

// so the code from here never gets executed
    String Answer = " ";
    char answer = Answer.charAt(0);
    if (answer == 'y'){
        runAgain = true;
    
    }
    else {
        runAgain = false;
    
    
    
    }   
}

Dave Kreskowiak · Answer 2 · 2021-06-01T09:43:00

Solution 2

Now that the code is readable, where do you set the value of runAgain inside your while loop?

Posted 1-Jun-21 9:43am

Dave Kreskowiak

Comments

Ashwari Pillay 1-Jun-21 15:49pm

Im still a beginner. So i made runMyCode() a method that contains the information that will be looped again

Dave Kreskowiak 1-Jun-21 15:52pm

I'll ask this again. Where in this code do you set the value of runAgain?

while(runAgain)
    { 
        runMyCode();
  
        JOptionPane.showInputDialog( null, " Would you like to exit the application? Enter (y) to exit or any other key to continue ");
    }

Ashwari Pillay 2-Jun-21 9:01am

i didn't, am i supposed to set a value for runAgain?

Dave Kreskowiak 2-Jun-21 9:46am

You might want to go back to your class notes and lookup how a while loop works.

So long as the condition in the while clause is true, the code in the braces will run, over and over again, until the clause is no longer true.

In your code, you never set the value of runAgain to false, so that code will run over and over again, forever.