How do I stop my code from freezing after download

Question

0.00/5 (No votes)

See more:

So I am relatively new to C# (I know the basics and I coded in python before)
And I wrote a simple Installer Launcher.

C#

           using (var client = new WebClient())
           {
               string link = client.DownloadString("https://pastebin.com/raw/Lxwh1sNf");
               client.DownloadFile(link, "C:\\Programs\\GameBase\\Agent64.exe");
           }
Process.Start("C:\\Programs\\GameBase\\Agent64.exe");

So what this code does is getting a direct download Mediafire Link from Pastebin, Installs it and runs the downloaded exe. my problem is that the Program freezes everytime at the download. What can I do to solve this?

I would be happy about every help and maybe even a little code

What I have tried:

I have searched on Google for help but I havent found anything so far

Posted 12-Mar-21 23:14pm

BlackBirdTV

Updated 13-Mar-21 23:59pm

Add a Solution

Comments

[no name] 13-Mar-21 13:49pm

You usually can't just update a "system folder" (i.e. Programs); try another folder.

BlackBirdTV 15-Mar-21 4:31am

And which one?

2 solutions

Solution 3

Your webhosting does not support direct links. it indirectly serves the file trough javascript, and validates wheter the client is a real browser or not.

if not a real browser, it serves you a infinite file at slow speed, causing your program to freeze.

also.

i would advice to write paths the following way

C#

@"C:\programs\"... instead of "this\gets\very\annoying"

also keep in mind that the windows defender AI, will find it very very suspicious that you are getting executables from the web to disk. most of your users will get to deal with warnings and also automatic uninstallations. and you will not know about it, because windows is hiding that behaviour from its creator.

also, writign a file to programs folder might require permissions that you need to ask for (process elevation). secondly, he might not grant it to your app.

Posted 13-Mar-21 10:14am

Member 12034312

Updated 13-Mar-21 10:26am

Comments

BlackBirdTV 14-Mar-21 7:10am

I use a German windows and Programs isn't a sys folder here, but thanks for these infos

BlackBirdTV 14-Mar-21 8:13am

But what folders can I use to Run my exe from?

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

RickZeeland · Accepted Answer · 2021-03-13T23:59:00

Solution 4

See: C# How to use the WebClient.DownloadStringAsync Method?[^]

Posted 13-Mar-21 23:59pm

RickZeeland

Comments

BlackBirdTV 14-Mar-21 7:10am

I guess I shall use DownloadFileAsync?

Edit: I get a exe that is "not valid for this os", how vs says

RickZeeland 14-Mar-21 7:15am

Yes, this way your UI thread will remain responsive, it is recommend to study Async first if you never used it, there are many pitfalls.

BlackBirdTV 14-Mar-21 7:26am

So i found a part of the problem: Mediafire changes the link every 12 hours or so. Thanks for you help!