How do I fix close program error ?

Question

0.00/5 (No votes)

See more:

hi everyone today i encountered with new error and i dont know the reason. please help me.
when i run the code this error appears :
this application has requested,the runtime to terminate it in an unusual way.

What I have tried:

C++

#include <bits/stdc++.h>
#include <iostream>
#include <cmath>

using namespace std;

// Complete the repeatedString function below.
long repeatedString(string s, long n) {

   long counter=0 ;

for (int i=0 ; i<(n/s.size())+1 ; i++) {

        for (int k=0 ; k<s.size() ; k++) {
            s+=s[k] ;

            if (s.size()==n) {
                break ;
            }
        }

            if (s.size()==n) {
                break ;
}
}

for (int u=0 ; u<s.size() ; u++) {
    if (s[u]=='a') {
        counter++ ;
    }
}

return counter;
}

int main() {

cout <<repeatedString("a",1000000000) ;

return 0;
}

Posted 26-Oct-19 10:19am

Member 14586345

Updated 27-Oct-19 8:10am

KarstenK

v2

Add a Solution

Comments

Afzaal Ahmad Zeeshan 26-Oct-19 18:25pm

That does not help us understand the problem, please run the program with a debugger.

CPallini 28-Oct-19 5:32am

What is your code expected to do?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Rick York · Answer 1 · 2019-10-26T15:23:00

I think you are exceeding the available memory space of the process. Look at the loops. The inner one goes from 0 to s.size(). Within the loop you are appending a part of the string to itself. Every time you do this the size of the string gets bigger until the size equals the value passed. What happens if the size never matches n? The for loop will continue until all available memory is used and then the process will terminate.

Try changing your checks to if( s.size() >= n ).

Also try passing smaller numbers to make sure the logic works as you expect it to. Start with small values like 10 and then gradually increase the number in orders of magnitude and see how long it can run. What I mean is try 10, 100, 1000, 10000, etc...

KarstenK · Answer 2 · 2019-10-27T08:10:00

Solution 2

What about debugging your code? It is a common task.

Read this tutorial about basic debugging tactics to expand your skills.

Posted 27-Oct-19 8:10am