My player1 - how to make it go to different destinations ?

Question

1.00/5 (1 vote)

See more:

My player1 is not going to ironField. It's going to city directly.
How to make it go to different destinations ?

public Form1()
{
    player1.GoTo(ironField.x, ironField.y);
    player1.GoTo(city.x, city.y);
}
Entity player1 = new Entity();

public class Entity
{
    public void Initialize1()
    {

        Moving.Tick += new EventHandler(timer_Moving_Tick);
        Moving.Interval = 10;
    }

    private Timer Moving = new Timer();
    void timer_Moving_Tick(object sender, EventArgs e)
    {
        if (Xloc < x) //Xloc + width + 1
        {
            x -= speed;
        }
        if (Xloc > x)
        {
            x += speed;
        }

        float YlocB = Yloc - height - 1;
        if (YlocB < y)
        {
            y -= speed;
        }
        if (YlocB > y)
        {
            y += speed;
        }

        if (Xloc == x & YlocB == y)
        {
            Moving.Stop();
        }
    }

    float Xloc = 0, Yloc = 0;
    public void GoTo(float X, float Y)
    {
        Xloc = X; Yloc = Y;
        Moving.Start();
    }

Thank you.

What I have tried:

the code i put in ....

Posted 15-Nov-18 3:41am

_Q12_

Updated 15-Nov-18 5:31am

Add a Solution

Comments

F-ES Sitecore 15-Nov-18 9:47am

You're not waiting for "player1.GoTo(ironField.x, ironField.y);" to end before calling "player1.GoTo(city.x, city.y);" so it's like the first call is never made.

You need to implement some kind of mechanism that allows your code to wait and respond to other events. You could possibly use an even in your timer method and that event is raised when the player has got to the destination. You could then use that event to move them to the second destination.

_Q12_ 15-Nov-18 9:56am

Thank you! I was thinking on using events but i don't know how to implement Custom events. Can you make an example how you think it should work?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

F-ES Sitecore · Accepted Answer · 2018-11-15T05:32:00

In your Entity class define these

public delegate void MoveFinishedHandler();
public event MoveFinishedHandler OnMoveFinished;

Inside timer_Moving_Tick amend like so

if (Xloc == x & YlocB == y)
{
    Moving.Stop();

    if (OnMoveFinished != null)
    {
        OnMoveFinished();
    }
}

Kick your movement off like

player1.OnMoveFinished += Player1_OnMoveFinished;
player1.GoTo(ironField.x, ironField.y);

and define the event handler;

private void Player1_OnMoveFinished()
{
    // unregister the event as we no longer want to do anything when moving has finished
    player1.OnMoveFinished -= Player1_OnMoveFinished;
    player1.GoTo(city.x, city.y);
}

That will cause your Entity class to call the event handler when it has finished moving, and that event handler then starts the next movement.

If I was you though I'd probably create a list or array of target locations instead and define that with the player, and then code it so that when one movement ends it gets the next location in the list (if there is one) and moves to that too. That way you could do something like

player1.AddLocation(10, 10);
player1.AddLocation(20, 20);
player1.Move();

and the Move function would move to 10,10 and then 20,20.