|
Maybe it is used as a symbolic constant in various places and the author wanted to be able to change it in just one place. However, in this case the variable name is not the best choice and it should of course be const.
The good thing about pessimism is, that you are always either right or pleasently surprised.
|
|
|
|
|
it is used in exactly one place.
And the uselessness of it is EXACTLY the naming of it.
|
|
|
|
|
Coding standards 1 common sense 0 (this is almost certainly because of a 'no magic numbers' code rule)
|
|
|
|
|
But... that is not a variant of BASIC.. how can bad code be written in a non-BASIC language? Did we experience a shift to an alternate universe?
|
|
|
|
|
Tim Carmichael wrote: how can bad code be written in a non-BASIC language?
You evidently haven't worked the same places I have 
worst code I ever saw was in COBOL!
|
|
|
|
|
Seems fair but should be declared as const.
|
|
|
|
|
I think the developer believed in "Self Documented Code".
It would have been much better if was something like:
public static int TenSeconds = 20;
|
|
|
|
|
Recently I looked into the source code of one of my colleges.
He wrote:
Private Sub startdestroy()
Dim th As New System.Threading.Thread(AddressOf destroy)
th.Start()
End Sub
Public Sub destroy()
Dim uuid As System.Guid = Nothing
While True
uuid = System.Guid.NewGuid()
End While
End Sub
I didn't understand what he was trying to achieve, so I asked him.  What is this source code about?  This thread is only costing performance doing nothing.
It could cause the garbage collector to throw out of memory exceptions.  and the program will be dead  And anyway this strange combination of public and private seems odd to me.
Tell me why you programmed this?
Very simple, told me my college. If I run this code on many computers, a lot of GUIDs will be created.
And capitalism relies on GUIDs . After a few years running my code on as many computers as possible, there are no GUIDs left in this world, and the capitalists cannot transfer money anymore, because they need a way to identify each money transaction in a unique way . I fired this routine in an own thread so nobody will notice what evil thing is going on in the background.  It's a timebomb against capitalism. 
This is why I am running this code on many computers. Just to destroy capitalism. 
I agreed on the point that destroying evil captitalism is a good thing to do. But I said: If you continue your evil work, not only banks and capitalists are effected. Also good institutions like health care are effected. Rescue services can't operate anymore because they are also using GUIDs and they will certainly run out of GUIDs if you continue your evil work.  Emergency numbers won't work without GUIDs.
I few hours later I got an EMAIL from my college stating rhat
he removed the code because of the great sideeffects. Yes, he agreed that rescue services need GUIDs to store medical data. And that the revenue department needs them too, so they can store financial transactions originating from the Cayman Islands and fight tax offenders.
Instead he will run for parlament in the next general elections. The good sideeffect is: He will earn tons of money , because members of parlament earn much more money than programmers do.
|
|
|
|
|
My previous manager considered code reviews a waste of time. I have just sent him this
|
|
|
|
|
This is really stupid. There is no central GUID system or whatever. A GUID is just generated and not taken from a pool of available GUIDs.
|
|
|
|
|
really 
And i thought I saved capitalism and the world by stoping my college
OK back to work using GUIDs. I am creating a lot of them nowadays
Imports System.Runtime.InteropServices
<Guid("xxxxxxxx-1DFD-40d2-BA5F-62C961B2AAC8"), _
ClassInterface(ClassInterfaceType.None), _
ProgId("xxxx.xxxx")> _
Public Class xxxxx
Implements xxxxx
COM, yes COM seems to be popular again 
xxxx just for hiding my true identity
|
|
|
|
|
The beauty of numbers is that you can always add 1 
The sad life of any programmer is that memory is limited
|
|
|
|
|
chayaphum wrote: And i thought I saved capitalism and the world by stoping my college
Nope, probably not.
A Guid is 128 bits, with 6 of them reserved: 2 for variant, 4 for version, so there are 2122 or 5,316,911,983,139,663,491,615,228,241,121,400,000 possible GUID values you can generate.
Even if your colleague's software was creating 1,000,000,000,000 per second, and running on every computer connected to the internet (and the latest figure for that I can find is 4 years old - 1,966,514,816) it would take 85,734,504 years to generate them all...
Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952)
Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)
|
|
|
|
|
Well we better get started then.
Don't comment your code - it was hard to write, it should be hard to read!
|
|
|
|
|
|
I can't see the wonderful part of it... 
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
|
|
|
|
|
I think it's Hamster sarcasm: it used to be called "Coding Horrors" 
Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952)
Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)
|
|
|
|
|
Never understood hamsters...
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
|
|
|
|
|
Hamsters are easy to understand: they are a "parent annoying device".
The principle things you need to know about Hamsters are twofold:
1) They breed like...well, hamsters. "Copiously" is a good word. Children seem to like this.
2) They die. Normally on Christmas Eve, and this leads to the True Purpose of the Hamster: It must be replaced with an identical model before the child notices. Hence the timing of deceasement: to cause maximum inconvenience to the parent, given that the pet shop closes in 30 minutes...
Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952)
Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)
|
|
|
|
|
Herebefore there're two forums. Coding Horrors & Clever Code[^]. Hamsters merged those two to current one.
thatrajaCode converters | Education Needed
No thanks, I am all stocked up. - Luc Pattyn
When you're wrestling a gorilla, you don't stop when you're tired, you stop when the gorilla is - Henry Minute
|
|
|
|
|
Your college is an idiot on so many levels. Becoming a politician seems quite fitting.
|
|
|
|
|
Jörgen Andersson wrote: Your college is an idiot on so many levels.
Well, they are big buildings... 
Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952)
Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)
|
|
|
|
|
Jörgen Andersson wrote: college
colleague - FTFY...
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
|
|
|
|
|
Read the OP once more. 
|
|
|
|
|
chayaphum wrote: Recently I looked into the source code of one of my colleges.
He wrote:
Private Sub startdestroy()
Dim th As New System.Threading.Thread(AddressOf destroy)
th.Start()
End Sub
Public Sub destroy()
Dim uuid As System.Guid = Nothing
While True
uuid = System.Guid.NewGuid()
End While
End Sub
I didn't understand what he was trying to achieve
Typical of VB programmers! 
chayaphum wrote: Tell me why you programmed this?
Very simple, told me my college. If I run this code on many computers, a lot of GUIDs will be created.
And capitalism relies on GUIDs . After a few years running my code on as many computers as possible, there are no GUIDs left in this world, and the capitalists cannot transfer money anymore,  because they need a way to identify each money transaction in a unique way . I fired this routine in an own thread so nobody will notice what evil thing is going on in the background. It's a timebomb against capitalism.
This is why I am running this code on many computers. Just to destroy capitalism.
Typical of VB programmers!
chayaphum wrote: I agreed on the point
Typical of VB programmers!
chayaphum wrote: A few hours later I got an EMAIL from my college stating rhat
he removed the code because of the great sideeffects.
Typical of VB programmers!
The report of my death was an exaggeration - Mark Twain
Simply Elegant Designs JimmyRopes Designs
I'm on-line therefore I am.
JimmyRopes
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
