|
The intent was to write: return i++;
KP Lee wrote: That's rich. Trying to learn better coding by studying poor code harder.
I think fixing bad code is a great way to learn, especially if you learn the "why" along the way.
|
|
|
|
|
It should be 'return i + 1'. ++i is a wasteful update of the variable i, assuming it's local (there's some serious issues if it isn't anyway), and i++ is just wrong because it returns i (before the statement) and not i + 1.
|
|
|
|
|
That was interesting.
Why is it that ++i is less efficient then returning i + 1?
Isn't a calculation made (total of i + 1) made in memory somewhere regardless?
|
|
|
|
|
It's likely that compiler optimisations make it irrelevant in this case. But in the general case, she using ++i the value is copied into i after being calculated, then copied into the return variable. Using i+1 only copies it to the return variable (one less copy).
|
|
|
|
|
Interesting.
Thank you for the informative response.
|
|
|
|
|
I'm not surprised, see it all the time. This happens as a result of changing the condition, i.e. the code was written for one condition, then the condition changed, and the code was updated without logical refactoring.
Also, some developers like making code temporarily unreachable rather than commenting it out, i.e. putting the code into a block like:
if(false){...code...}
|
|
|
|
|
Developer took special math classes... 
|
|
|
|
|
Almost 12 years ago (before I joined the company  ), this little beauty almost made it into the release build of one of our applications:
CString strTimeZone;
timeb timeptr;
ftime(&timeptr);
long TimeZone = (long)timeptr.timezone/(long)60;
switch(TimeZone)
{
case 8:
strTimeZone = "P";
break;
case 7:
strTimeZone = "M";
break;
case 6:
strTimeZone = "C";
break;
case 5:
strTimeZone = "E";
break;
default:
AfxMessageBox("Invalid TimeZone. Please Move.");
}
Soren Madsen
|
|
|
|
|
It's not a horror - at least he checked - but it's not that helpful an error message, I must admit. However, it does give advice on how to solve the problem which is a vast improvement on most MS error messages of 12 years ago! 
Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water
|
|
|
|
|
You are a true the-glass-is-half-full guy
Soren Madsen
|
|
|
|
|
I think that serves people right for living in invalid timezones!
I'm glad someone was finally willing to tell them 
I'm pretty sure the programmer was thinking of timezones such as GMT+4,35 and GMT-27
It's an OO world.
public class Naerling : Lazy<Person>{
public void DoWork(){ throw new NotImplementedException(); }
}
|
|
|
|
|
I wanted to share this, so I actually went to find it in our old SourceSafe database. I deleted a few lines of code that really did nothing, so what you see is what it did.
Today in its place, the code formats a date/time with abbreviated time zone and Daylight saving information - getting the TZ abbreviation right is still a hit and miss (when TZ is outside the US), but at least you don't have to move
Soren Madsen
|
|
|
|
|
SoMad wrote: getting the TZ abbreviation right
You mean something like "MST"?
Simple solution then - there is no deterministic way to solve this because there are time zone abbreviations that are the same for different zones. Best one can do is to
- Use a numeric offset
- Require an environment configuration that matches that offset.
|
|
|
|
|
I recall seeing an error message something like
that a while back.
I thought it was rather stupid, given the fact that
I had just clicked on an item in a drop down list.
I think someone was trying to be funny.
ST
|
|
|
|
|
Well i suppose it wasn't meant to be used outside North America, so it may help avoid the use of illegal copies of that program on China.
|
|
|
|
|
Well, he accounted for EST, not EDT, so I assume for most of the year he got an error for east coast users.
|
|
|
|
|
|
|
I found pretty much the opposite recently...
value = String.Format("Some text here.");That didn't do much good either
It's an OO world.
public class Naerling : Lazy<Person>{
public void DoWork(){ throw new NotImplementedException(); }
}
|
|
|
|
|
I came across many of those in our code years ago from programmers that have since moved on.
The first time I saw it I was thinking "Hmmm. This probably used to have some parameters in it and got modified for some reason". After seeing 5-10 more like that I was just thinking "Hmmm." 
Soren Madsen
|
|
|
|
|
Well, I know the programmer who did this in our software.
When asked why he did that he said "I thought that would be useful in case the string ever needed parameters".
He was basically making our software 'future proof'
It's an OO world.
public class Naerling : Lazy<Person>{
public void DoWork(){ throw new NotImplementedException(); }
}
|
|
|
|
|
Did you slap him or punch him in the stomach?
Soren Madsen
|
|
|
|
|
Nope, that would have been very unwise. That guy is my boss!
It's an OO world.
public class Naerling : Lazy<Person>{
public void DoWork(){ throw new NotImplementedException(); }
}
|
|
|
|
|
|
Right. Because adding
String.Format later would be just too hard.
Really, you actually might have to use the arrow keys or the mouse to select in the middle of the line.
In truth, I know someone who would erase and retype the entire line to add something to the middle of it. I am fairly happy to report that he is now out of code and in management instead.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
