The Weird and The Wonderful

int    t1   = 0;
int    t2   = 0;
string temp = "";
string orig = "";

if (lblSortOrder.Text==e.SortExpression)//if they click the same column reverse order
{
    Trace.Write("asdf","in order switcher");
    lblSortOrder.Text +=" DESC";
}
else if (lblSortOrder.Text.IndexOf(e.SortExpression)== -1)//if they click a different column use both sort terms
{
    Trace.Write("asdf","in column adder");
    temp=e.SortExpression;
    temp+=", "+lblSortOrder.Text;
    lblSortOrder.Text=temp;
}
else if (lblSortOrder.Text.IndexOf(',')!=-1)//if the first two fail and is a multi column search
{
    if (lblSortOrder.Text.IndexOf(e.SortExpression)!=-1)//if expression is in the sort string, make it primary and reverse its order
    {
        orig=lblSortOrder.Text;
        t1=orig.IndexOf(e.SortExpression);
        t2=orig.IndexOf(",",t1)-t1;

        if(t2>=0)
        {
            temp=orig.Substring(t1,t2);
        }
        else
        {
            temp=orig.Substring(t1);
        }
        //Trace.Write("orig after substring",orig);
        //Trace.Write("temp",temp);

        if(temp.IndexOf("DESC")!=-1)
        {
            orig=orig.Remove(t1,temp.Length);
            temp=temp.Remove(temp.IndexOf("DESC"),4);
            temp=temp.Trim();
            //Trace.Write("remove desc",temp);
        }
        else
        {
            orig=orig.Remove(t1,temp.Length);
            temp+=" DESC";
            temp=temp.Trim();
            //Trace.Write("add desc",temp);
        }
        orig=orig.Trim();
        lblSortOrder.Text=temp+","+orig;
    }//end if sort expression contained in sort string
    else
    {
        lblSortOrder.Text=e.SortExpression;
        //Trace.Write("???","you should never see this");
    }
}//end multi column else if
else
{
    lblSortOrder.Text=e.SortExpression;
}//end sort ifs

//remove any messed up commas
lblSortOrder.Text=lblSortOrder.Text.Replace(",," , ",");
lblSortOrder.Text=lblSortOrder.Text.Replace(", ," , ",");

//remove all strings after second column
t1=lblSortOrder.Text.IndexOf(",",lblSortOrder.Text.IndexOf(",")+1);
if(t1>10)
{
    lblSortOrder.Text=lblSortOrder.Text.Remove(t1,(lblSortOrder.Text.Length-t1));
}

• the program was using invisible pop-up windows as temporary data buffers to implement wizard-like operations in the user-interface, and never deallocating them.
• every variable was global
• there were no data structures anywhere for anything
• there were no functions other than those required by the GUI
• several functions were over 75 pages long - that's about 4500 lines of code in a single function
• the level of code redundancy was incredible; it was common to see the same 5-10 lines of code repeated several dozen times within the same function

USE [Database1]
GO
/****** Object:  StoredProcedure [dbo].[CheckConnection]    Script Date: 08/14/2008 10:54:38 ******/
SET ANSI_NULLS OFF
GO
SET QUOTED_IDENTIFIER OFF
GO
-- Validate User can hit the sql box. Basically doesn't do anything, except ensure I can see the sql box
-- Returns 1 if successful, 
-- 0 l if failed (one could ask, If I can't see the box, how is it going to return 0....I don't know).
-- 3/26/04 (via name omitted)
-- Assumes SQL Server 7.0 SP1 or better
ALTER  procedure [dbo].[CheckConnection]
@result char(1)  OUTPUT
AS 
set @result = "1"
RETURN

CYesNoDlgBar *yesNoBar = new CYesNoDlgBar(this, prompt);
yesNoBar->SetCadPtr(this);
ShowCadBarModal(yesNoBar);
ret = yesNoBar->GetResult() ? 1 : 0;
if (yesNoBar)
  {
  delete yesNoBar;
  yesNoBar = NULL;
  }