C#

Brian_TheLion wrote:

Why not just have Name = "Peter"

Richard MacCutchan wrote:

As others have mentioned, global variables tend to cause more problems than they solve; don't use them.

#realJSOP wrote:

I don't understand (and have never seen) a global static class present problems

Brian_TheLion wrote:

it seems that you need to keep within certain rules to have the program compile.

Brian_TheLion wrote:

Maybe some programs are better suited to C# than others.

Brian_TheLion wrote:

All programs seem to have a user interface as I've never come across a program that only runs under the DOS prompt.

Brian_TheLion wrote:

I'm being drawn towards C++ as it does allow global variables compared to C#.

public class GameObject
{
    public string Name { get; set; }
    public int Weight { get; set; }
}

public abstract class Container
{
    public int MaxWeight { get; set; }
    public int MaxItems { get; set; }

    public List<GameObject> Objects { get; private set; }

    public Container() : this(0, 0)
    {

    }

    public Container(int maxWeight, int maxItems)
    {
        this.Objects = new List<GameObject>();
        this.MaxItems = maxItems;
        this.MaxWeight = maxWeight;
    }

    public GameObject Find(string name)
    {
        return this.Objects.FirstOrDefault(o => o.Name.Equals(name, StringComparison.InvariantCultureIgnoreCase));
    }

    public bool CanContain(GameObject gameObject)
    {
        // if max items is set make sure we have room
        if (this.MaxItems > 0 && Objects.Count >= this.MaxItems)
        {
            return false;
        }

        // if max weight is set make sure we have capacity
        if (this.MaxWeight > 0 && Objects.Sum(o => o.Weight) + gameObject.Weight > this.MaxWeight)
        {
            return false;
        }

        return true;
    }
}

public class Player : Container
{
    public bool Get(Container container, string name)
    {
        // rather than returning true\false you can return an enum that is specific to
        // why the get failed
        GameObject targetObject = container.Find(name);

        if (targetObject == null)
        {
            return false;
        }

        if (!this.CanContain(targetObject))
        {
            return false;
        }

        container.Objects.Remove(targetObject);
        this.Objects.Add(targetObject);

        return true;
    }
}

public class Room : Container
{
    public string Name { get; set; }

    public Dictionary<string, Room> Exits { get; set; }

    public Room()
    {
        this.Exits = new Dictionary<string, Room>();
    }
}

static void Main(string[] args)
{
    Player player = new Player();

    Room startRoom = new Room();
    startRoom.Name = "Hallway";
    startRoom.Objects.Add(new GameObject { Name = "Key", Weight = 1 });

    startRoom.Exits.Add("north", new Room
    {
        Name="Kitchen"
    });

    Room currentLocation = startRoom;

    // if player does "get key"

    player.Get(currentLocation, "key");

    // if player does "go north"

    Room room = currentLocation.Exits["north"];
    if (currentLocation.Exits.ContainsKey("north"))
    {
        currentLocation = currentLocation.Exits["north"];
    }
    else
    {
        // can't go that way
    }
}

Brian_TheLion wrote:

I'm being drawn towards C++ as it does allow global variables compared to C#. I know that it's not good to use global variables and most variables should remind within their own class but it's not always easy to design a program like this and the program I have in mind that I want to write has many varables between classes.

Brian_TheLion wrote:

I have in mind that I want to write has many varables between classes. I could write it with less classes but I want to have classes for certain purposes that can be reused in other programs. It also makes the program easier to deal with when changes are made.

public class MyConfig
{
   [Export("MyValue")]
   public string SharedValue => "This is a value";
}

[Import]
public class MyBusinessObject
{
   [Import("MyValue")]
   public string ConfigValue { get; set; } // Will be initialized to "This is a value" 
}

[Import]
public class MyOtherBusinessObject
{
   [Import("MyValue")]
   public string Value { get; set; } // Will be initialized to "This is a value" 
}

public class SomeClass
{
   public static string SomeValue = "This is a Value";
}

public class SomeOtherClass
{
   public string LocalValue = SomeClass.SomeValue;
}