Re: C# Talking To All The ContextMenuStrip's [modified] - C# Discussion Boards

23-Aug-10 0:03

This is my code

        if (sender is ContextMenuStrip)<br />
    {<br />
        foreach (ContextMenuStrip item in (((ContextMenuStrip)sender).GetCurrentParent().Items))<br />
        {<br />
            if (item == sender) item.Checked = true;<br />
            if ((item != null) && (item != sender))<br />
            {<br />
                item.Checked = false;<br />
            }<br />
        }<br />
}

This is my error

Error	1	'System.Windows.Forms.ContextMenuStrip' does not contain a definition for 'GetCurrentParent' and no extension method 'GetCurrentParent' accepting a first argument of type 'System.Windows.Forms.ContextMenuStrip' could be found (are you missing a using directive or an assembly reference?)	C:\Users\Kyle\documents\visual studio 2010\Projects\Gadgets\Gadgets\Form1.cs	341	75	Gadgets

Can some please help me fix this?

Mycroft Holmes23-Aug-10 0:45

Mycroft Holmes

23-Aug-10 0:45

So where did you get the GetCurrentParent from, make it up or snaffle it from someone elses code? The error means that there is no supporting method.

Never underestimate the power of human stupidity
RAH

Rhuros23-Aug-10 1:26

23-Aug-10 1:26

Couple of things:

1. GetCurrentParent isn't a member of ContextMenuStrip
2. A context Menu item will arrive as a ToolStripDropDownItem and you will need to drill down from there to get the items you want...

Try this:

foreach (ToolStripMenuItem item in ((ToolStripDropDownItem)sender).Owner.Items)
{
       if (item == sender)
           item.Checked = true;
       else
           item.Checked = false;
}

C.CoderCreator23-Aug-10 22:33

23-Aug-10 22:33

Well the error I get with this is

Unable to cast object of type 'System.Windows.Forms.ToolStripSeparator' to type 'System.Windows.Forms.ToolStripMenuItem'.

So I would need to make it not notice the separator, what do you suggest?

Rhuros23-Aug-10 23:16

23-Aug-10 23:16

Yes I would suggest ignoring any of the spearators, as you don't need to set teh check state of these...

C.CoderCreator24-Aug-10 0:05

Re: C# Talking To All The ContextMenuStrip's [modified]

24-Aug-10 0:05

ok, Is this a good way to approach this problem?

foreach (ToolStripMenuItem item in ((ToolStripSeparator)sender).Owner.Items)
   {
   }

Rhuros24-Aug-10 0:50

24-Aug-10 0:50

No a better approach would be to:

foreach (ToolStripItem item in ((ToolStripDropDownItem)sender).Owner.Items)
{
    if (item.GetType() == typeof(ToolStripMenuItem))
    {
        if (item == sender)
            ((ToolStripMenuItem)item).Checked = true;
        else
            ((ToolStripMenuItem)item).Checked = false;
    }
}

testing for the items type before you set teh check state of an item.

modified on Tuesday, August 24, 2010 8:41 AM

C.CoderCreator24-Aug-10 0:55

24-Aug-10 0:55

Thats way better but its bad because it overflows

An unhandled exception of type 'System.StackOverflowException' occurred in System.Windows.Forms.dll

Rhuros24-Aug-10 1:07

24-Aug-10 1:07

really, the example I'm using here doesn't. I have a context menu with 3 menu items 1 separator 1 dropdown list and 1 test box ... and it seems to set the check state correctly...

Is your code a complete copy or my or have you just instered the elements you need?

I also assume that you are using this kind of approcah as you have multiple context menues and multiple menu options and only wish to have one function to do the work?

C.CoderCreator24-Aug-10 1:11

Re: C# Talking To All The ContextMenuStrip's [modified]

24-Aug-10 1:11

I put that code in and not edited it

Rhuros24-Aug-10 1:24

24-Aug-10 1:24

ok, the only reason that you'd be getting a stack overflow from this loop is if new menu items were being added to the context menu strip, so in effect you'd be getting an ever increasing list.

That's something to check also to make sure that during each iterration of the loop that the count list count doesn't change.

As I said the example snippet I have here doesn't exhibit that issue....

Aslo as I mentioned earlier you can directly access the menu items and context menu required without looping round, for example:

// accessing the menu items directly


myToolstripMenuItem1.Checked = true;
myToolstripMenuItem2.Checked = false;
myToolstripMenuItem3.Checked = false;

// accessing the ContextMenuStrip directly

foreach (ToolStripMenuItem item in myContextMenuStrip.Items)
{

.......

}

modified on Tuesday, August 24, 2010 8:40 AM

C.CoderCreator24-Aug-10 22:05

24-Aug-10 22:05

I still don't know how to fix this over flow problem

Rhuros25-Aug-10 1:08

25-Aug-10 1:08

As I mentioned something must be adding more ToolStripMneuItems to the ContextMenuStrip.Items collection.

Are you adding context menu items programmatically?

C.CoderCreator25-Aug-10 19:55

25-Aug-10 19:55

No I just made the strips as I did like, heres a example in visual mode

Strip1
Strip2
Strip2
Strip4
separator
Strip5

Rhuros25-Aug-10 23:11

25-Aug-10 23:11

Ok I don't understand why you are getting a stack overflow, which is very strange...

What I would suggest then is this:

1. Turn all the items checked states off.
2. Tunr on the senders checked state...

// set all checked states to false
strip1.Checked = false;
strip2.Checked = false;
strip3.Checked = false;
strip4.Checked = false;
strip5.Checked = false;

// set the senders checked state
((ToolStripMenuItem)sender).Checked = true;

As you know have already defined the objects and have their names already you don't need to cycle for them, however its not as elegant as the other solution.

I'm still interested in why you getting the stack overflow, can you debug into the loop and examine ((ToolStripDropDownItem)sender).Owner.Items as this must be going up as it cycles round the loop...

And you are statically creating the items through the designer and not programtically??