C#

private DataRow CreateNewRow(DataTable table);
private bool IsDataRowValid(DataRow row);
private DataTable LoadDataTable();
private string CalculateSomeImportantDataFromRow(DataRow row);

Ennis Ray Lynch, Jr. wrote:

2) Try to avoid using members as global variables. You introduce a lot of state into your objects that can be difficult to manage.

Ennis Ray Lynch, Jr. wrote:

3) checkValue is misspelled. No matter which naming convention you use BE CONSISTENT! Your method should have been named CheckValue and yes it is an important distinction since checkValue tells experienced c# developers they are looking for a local variable.

Ennis Ray Lynch, Jr. wrote:

5) Your two samples actually have different results! See if you can find it.

Ennis Ray Lynch, Jr. wrote:

6) Never use implicit scope.

Ennis Ray Lynch, Jr. wrote:

I would provide a good example of how to do what you are asking

public static class Foo{


private static DataTable GetDataTableFromFile(string filePath);
private static bool IsRowValid(DataRow dataRow);
private static void WriteRowToStream(Stream stream);

public static void OutputXmlFileToTextFileOrSomeOtherJunk(string inputFilePath, string outputFilePath){
    DataTable data = GetDataTableFromFile(inputFilePath)
    //if you want to sort, use data.DefaultView.Sort and
    //then loop on foreach(System.Data.DataRowView v in data.DefaultView)
    using(FileStream stream = new FileStream(outpuFilePath, FileMode.Create, FileAccess.ReadWrite)){
        foreach(DataRow row in data.Rows){
            if(IsRowValid(row)){
                WriteRowToStream(row);
            }
        }

    }
}
}

jainiraj wrote:

please DO NOT DISTURB

jainiraj wrote:

please DO NOT DISTURB

jainiraj wrote:

1 thing I want to ask u, have u given any suggestion related to query..
R u getting what I want to ask or it may be possibilty there may be free tool but U are not aware of it.
So please if u don know , please DO NOT DISTURB.

string folderConfig = 
  ConfigurationManager.AppSettings["file"].Replace("${APPDATA}", 
  Environment.SpecialFolder.ApplicationData);

string folderConfig = Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData)