|
Hi all. I am stuck witha bit of a problem. I am using Threads to do my processing and to update my prgressbar. Below some of the code.
ThreadCode
private void btnRun_Click(object sender, EventArgs e)
{
ThreadStart excelrun = new ThreadStart(RunExcel);
Thread startprogress = new Thread(excelrun);
startprogress.Name = "Update ProgressBar";
startprogress.Start();
}
Code in the RunExcel calling the Progressbar thread.
progressBar1.Invoke(new updatebar(this.UpdateProgress));
UpdateProgress Code
private void UpdateProgress()
{
string filepath;
filepath = txtboxSelectTxtFile.Text;
int lines = File.ReadAllLines(filepath).Length;
progressBar1.Minimum = 0;
progressBar1.Maximum = lines;
progressBar1.Value = progressBar1.Value + 1;
int progrval = 0;
progrval = progressBar1.Value;
progrval = progrval + 1;
lblProgress.Text = ((progrval * 100) / Convert.ToInt32(progressBar1.Maximum)).ToString();
lblProgress.Refresh();
lblPercent2.Refresh();
lblRecordProcessed.Text = progrval.ToString();
lblProgText.Refresh();
lblRecordProcessed.Refresh();
}
As you can see from the above that eachtime the progressbar thread is called it does a read of the whole file to obtain the file size which is pretty inefficient. How can I change this to only read the file size once, store the size and use that to determine the Maximum size?
I am stuck and not sure how to get this changed to work more efficiently.
Excellence is doing ordinary things extraordinarily well.
|
|
|
|
|
Set the progressbar's minimum and maximum once and not everytime in UpdateProgess. My suggestion would be to do it in RunExcel where you are processing the file(i guess so). In UpdateProgress keep on updating the current progressbar's value.
Edit - typo
|
|
|
|
|
Thanks AbitSmart. I'll try this and see how it goes.
Excellence is doing ordinary things extraordinarily well.
|
|
|
|
|
I tried this and I get the following Cross Thread Error when running the App.
"Cross-thread operation not valid: Control 'progressBar1' accessed from a thread other than the thread it was created on."
Any other Ideas??
Excellence is doing ordinary things extraordinarily well.
|
|
|
|
|
You will have to use Invoke/BeginInvoke to update the progressbar value in another thread.
|
|
|
|
|
Furthermore,
Kwagga wrote: int lines = File.ReadAllLines(filepath).Length;
does not make sense. You don't need the actual content to determine file length, have a look at
the FileInfo class.
Luc Pattyn [Forum Guidelines] [My Articles]
- before you ask a question here, search CodeProject, then Google
- the quality and detail of your question reflects on the effectiveness of the help you are likely to get
- use the code block button (PRE tags) to preserve formatting when showing multi-line code snippets
|
|
|
|
|
I have previously tried the FileInfo Class but this then gave me problems in that with the FileInfo I get the file size and then Divide that by 1000 which left me with a rough number of say 237 if the file was 237000kb. The file has more lines than that in it and would abort when it reached 237 lines.
This is why I am trying to do it this way, get the number of records in the file once and pass that to the progressBar1.Maximum. Hope this makes sense?
Excellence is doing ordinary things extraordinarily well.
|
|
|
|
|
Yes I saw your earlier post with the 237 problem, which basically was caused by your code acting
as if each line contained 1000 characters.
Anyway, when you need file size in bytes, ask FileInfo, you don't need the content;
when you need file size in lines, loop a ReadLine and count them, you don't need to hold all the
lines at once (just to get array.Length), it is a waste of cycles and bytes, and an unnecessary
limitation to your app.
Luc Pattyn [Forum Guidelines] [My Articles]
- before you ask a question here, search CodeProject, then Google
- the quality and detail of your question reflects on the effectiveness of the help you are likely to get
- use the code block button (PRE tags) to preserve formatting when showing multi-line code snippets
modified on Friday, June 10, 2011 11:41 PM
|
|
|
|
|
But my problem with this is that each time the progreassbar thread is called it does a read to count the number of lines. Now, if I have a file with say 50000 lines of data then after each line processed it has to read through the file to get the number of lines. This is just very cumbersome and there has to be a better way of doing it. Like just getting the number of lines once and passing that the progressbar.maximum once?
Excellence is doing ordinary things extraordinarily well.
|
|
|
|
|
Kwagga wrote: But my problem with this is ...
so change it.
Kwagga wrote: Like just getting the number of lines once and passing that the progressbar.maximum once?
that's the advise given to you by ABitSmart; rather than repeating his words, why don't you implement it?
Luc Pattyn [Forum Guidelines] [My Articles]
- before you ask a question here, search CodeProject, then Google
- the quality and detail of your question reflects on the effectiveness of the help you are likely to get
- use the code block button (PRE tags) to preserve formatting when showing multi-line code snippets
|
|
|
|
|
Hi,
I have a R.A.D Window.I want when OnClientClose event raised my C# public void called.
I appreciate.
|
|
|
|
|
HI!! i have inserted image into access database. i actually want to store the address of that particular image in database. so that at the time of retrieval i will pass that address in the ASP.net image url in order to display the image. can someone help me to do this please. i have written the code in C#.
Thanks in advance.
|
|
|
|
|
|
Hi,
First of all i would like to say thanks for ur help.I plan to do the project on Networking side.
my project is ""Send SMS to Multiple recipients using C# language"".I dont have any idea about my project and also what are the external resources and software need to run this project and how to attach h/w with system.Could you please help me.
Thenmozhi.....
|
|
|
|
|
oviyaa wrote: I dont have any idea about my project
Too bad! It's your project, not ours. You have no clue at all, what to do? Then better stop it now!
oviyaa wrote: Could you please help me.
is a really stupid request here. Ask a question about a specific problem.
[edit] Ahh, you asked that question before. You say "i am a Final year MCA Student...". Can't believe that.[/edit]
|
|
|
|
|
I've not done this before but i believe what you need to research on are AT commands. AT commands are used by the phones and that is the interface you use when writing a program to access the phone. I have seen someone do something of the sort using VB 6.0 so your best start would be to search AT commands using VB. Net and they being somewhat similar to C Sharp, you might find a way.
Success in your project.
|
|
|
|
|
For software side you need to implement AT Commands with any programming language. if you dont know then you can use this resource[^].
And at hardware side you required a GSM Modem / GSM Router / Nokia Phone with data cable. These all can be connected to your pc using serial port. and then you just have to bind it using the atsms library.
But for a MCA final year project. I think this is too small application. this is just 2 weeks job. so for 6 months project. you have to think about an application which contains bulk sms sending as a part of it.
Becasue database design will be too simple for this one, and also what will you write in your project documentation ?
|
|
|
|
|
if(!(iRet = isNumber(ptrToken)))
{
if(!(iRet = isChar(ptrToken)))
{
if(!(iRet = isComma(ptrToken)))
{
if(!(iRet = isHyphenDelimiter(ptrToken)))
{
if(!(iRet = isSlashDelimiter(ptrToken)))
{
if(!(iRet = isHashDelimiter(ptrToken)))
{
if(!(iRet = isAmpersandDelimiter(ptrToken)))
{
ptrTOken is the input given.... is there anyway to use regular expression here
the quieter u become more u hear
|
|
|
|
|
That depends on what your methods do, but perhaps a pattern like this:
^[^\dA-Za-z,\-/#&]$
Despite everything, the person most likely to be fooling you next is yourself.
|
|
|
|
|
thanks a lotttt 
the quieter u become more u hear
|
|
|
|
|
Hi,
protected void Application_BeginRequest(object sender, EventArgs e)
{
HttpContext context = HttpContext.Current;
if (context.Request.FilePath.ToString().StartsWith("/hotels-in-"))
{
context.RewritePath("country.aspx");
}
}
this is my code in global.asax.cs file
this code is working in local system but when i uploaded the project to server its not working what to do??........
please help me...thx
icanmakeiteasy
|
|
|
|
|
When you say that it's "not working", what do you mean? What happens, and how does that differ from what you expect? Do you get any error message?
Despite everything, the person most likely to be fooling you next is yourself.
|
|
|
|
|
http://........../hotels-in-India //url is like this
Not Found
The requested document was not found on this server.
just its showing like this
icanmakeiteasy
|
|
|
|
|
You can only use url rewriting in the ASP.NET code if the request is handled by the ASP.NET engine. When you run it locally all requests are handled by the ASP.NET engine, but not on the server.
Change the url to one that is handled by the ASP.NET engine, change which extensions are handled by the ASP.NET engine, or use a url rewriting component.
Despite everything, the person most likely to be fooling you next is yourself.
|
|
|
|
|
thx for reply ...
then let me know how to use url rewriting component
icanmakeiteasy
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
