Error happen when open file while migrate VC++ 6 to VS2008 - C / C++ / MFC Discussion Boards

c++ code

phineas kimathi19-Jul-12 2:46

phineas kimathi

19-Jul-12 2:46

a code to change string to uppercase using integer values within the code.

Re: c++ code

Richard MacCutchan19-Jul-12 3:21

Richard MacCutchan

19-Jul-12 3:21

There are built in library and MFC functions to perform this. Please explain what you mean by "change string to uppercase using integer values"?

One of these days I'm going to think of a really clever signature.

Re: c++ code

Rajesh R Subramanian19-Jul-12 3:34

Rajesh R Subramanian

19-Jul-12 3:34

Hint: There's an offset of 32 between lower and upper cased letters. For example, the ascii value (int) of lower case 'c' is 99, and the same of upper case 'C' is 67.

"Real men drive manual transmission" - Rajesh.

Re: c++ code

Software_Developer19-Jul-12 6:52

Software_Developer

19-Jul-12 6:52

The integer difference between a lowercase char and a uppercase char when subtracted is 32.
simply subtract the lowercase by 32 to get a uppercase char.

#include <stdio.h>
#include <string.h>

int main(void)
{
	char strchr[32] = "the quick fox";
	int strlength=strlen(strchr);

        printf("Before\n" );
	printf("%s\n\n", strchr);
 
	for (int i=0; i<strlength; i++) 
	{
		if((strchr[i] >= 97) && (strchr[i] <= 122)) 
		{
			strchr[i] = strchr[i] -32;
			
		}
	}
        printf("After\n" );	 
	printf("%s\n\n", strchr);

return(0);

}

Re: c++ code

Richard MacCutchan19-Jul-12 22:20

Richard MacCutchan

19-Jul-12 22:20

Using hexadecimal rather than decimal integer values makes the code much more readable.

One of these days I'm going to think of a really clever signature.

Re: c++ code

David Crow20-Jul-12 2:29

David Crow

20-Jul-12 2:29

TopCoder23 wrote:
char strchr[32] = "the quick fox";

I would consider a different variable name as strchr is the name of a CRT function.

TopCoder23 wrote:
if((strchr[i] >= 97) && (strchr[i] <= 122))

What about:

if (islower(strchr[i]))
    strchr[i] = toupper(strchr[i]);

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

Re: c++ code

Software_Developer20-Jul-12 3:30

Software_Developer

20-Jul-12 3:30

You're right about strchr() . and islower(). http://www.cplusplus.com/reference/clibrary/cstring/strchr/[^]

Error happen when open file while migrate VC++ 6 to VS2008

Andraw11118-Jul-12 9:16

Andraw111

18-Jul-12 9:16

Hi,dear all,

I have a project created using C++ 6.0. Now I need to update it to VS2008, now I have a problem when I try to open a file.

In C++ 6.0
#include <fstream.h>
ifstream INPFile(INPFileName, ios::nocreate);

In VS2008

#include <fstream>
ifstream INPFile(INPFileName, ios::nocreate);

the second line get the following error:
Error 23 error C2039: 'nocreate' : is not a member of 'std::basic_ios<_Elem,_Traits>'

Error 24 error C2065: 'nocreate' : undeclared identifier

If I change the second line to the following:

ifstream INPFile(INPFileName)

then get new error as following
error 2248: 'std::basic_ios<_Elem,_Traits>::basic_ios' : cannot access private member declared in class 'std::basic_ios<_Elem,_Traits>'

How can I solve this issue?

Thanks!

Re: Error happen when open file while migrate VC++ 6 to VS2008

Albert Holguin18-Jul-12 9:47

Albert Holguin

18-Jul-12 9:47

This talks about the reason for the first error:
http://www.devx.com/tips/Tip/14544[^]

After your change however, the error about the private member doesn't make sense, you probably need to show a bit more of your code.

Re: Error happen when open file while migrate VC++ 6 to VS2008

Andraw11118-Jul-12 10:01

Andraw111

18-Jul-12 10:01

Albert, thanks for your quick reply.

My project has around 50 files, I already search all header files to check if any function pass fstream as argument, and modify them all to be passed as reference instead of as object.

I don't understand why if I use following code:

ifstream fin(OutputF, ios::in,ios::nocreate);

I got error like "C2039: 'nocreate' : is not...", but if I modify it to:
ifstream fin(OutputF, ios::in,ios::_Nocreate);
I got other kind of error messge:
"error C2248: 'std::basic_ios<_Elem,_Traits>::basic_ios' : cannot access private.."

Thanks!

Re: Error happen when open file while migrate VC++ 6 to VS2008

Albert Holguin18-Jul-12 11:35

Albert Holguin

18-Jul-12 11:35

Wait, if you're doing an ifstream (input), why are you specifiying "no create" at all? That doesn't make sense, it's not going to get created if it can't find it. That's only even applicable at all if you're opening in read/write or write modes.

Re: Error happen when open file while migrate VC++ 6 to VS2008

Richard MacCutchan18-Jul-12 21:59

Richard MacCutchan

18-Jul-12 21:59

I do not think the nocreate option exists anymore, and it should not be necessary on an input stream. You need to use the latest definitions as described here[^].

One of these days I'm going to think of a really clever signature.

Re: Error happen when open file while migrate VC++ 6 to VS2008

Andraw11119-Jul-12 3:29

Andraw111

19-Jul-12 3:29

Thanks, Albert and Richard,

Both of you are right, yes, there is no nocreate.

I solve it by remove it, but the main reason I got the " cannot access private member ..." error is that I have some functions that pass ifstream object as value, they should be passed by reference.

Thanks again!

Re: Error happen when open file while migrate VC++ 6 to VS2008

Andraw11119-Jul-12 5:40

Andraw111

19-Jul-12 5:40

Hi,

I solve my issue posted yesterday, but today has another problem related to it.

When I migrate another small project from C++ to VS2008, I double check all the function delcaration to make sure fstream object is passed by reference or pointer, but when I compile program, I still got two error messages, they are same and the only two errors.

C2248: 'std::basic_ios<_Elem,_Traits>::basic_ios' : cannot access private member declared in class 'std::basic_ios<_Elem,_Traits>'

In this case how should I find where the error come from?

Re: Error happen when open file while migrate VC++ 6 to VS2008

Andraw11119-Jul-12 6:17

Andraw111

19-Jul-12 6:17

I found some functions that pass std::istream or std::istrstream by value, not by reference, is that the reason to cause the problem?

Re: Error happen when open file while migrate VC++ 6 to VS2008

Andraw11119-Jul-12 6:25

Andraw111

19-Jul-12 6:25

Yes, they also need to be passed by reference, now can be compile now.

Re: Error happen when open file while migrate VC++ 6 to VS2008

jschell20-Jul-12 7:15

jschell

20-Jul-12 7:15

I would suppose that passing the fstream by value in 6.0 was wrong too. It might have worked but only by luck.

A fstream is a representation of a computer resource. Passing by value implicitly duplicates the representation without duplicating the actual resource. Thus it represents a broken design/implementation.

search for a word in a text file

byank18-Jul-12 2:14

byank

18-Jul-12 2:14

PLease show me how to search for a word in a text file using a listbox, String objects and Indexof, after i opened it in a richtextbox ,in visual C++, please help!!

Re: search for a word in a text file

David Crow18-Jul-12 2:18

David Crow

18-Jul-12 2:18

byank wrote:
PLease show me how to search for a word in a text file using a listbox...

What does a listbox have to do with searching a file?

Are you using MFC or Win32?

Re: search for a word in a text file

byank19-Jul-12 11:00

byank

19-Jul-12 11:00

it's just that i've seen here on codeproject the code for searching words in a text files using vb, i think. I need it in c++. thanks

Re: search for a word in a text file

David Crow20-Jul-12 2:24

David Crow

20-Jul-12 2:24

I understand that, but what does a listbox have to do with anything? It just seems to be "noise" in the overall problem.

Have you tried:

open the file
while not EOF
    read line from file
    if line contains text, exit loop
end
close file

The details deopend on whether you are using MFC, STL, Win32, or some combination thereof.

Re: search for a word in a text file

Shaunak De20-Jul-12 3:17

Shaunak De

20-Jul-12 3:17

If you are searching for a string in a text file do this:

C++

 CString oneLine;     //initialize a CString 
 bool flag = FALSE;   //flag for result
 CStdioFile  fS (_path_, CFile::modeRead ); //open the file
 int lineNumber = 0;   //hold the line number
 while( fS.readLine(oneLine))  //readLine returns false if EOF
  {
    if( oneLine.Find(L"String")!= -1 )  //Find returns -1 if no match
    { flag = TRUE; break; }
   lineNumber++;   //iterate lineNumber
  }
//lineNumber will hold the line in which the string was found. To get exact character place store what Find returns somewhere.