C / C++ / MFC

22-Sep-10 6:50

Hi,

I have created a CListControl, I want to draw grey border color around it so I write the below code to draw border but all string are not visible.
How to do that?

void CListCtrl::OnPaint()
{
	
	CPaintDC dc(this); // device context for painting
	//CListCtrl::OnPaint();
	// TODO: Add your message handler code here
	// Do not call CListCtrl::OnPaint() for painting messages
	CRect rect;
	GetClientRect(rect);
	CPen pen(PS_SOLID,1,RGB(211,211,211));
	CBrush* pOldBrush = (CBrush*)dc.SelectStockObject( NULL_BRUSH );
	dc.SelectObject(&pen);
	//dc.SetROP2(R2_NOT   );

		dc.Rectangle(&rect);
	pOldBrush->DeleteObject();
	pen.DeleteObject();

	}

Maximilien22-Sep-10 8:46

Maximilien

22-Sep-10 8:46

You need to override the OnNcPaint, not the OnPaint.

And don't forget to call "Default();" to draw the interior
for example (done for a listbox derived class, but you should be able to see how it workd...
void MyListBox::OnNcPaint()
{
// draw the inside.
Default();

// draw over the border.
CRect rc;
GetWindowRect(rc);

CDC *pDC = GetParent()->GetDC();
GetParent()->ScreenToClient( rc );
// do the drawing ...
pDC->FrameRect( rc , brush );
rc.DeflateRect( 1, 1, 1, 1 );
pDC->FrameRect( rc,brush );

}

Watched code never compiles.

john563222-Sep-10 22:42

22-Sep-10 22:42

Thanks for you reply.

I replied (code below) but getting any border around the window

void CTxListCtrl::OnNcPaint()
{
	// TODO: Add your message handler code here
	// Do not call CListCtrl::OnNcPaint() for painting messages
	// draw the inside.
	Default();

	// draw over the border.
	CRect rc;
	GetWindowRect(rc);

	CDC *pDC = GetParent()->GetDC();
	GetParent()->ScreenToClient( rc );
	CBrush  brush(RGB(255,0,0)); 

	CPen pen(PS_SOLID,1,RGB(211,211,211));
	pDC->SelectObject(&pen);
	pDC->Rectangle(&rc);

	pDC->FrameRect( rc , &brush );
	rc.DeflateRect( 1, 1, 1, 1 );
	pDC->FrameRect( rc,&brush );
}

Rolf Kristensen23-Sep-10 0:49

Rolf Kristensen

23-Sep-10 0:49

Why not set a style that creates a client edge around your CListCtrl:

BEGIN_MESSAGE_MAP(CMyListCtrl, CListCtrl)
	//{{AFX_MSG_MAP(CMyListCtrl)
	ON_WM_CREATE()
	//}}AFX_MSG_MAP
END_MESSAGE_MAP()

void CMyListCtrl::OnCreateStyles()
{
	// Will be called twice when placed inside a CView / CFormView

	// Set slim border
	ModifyStyle(WS_BORDER, 0);
	ModifyStyleEx(WS_EX_STATICEDGE, WS_EX_CLIENTEDGE);
}

void CMyListCtrl::PreSubclassWindow()
{
	CListCtrl::PreSubclassWindow();

	OnCreateStyles();
}

int CMyListCtrl::OnCreate(LPCREATESTRUCT lpCreateStruct) 
{
	if (CListCtrl::OnCreate(lpCreateStruct) == -1)
		return -1;

	OnCreateStyles();
	return 0;
}

john563223-Sep-10 4:17

Reason for UAC prompt , porting for Win7

23-Sep-10 4:17

This is adding HSCROLL and VSCROLL also. I dont need scroll bar.
Plz give a light on this issue.

Moak22-Sep-10 6:14

22-Sep-10 6:14

Hi, I wrote two C++ Windows applications which I previously used on WinXP.

The main MFC application gets no UAC prompt when I start it, works fine on Win7.
The Win32 application, which is just a WinMain() with some functionality, gets an UAC prompt as soon as I double click it. Can I find out why?

Thanks, let me know if I should provide more details!

Chat in Europe Java | [Coffee]

Eugen Podsypalnikov22-Sep-10 6:33

Eugen Podsypalnikov

22-Sep-10 6:33

What does the check box "Run as administrator" show
(in the "Compatibility" property page of the result exe), please ? Smile | :)

Here is an example of "any-user" manifest,
that could be bind to an exe:

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0"> 
  <trustInfo xmlns="urn:schemas-microsoft-com:asm.v3">
    <security>
      <requestedPrivileges>
        <requestedExecutionLevel
          level="asInvoker"
          uiAccess="false"
        />
      </requestedPrivileges>
    </security>
  </trustInfo>
  <dependency> 
    <dependentAssembly> 
      <assemblyIdentity 
        type="win32" 
        name="Microsoft.Windows.Common-Controls" 
        version="6.0.0.0" 
        processorArchitecture="X86" 
        publicKeyToken="6595b64144ccf1df" 
        language="*" 
      /> 
    </dependentAssembly> 
  </dependency> 
</assembly>

virtual void BeHappy() = 0;

Moak22-Sep-10 6:38

22-Sep-10 6:38

"Run as administrator" is not enabled.

Can you give me some background on the manifest? Does every executable need one under Win7 in order to avoid UAC prompt... or is it some API call inside my exe which causes the UAC prompt?

Chat in Europe Java | [Coffee]

Eugen Podsypalnikov22-Sep-10 6:57

Eugen Podsypalnikov

22-Sep-10 6:57

// or is it some API call inside my exe which causes the UAC prompt?

May be...
...when it (test) will not help :
- save the XML-dump as c:\yours.manifest
- set the exe-VS\ProjektProperty\Manifest Tool\Input and Output\Additional Manifest Files to c:\yours.manifest
- rebuild

An "admin" API call would just fail, I think,
by filled LastError (about some rights) in the "non-admin" modus... Smile | :)

virtual void BeHappy() = 0;

Moak23-Sep-10 5:49

23-Sep-10 5:49

Thanks for the info! However, the manifest with trustinfo was not enough, also needed Win7 compability for UAC to work as wanted (they changed the rules for Win7). Didn't expect me to say that... but this mess wouldn't have happened with Bill Gates still being at Microsoft. Smile | :)

Chat in Europe Java | [Coffee]

krmed22-Sep-10 7:05

krmed

22-Sep-10 7:05

It could simply be the name of your exe file also. Vista (and Windows 7) UAC also uses heuristics to determine if an application needs admin privilege.

See this article[^] on MSDN (especially the "Installer Detection" part). Even strings in the string table of your application can trigger UAC.

Hope that helps.

Karl - WK5M
PP-ASEL-IA (N43CS)
PGP Key: 0xDB02E193
PGP Key Fingerprint: 8F06 5A2E 2735 892B 821C 871A 0411 94EA DB02 E193

Moak22-Sep-10 12:58

22-Sep-10 12:58

krmed wrote:
UAC also uses heuristics to determine if an application needs admin privilege.

Yes that's it! The file is a software_updater.exe, the text "update" in file name or version info triggers the "installer detection". Now have to find a way around that, I am curious if I can do the following: 1) keep file name without UAC prompt, 2) elevate privileges on runtime when actually needed. Most time my software updater justs needs to run with normal user rights, only when the main application is updated it would need more privileges.

Btw, if someone is interested, I would have never mentioned the problem if my MSI installer wouldn't have failed. You can't run (non-deferred) custom actions which will then trigger a UAC prompt, they fail silently.

Thanks for the info! Smile | :)

Chat in Europe Java | [Coffee]

Create a new menu in the MDI appliaction [modified]

VulcanYang22-Sep-10 0:14

VulcanYang

22-Sep-10 0:14

I have created a new menu in my MDI application,and the menu can be displayed.
However,the window menu can not be properly displayer.
there is no any window name in the popup menu of window menu.
the window menu is on the left of the help menu.

I know the OnCreateClient will get the menu handle,but I dont know why it cannot display properly.
thanks in advance for any kind of help.

Bill

modified on Thursday, September 23, 2010 3:38 AM

Re: Create a new menu in the MDI appliaction

Sauro Viti22-Sep-10 0:19

Sauro Viti

22-Sep-10 0:19

Do not cross-post the same question to multiple forums (you have posted this question to the QA too). The best is to post a question only once in the more appropriated forum.

Re: Create a new menu in the MDI appliaction

tayyebe5-Oct-10 1:31

tayyebe

5-Oct-10 1:31

you should modify IDR_application menu in resource view.

Re: Create a new menu in the MDI appliaction

VulcanYang5-Oct-10 3:02

VulcanYang

5-Oct-10 3:02

First of all,thanks for your help.
I have resolved this problem.
The reason of this problem is that the function GetWindowMenuPopup is not properly implemented.
The MFC frame make use of this function to add window name to the window menu which is on the left of the help menu.
The default GetWindowMenuPopup function look up window menu handle only by the resource ID.If the resource ID of the menu is between AFX_IDM_WINDOW_FIRST and AFX_IDM_WINDOW_LAST,the frame consider it as a window menu.
So when I create a new menu,it's ID is not between the range and the frame doesnot add window name to the window menu.
Now I have overrided the GetWindowMenuPopup in my derived class,it is as below:
HMENU CHotelFrameWnd::GetWindowMenuPopup(HMENU hMenuBar)
{
if (hMenuBar == NULL)
return NULL;

ASSERT(::IsMenu(hMenuBar));

int iItem = ::GetMenuItemCount(hMenuBar);
while (iItem--)
{
HMENU hMenuPop = ::GetSubMenu(hMenuBar, iItem);
if(hMenuPop != NULL)
{
MENUITEMINFO mii;
TCHAR szBuf[256];

mii.cbSize = sizeof(mii);
mii.fMask = MIIM_STRING;
mii.fType = MFT_STRING;
mii.dwTypeData = szBuf;
mii.cch = sizeof(szBuf);
mii.fState = MFS_ENABLED;
::GetMenuItemInfo(hMenuBar,iItem,TRUE,&mii);
if(strcmp(szBuf,_T("窗口(&W)")) == 0)
{
return hMenuPop;
}
}

}

// no default menu found
TRACE(traceAppMsg, 0, "Warning: GetWindowMenuPopup failed!\n");
return NULL;
}

WeatherYoung

Time Format

john563222-Sep-10 0:14

22-Sep-10 0:14

Hi,

I am getting getting time through CTime::GetCurrentTime() but I am getting time in 24 hours format.

How can I change it in 12 hours format?

Shivanand Gupta22-Sep-10 0:36

Shivanand Gupta

22-Sep-10 0:36

AFTER getting currenttime
you can use Format method for changing time format as you want

Richard MacCutchan22-Sep-10 1:44

Richard MacCutchan

22-Sep-10 1:44

The documentation[^] is always the first place to look.

It's time for a new signature.

Member 392263922-Sep-10 2:08

Member 3922639

22-Sep-10 2:08

CTime::GetCurrentTime() returns a CTime object, not a string, so it has not a format.
To get the formatted string, have you used the CTime::Format function?
Use it with %I instead of %H.

P.S.: you cannot read the documentation on MSDN?

john563222-Sep-10 3:34

22-Sep-10 3:34

I am using like

szTimeDisplay.Format(L"%02d:%02d:%0d",tm.GetHour(),tm.GetMinute(),tm.GetSecond());

I also tried as you told but not worked?

Aescleal22-Sep-10 3:38

Aescleal

22-Sep-10 3:38

CTime::Format only takes one parameter, and that's a format string. The format is based on strftime rather than the printf style you're expecting. MSDN has an example[^] at the bottom of the page that might give you a leg up in the right direction.

Cheers,

Ash