Click here to Skip to main content
15,896,339 members
Home / Discussions / C / C++ / MFC
   

C / C++ / MFC

 
AnswerRe: Experiencing trouble with passing input string to array Pin
Luc Pattyn20-May-10 16:00
sitebuilderLuc Pattyn20-May-10 16:00 
GeneralRe: Experiencing trouble with passing input string to array Pin
computerpublic20-May-10 16:06
computerpublic20-May-10 16:06 
GeneralRe: Experiencing trouble with passing input string to array Pin
Luc Pattyn20-May-10 16:39
sitebuilderLuc Pattyn20-May-10 16:39 
GeneralRe: Experiencing trouble with passing input string to array Pin
computerpublic20-May-10 16:55
computerpublic20-May-10 16:55 
GeneralRe: Experiencing trouble with passing input string to array Pin
Aescleal20-May-10 22:21
Aescleal20-May-10 22:21 
AnswerRe: Experiencing trouble with passing input string to array Pin
Aescleal20-May-10 20:06
Aescleal20-May-10 20:06 
AnswerRe: it works perfectly now [modified] Pin
Software_Developer20-May-10 20:08
Software_Developer20-May-10 20:08 
GeneralRe: it works perfectly now Pin
Aescleal20-May-10 22:17
Aescleal20-May-10 22:17 
It is perfect, for some strange version of perfection that I'm not sure that most experienced C++ programmers would recognise.

Faux pas the first: #pragma warning( disable : 4101 ). Why are you disabling this warning? What defects does it hide in your code?

Faux pas the second: Using arrays when, in this example you just need std::string

Faux pas the third: Redundancy - reading stuff into a character array then assigning to a string when you could just read straight into the string

Faux pas the fourth: Closing the file, why not just rewind it to the beginning. Or stick getting the filesize in it's own function.

Faux pas the fifth: What are Adder and count for? Where I come from an Adder is a snake and the count is on Sesame Street. They're initialised, incremented and assigned and, er, pointless.

Faux pas the sixth: What's the point of an array of empty string, one per character in the input file?

Faux pas the seventh: Declaring variables miles away from using them

Faux pas the eighth: You can't see this one as you disabled the warning, bummer!
GeneralRe: You must be the Quality assurance team Pin
Software_Developer20-May-10 23:31
Software_Developer20-May-10 23:31 
QuestionHow to set breakpoint to step through CTabCtrl draw ... [modified] Pin
theFrenchHornet20-May-10 11:45
theFrenchHornet20-May-10 11:45 
Questionc++ combo list box Pin
mrby12320-May-10 5:55
mrby12320-May-10 5:55 
QuestionRe: c++ combo list box Pin
David Crow20-May-10 6:13
David Crow20-May-10 6:13 
AnswerRe: c++ combo list box Pin
mrby12320-May-10 6:25
mrby12320-May-10 6:25 
AnswerRe: c++ combo list box Pin
David Crow20-May-10 6:55
David Crow20-May-10 6:55 
GeneralRe: c++ combo list box Pin
mrby12320-May-10 9:58
mrby12320-May-10 9:58 
AnswerRe: c++ combo list box Pin
David Crow20-May-10 10:22
David Crow20-May-10 10:22 
GeneralRe: c++ combo list box Pin
mrby12320-May-10 12:23
mrby12320-May-10 12:23 
AnswerRe: c++ combo list box Pin
David Crow20-May-10 16:25
David Crow20-May-10 16:25 
GeneralRe: c++ combo list box [modified] Pin
mrby12320-May-10 18:54
mrby12320-May-10 18:54 
GeneralRe: c++ combo list box Pin
David Crow21-May-10 3:17
David Crow21-May-10 3:17 
QuestionCFile::Remove fails [Resolved] Pin
Mike Osbahr20-May-10 5:31
Mike Osbahr20-May-10 5:31 
AnswerRe: CFile::Remove fails Pin
jeron120-May-10 5:42
jeron120-May-10 5:42 
GeneralRe: CFile::Remove fails Pin
Mike Osbahr20-May-10 6:42
Mike Osbahr20-May-10 6:42 
GeneralRe: CFile::Remove fails Pin
jeron120-May-10 6:48
jeron120-May-10 6:48 
GeneralRe: CFile::Remove fails Pin
Mike Osbahr20-May-10 7:12
Mike Osbahr20-May-10 7:12 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.