Re: How to stop a thread from a primary thread - C / C++ / MFC Discussion Boards

Re: copying string from CString to BYTE*. How ?

Hamid_RT5-Dec-06 18:29

Hamid_RT

5-Dec-06 18:29

What happen if you run this code

<br />
CString m_Str = "123456abcdef";<br />
    BYTE *m_Byte = (unsigned char*)m_Str.GetBuffer(0);<br />

WhiteSky

Re: copying string from CString to BYTE*. How ?

kanduripavan5-Dec-06 18:30

kanduripavan

5-Dec-06 18:30

try this
CString strData="Hello World";
TCHAR szData[15];
lstrcpy(szData, strData.GetBuffer(strData.GetLength()) );

Manu

Re: copying string from CString to BYTE*. How ?

ThatsAlok5-Dec-06 22:06

ThatsAlok

5-Dec-06 22:06

kanduripavan wrote:
TCHAR szData[15];
lstrcpy(szData, strData.GetBuffer(strData.GetLength()) );

what about, if szData contain two NULL character!.. lstrcpy not going to work!

<div class='ForumSig'>"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow
cheers, Alok Gupta VC Forum Q&A :- I/ IV Support CRY- Child Relief and you </div>

Re: copying string from CString to BYTE*. How ?

Mark Salsbery5-Dec-06 20:56

Mark Salsbery

5-Dec-06 20:56

Another way haha

// Copy contents of CString str to BYTE buffer pByteBuffer
// (No NULL terminator is copied!)
memcpy(pByteBuffer, str.GetString(), str.GetLength() * sizeof(TCHAR);

Re: copying string from CString to BYTE*. How ?

Mark Salsbery5-Dec-06 21:01

Mark Salsbery

5-Dec-06 21:01

Sakthiu wrote:
_tcscpy((TCHAR*)&Datas[FilledData],TempStr.GetBuffer());

Datas is BYTE* and TempStr is CString.

here I am getting only the first character of TempStr in Datas. But i need full String. How ?

Are you sure you are only getting first char? If it's unicode then every 2 bytes is a char and
possibly every other byte is a 0.

How to stop a thread from a primary thread

cy163@hotmail.com5-Dec-06 17:51

cy163@hotmail.com

5-Dec-06 17:51

How to stop a thread from a primary thread

In My project, a SDI CFormView application, I start a worker thread to accompolish a lengthy task by clicking a botton 'btnStart' on the form. I want stop the running work in the thread by clicking another button 'btnStop'. I cannot figure out why the following scheme cannot stop the thread.

handler for 'btnStop'

<br />
	m_CEvent_StopThread.SetEvent();<br />
         WaitForSingleObject(pMyTheadProc->m_hThread, INFINITE);<br />
	delete pMyTheadProc;<br />
<br />

in the thread, an instance of class MyClass is running. The thread is started by the following lines (handler for btnStart)

<br />
	MyClass * objMyClass = new MyClass(this);	<br />
	<br />
	UpdateData(true);<br />
<br />
	objMyClass->m_EditBox10Weight1Itemset = m_EditBox10Weight1Itemset;<br />
	objMyClass->m_EditBox11Weight2Itemset = m_EditBox11Weight2Itemset;<br />
	objMyClass->m_EditBox12Weight3Itemset = m_EditBox12Weight3Itemset;<br />
	objMyClass->m_EditBox13SimiThreshold = m_EditBox13SimiThreshold;<br />
	objMyClass->m_EditBox14HRmin = m_EditBox14HRmin;<br />
	objMyClass->m_EditBox15Excel = m_EditBox15Excel;<br />
<br />
	objMyClass->m_Radio = m_Radio;<br />
	objMyClass->m_Radio3 = m_Radio3;<br />
	<br />
	objMyClass->m_CheckVerb = m_CheckVerb;<br />
	objMyClass->m_CheckNoun = m_CheckNoun;<br />
	objMyClass->m_CheckAbbr = m_CheckAbbr;<br />
	objMyClass->m_CheckIdiom = m_CheckIdiom;<br />
	objMyClass->m_CheckVg = m_CheckVg;<br />
	objMyClass->m_CheckNg = m_CheckNg;<br />
<br />
	objMyClass->m_EditBox6 = m_EditBox6;<br />
	<br />
	objMyClass->m_DebugMode = m_DebugMode;<br />
<br />
	test_globalvariable = FALSE;<br />
	pMyTheadProc = AfxBeginThread(MyThreadProc, objMyClass);<br />
	pMyTheadProc->m_bAutoDelete=FALSE;<br />
<br />

The worker thread is coded as follows

<br />
UINT MyThreadProc(LPVOID pParam)<br />
{<br />
	MyClass* pObject = (MyClass*)pParam;<br />
    if (pObject == NULL) <br />
	{<br />
		return -1;    <br />
	}<br />
	else<br />
	{<br />
		<br />
		<br />
		pObject->SubFunc();<br />
		<br />
		return 0;   <br />
	}<br />
	<br />
}<br />
<br />
<br />

In the SubFunc(), the following code is used to response the stop-thread signal generated when clicking on btnStop.

<br />
		if(WAIT_OBJECT_0==::WaitForSingleObject(m_TerminateThread.m_hObject,0))<br />
		{<br />
			AfxMessageBox("Exit Thread\n");<br />
			::AfxEndThread( 0, FALSE ); <br />
<br />
		}<br />
<br />
<br />

In addition, I wonder if the dynamically allocated mem in the thread can be automatically deallocated in the above scheme. Or I have to use additional code to release the allocated mem myself.

Re: How to stop a thread from a primary thread

Hamid_RT5-Dec-06 18:06

Hamid_RT

5-Dec-06 18:06

If you want to stop a thread you can use of TerminateThread

WhiteSky

Re: How to stop a thread from a primary thread

Stephen Hewitt5-Dec-06 20:14

Stephen Hewitt

5-Dec-06 20:14

That is very bad advice. See here[^] for one explaination or note the following from MSDN:

TerminateThread is a dangerous function that should only be used in the most extreme cases.
You should call TerminateThread only if you know exactly what the target thread is doing, and you
control all of the code that the target thread could possibly be running at the time of the
termination. For example, TerminateThread can result in the following problems:
If the target thread owns a critical section, the critical section will not be released.
If the target thread is allocating memory from the heap, the heap lock will not be released.
If the target thread is executing certain kernel32 calls when it is terminated, the kernel32 state
 for the thread's process could be inconsistent.
If the target thread is manipulating the global state of a shared DLL, the state of the DLL could
 be destroyed, affecting other users of the DLL.

In short don't use this API; it is not intended for general use and using it as if it is is one of the most frequent mistakes Windows programmers make.

Steve

Re: How to stop a thread from a primary thread

cy163@hotmail.com5-Dec-06 23:52

cy163@hotmail.com

5-Dec-06 23:52

Thank you Steve for your warning.

Re: How to stop a thread from a primary thread

Stephen Hewitt5-Dec-06 20:18

Stephen Hewitt

5-Dec-06 20:18

Do not use TerminateThread. See here[^] for details.

Steve

Re: How to stop a thread from a primary thread

Roger Stoltz5-Dec-06 20:34

Roger Stoltz

5-Dec-06 20:34

See here[^] how it should be done.
The article also gives a lot of good advice and know-how regarding multithreading.

--
Roger

"It's supposed to be hard, otherwise anybody could do it!" - selfquote

"No one remembers a coward!" - Jan Elfström 1998
"...but everyone remembers an idiot!" - my lawyer 2005 when heard of Jan's saying above

shell programming

sanwalz5-Dec-06 17:46

sanwalz

5-Dec-06 17:46

how shell can be used to launch new programs

Re: shell programming

Joe Woodbury5-Dec-06 17:51

Joe Woodbury

5-Dec-06 17:51

Look up:

ShellExecute
ShellExecuteEx

(Oh, and learn how to use MSDN. It's quite helpful when looking for the obvious.)

Anyone who thinks he has a better idea of what's good for people than people do is a swine.
- P.J. O'Rourke

How to LPCTSTR Convert to char *

rxgmoral5-Dec-06 15:23

rxgmoral

5-Dec-06 15:23

How to LPCTSTR Convert to char *

thank Smile | :)

Blog:
http://360.yahoo.com/rxgmoral

Re: How to LPCTSTR Convert to char *

David Crow5-Dec-06 16:29

David Crow

5-Dec-06 16:29

What have you tried?

"Approved Workmen Are Not Ashamed" - 2 Timothy 2:15

"Judge not by the eye but by the heart." - Native American Proverb

Re: How to LPCTSTR Convert to char *

ThatsAlok5-Dec-06 22:07

ThatsAlok

5-Dec-06 22:07

DavidCrow wrote:

What have you tried?

nothing Smile | :)

<div class='ForumSig'>"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow
cheers, Alok Gupta VC Forum Q&A :- I/ IV Support CRY- Child Relief and you </div>

Re: How to LPCTSTR Convert to char *

Stephen Hewitt5-Dec-06 17:06

Stephen Hewitt

5-Dec-06 17:06

Firstly, it may already be one: if you app is UNICODE it will not be else it will. There are many ways to make the conversion, depending on which libraries and such you're using. Here's some:
- WideCharToMultiByte (Win32 API).
- USES_CONVERSION and T2A macros (ATL).

Steve

Re: How to LPCTSTR Convert to char *

rxgmoral5-Dec-06 17:55

rxgmoral

5-Dec-06 17:55

thank you

Blog:
http://360.yahoo.com/rxgmoral

Re: How to LPCTSTR Convert to char *

Hamid_RT5-Dec-06 17:50

Hamid_RT

5-Dec-06 17:50

And see here[^] if its your purpose

WhiteSky

OnCancel problem

celllllllll5-Dec-06 13:45

celllllllll

5-Dec-06 13:45

Hi All,

I am having a problem with OnCancel()...Basically, if I click on Cancel on any interface, it vanishes (closes) the window but what my problem is that I get errors when I click CANCEL on my interface. Am I missing something?

Thanks in advance
Preeti

C++Prog

Re: OnCancel problem

Leah_Garrett5-Dec-06 14:01

Leah_Garrett

5-Dec-06 14:01

What kind of errors are you getting? Do they appear before the interface closes?

Re: OnCancel problem

celllllllll5-Dec-06 14:10

celllllllll

5-Dec-06 14:10

No..they appear after I click "Cancel" button on the dialog box.

C++Prog

Re: OnCancel problem

Leah_Garrett5-Dec-06 14:13

Leah_Garrett

5-Dec-06 14:13

What are the error messages?

It could be from some clean-up code or many other things. It would be easier to offer ideas if you provide the errors messages themselves.

Re: OnCancel problem

celllllllll5-Dec-06 14:19

celllllllll

5-Dec-06 14:19

Thanks for the help...Actually, the error messages are related to my project.

Thanks

C++Prog

Re: OnCancel problem

David Crow5-Dec-06 16:32

David Crow

5-Dec-06 16:32

Preeti9 wrote:
...I get errors...

We're not mind readers. What are they?

"Approved Workmen Are Not Ashamed" - 2 Timothy 2:15

"Judge not by the eye but by the heart." - Native American Proverb

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.