C / C++ / MFC

27-Jan-09 21:32

Hi all,

I have 6 int values and a char buffer to pass another method. Something like this.

<br />
int MyClassOne::Method()<br />
{<br />
    NemMwthod(1, 2, 3, 4, 5, 6, buffer);<br />
}<br />
<br />
int MyClassTwo::NewMethod(int a, int b, int c, int d, int e, int f, char buffer)<br />
{<br />
    // Do the process<br />
}<br />

Seems it's odd to me. So I do the following.

int MyClassOne::Method()<br />
{<br />
    int* arr = new int[6];<br />
    arr[0] = 1;<br />
    arr[1] = 2;<br />
    arr[2] = 3;<br />
    arr[3] = 4;<br />
    arr[4] = 5<br />
    arr[5] = 6;<br />
    <br />
    NemMwthod(arr, buffer);<br />
    delete[] arr;<br />
}<br />
<br />
int MyClassTwo::NewMethod(int ar[], char buffer)<br />
{<br />
    // Do the process<br />
}

I want to know what's best way to workaround is.

Thanks a lot

I appreciate your help all the time...
CodingLover Smile | :)

epitalon27-Jan-09 21:47

epitalon

27-Jan-09 21:47

In my opinion, both methods are good.
I would prefer the first one, because it involves less copy operations.
As long as there is a fixed low number of integers to pass to the called procedure, the fist one is the best.
If the number of integers is variable, the second one is better.

An intermediate method would be:

int arr[6];
arr[0] = 1;
arr[1] = 2;
arr[2] = 3;
arr[3] = 4;
arr[4] = 5
arr[5] = 6;

NemMwthod(arr, buffer);

Rahul Vaishnav27-Jan-09 21:49

Rahul Vaishnav

27-Jan-09 21:49

You can use
vector or CSimpleArray and pass that as a function parameter.

CPallini27-Jan-09 21:50

27-Jan-09 21:50

They are both legitimate, anyway IMHO the first one is more reliable, since the second one may crash your application if the caller passes an array having the wrong number of items (i.e. array size < 6).
Note that you may force the correct behaviour this way:

struct MyMethodArg
{
 int arr[6];
 char * buffer; // Usual a character buffer 
};

int MyClass::MyMethod(MyMethodArg arg)
{

}

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.

This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke

[My articles]

CodingLover27-Jan-09 22:23

27-Jan-09 22:23

Thanks for all the comments, make sense.

But actually that method is call large number of times, say 50 times in one second. The way I workout is fine? I'm testing it, so far so good. Smile | :)

I appreciate your help all the time...
CodingLover Smile | :)

CPallini27-Jan-09 22:27

27-Jan-09 22:27

Which way?
If you use the array then you may choose to allocate it on the stack, instead of the heap, for instance

int a[]={1,2,3,4,5,6};
MyMethod(a,buf);

CodingLover27-Jan-09 22:31

27-Jan-09 22:31

Ya, but I've clear the head once pass the array.

I appreciate your help all the time...
CodingLover Smile | :)

CPallini27-Jan-09 22:39

27-Jan-09 22:39

CodingLover wrote:
Ya, but I've clear the head once pass the array.

CodingLover27-Jan-09 22:47

27-Jan-09 22:47

Sorry sir, it should be heap.

I appreciate your help all the time...
CodingLover Smile | :)

«_Superman_»27-Jan-09 22:25

«_Superman_»

27-Jan-09 22:25

CodingLover wrote:
I want to know what's best way

Both are fine. Normally what I do is that if a function needs more than 5 parameters, I define a structure for it. It is just a standard that I follow. So its all up to you.

All parameters are passed on the stack and in Visual Studio the default stack space for a thread is 1 MB. So passing a structure will only use one location of the stack rather than 100 locations if you want to pass 100 parameters.

«_Superman_»

CodingLover27-Jan-09 22:31

27-Jan-09 22:31

Actually those methods are in two different classes. Sorry about that, I'm asking it because I've no more knowledge about structures. Is that structures is possible here.

I appreciate your help all the time...
CodingLover Smile | :)

«_Superman_»27-Jan-09 22:42

«_Superman_»

27-Jan-09 22:42

You can define the structure in a header file and include the header file in both the class files.

«_Superman_»

C Change28-Jan-09 0:44

C Change

28-Jan-09 0:44

A structure is what I would always do too. If there's a natural grouping to these items then having a struct defined for them is good practice anyway, including code readability. You just pass the struct, or a pointer to it, as suits. Nice and clean.

hexadecimal

aswd27-Jan-09 20:56

27-Jan-09 20:56

how to setting an edit box to prompt the user to enter hexadecimal numbeR?..

Smile | :)

Hamid_RT27-Jan-09 21:15

Hamid_RT

27-Jan-09 21:15

You can derived your class of Editbox and then overwrite WM_CHAR only for digital number for 0..9 and A..F.

Of one Essence is the human race
thus has Creation put the base
One Limb impacted is sufficient
For all Others to feel the Mace
(Saadi )

CPallini27-Jan-09 21:18

27-Jan-09 21:18

AFAIK, you have to write your own code to validate the entered number.
Luckily there are functions like strtol [^] (or _tcstol, if toxcct is nearby Roll eyes | :rolleyes:

) that may greatly help you.
Smile | :)

aswd27-Jan-09 21:20

27-Jan-09 21:20

ouh..oke!!
let me try 1st..
thanks master!!..

Smile | :)

Cedric Moonen27-Jan-09 21:28

Cedric Moonen

27-Jan-09 21:28

As an alternative to what the other replies suggested you, you can still first search if somebody didn't already that for you. Check here[^] if you can find something that suits you.
It would amaze me if something like that is not available on CP...
But if it's not the case, that would be an idea for an article Poke tongue | ;-P

Cédric Moonen
Software developer

Charting control [v1.5]
OpenGL game tutorial in C++

Visual C++

aswd27-Jan-09 20:47

27-Jan-09 20:47

NEED HELP!!

hii all..
anyone here knows how to convert the requested memory address to bus address???...
plss..im urgent!!

this is my email : hafizul_10422@yahoo.com

thanks all..
hv a great day!!

Smile | :)

CPallini27-Jan-09 21:11

27-Jan-09 21:11

aswd wrote:
anyone here knows how to convert the requested memory address to bus address???...
plss..im urgent!!

Nope. Anyway I may help you converting a memory address to a bus number, for instance the address 0x0E translates to tram no.14, that travels from my home to Rome central railway station.
Big Grin | :-D

aswd27-Jan-09 21:15

27-Jan-09 21:15

thanks alot.. Frown | :(

CPallini27-Jan-09 21:23

27-Jan-09 21:23

I may give you two suggestions:

Read carefully the forum guidelines before posting.
Go to (1) if you have any doubt.

For instance you should be more precise with your questions: What is the 'bus address' your talking about?
Smile | :)

aswd27-Jan-09 21:31