C# Discussion Boards - CodeProject

Kevin Marois2-Nov-20 6:31

2-Nov-20 6:31

I'm using a typical 'n-tier' design. In most cases the BL just passes through called to and from the UI and DAL. But I do have some business rules that I'd like to check in the BL. I want to put the code there, versus in the UI because I have a WPF app and a Mobile app both calling the Web API.

So, the question is, how would you handle a rule violation in the BL? Would you throw an exception? Or return a string or other value?

Thanks

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Re: Business Layer Question

Richard Deeming2-Nov-20 6:45

Richard Deeming

2-Nov-20 6:45

Return an error status code (4xx) along with a meaningful response describing the error, which your calling application can use to display the appropriate error to the user.

There's even a standard for the error response: RFC 7807 - Problem Details for HTTP APIs[^]

RFC7807 is built-in to .NET Core from 2.1 onwards: ProblemDetails Class (Microsoft.AspNetCore.Mvc) | Microsoft Docs[^]

Problem Details: A standard way of specifying errors in HTTP API responses | Luru[^]

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Re: Business Layer Question

Kevin Marois2-Nov-20 7:27

Kevin Marois

2-Nov-20 7:27

Richard Deeming wrote:
Return an error status code

Thanks. I was leaning in that direction but wanted to get opinions.

I also posted a question in Arch & Design. I would welcome your thouhts on that.

K

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

use connection from login form in other forms

Newkid on the block31-Oct-20 5:43

Newkid on the block

31-Oct-20 5:43

HI im new to C#

im creating an test app to connect to a local Database, i have created a form which connects to my DB and server, once connected this opens a new form. So far so good. what i need to know now is how do i use the connection in the new form?

thanks

Re: use connection from login form in other forms

OriginalGriff31-Oct-20 5:57

OriginalGriff

31-Oct-20 5:57

Exactly how depends on the "relationship" between the two forms.
Have a look at these, one of them will fit your circumstances.
The form that creates an instance of another:

MyForm mf = new MyForm();
mf.Show();

Is the "parent", the other form is the "child".
(This doesn't imply any formal MDI relationship)

Transferring information between two forms, Part 1: Parent to Child[^]
Transferring information between two forms, Part 2: Child to Parent[^]
Transferring information between two forms, Part 3: Child to Child[^]

But ... you shouldn't create a SqlConnection and "pass it around" your app - that's a bad idea as some operations such as a DataReader that fails to be closed and disposed properly can "block" the connection object from doing anything else. Instead, create a connection string and pass that around (or create it as a public static property and just use it everywhere). Then create your Connection within a using block each time you need one.

"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!

Re: use connection from login form in other forms

Newkid on the block31-Oct-20 10:21

Newkid on the block

31-Oct-20 10:21

Thanks for your reply i will take look at the parent child

this is my first app, advancing from hello world Smile | :)

. passing the connection string between forms is what i am trying to do. I am a complete Novice.

thanks

Re: use connection from login form in other forms

Dave Kreskowiak31-Oct-20 11:26

Dave Kreskowiak

31-Oct-20 11:26

You don't have to "pass" anything. The connection string can be made available to any methods that want it by exposing it as a getter-only property in a static class.

Seriously, if you're moving up from Hello World to this, you may have taken your steps a bit too long.

Asking questions is a skill
CodeProject Forum Guidelines
Google: C# How to debug code
Seriously, go read these articles.

Dave Kreskowiak

Re: use connection from login form in other forms

Dave Kreskowiak31-Oct-20 6:30

Dave Kreskowiak

31-Oct-20 6:30

If you're creating a connection to the database in your login form to share amongst all other forms, DON'T.

All database operations should be Create Connection as late as possible, do your work, and close connection as early as possible.

DO NOT HOLD A DATABASE CONNECTION OPEN FOR THE LIFE OF YOUR APP.

Also, is a login form really the correct place to open a database connection used by the entire app? Does it have anything to do with the operation of authenticating users in your app?

No, it does not. That is a violation of "separation of concerns". The authentication form should be limited to just that, getting the user credentials and authenticating them. That's it. Nothing else.

The database work should be handled different classes specific to their tasks.

Asking questions is a skill
CodeProject Forum Guidelines
Google: C# How to debug code
Seriously, go read these articles.

Dave Kreskowiak

Re: use connection from login form in other forms

BillWoodruff1-Nov-20 15:12

BillWoodruff

1-Nov-20 15:12

I Parent, Owner

let me clear something up here:

1) when you declare and instantiate a Form within another Form: they do not have a Parent-Child relationship. It is simply the case at run-time that the instance of the Form that creates the second Form has a valid reference to the instance of the second Form.

2) imho, it's regrettable that it's legal to set a Form to be the Parent of another Form: that leads to a form-within-a-form which is a code smell: you can use the light-weight ContainerControls, like Panel, instead.

3) you can set a Form to be the Owner of another Form ... imho, that is a kind of Parent-Child relationship ... but, all it does is make sure the owned Form appears in front of the owning Form at run-time.
.
II Security in getting and passing data from one Form to another

0) the goal here is to implement security by encapsulation/separation of concerns: all objects/delegates created in the main form Load event do not persist outside that method. the log in form has no "world knowledge" of the main form. there is only one point of access to the log in form in the main form: being able to set the Action delegate 'SendResult in the log in form.

just for the sake of over-kill, we inject the executable code using the lambda format. for a good summary of using Action and Func rather than delegates: [^]

1) code example in a Main Form named Form1's Load EventHandler:

private void Form1_Load(object sender, EventArgs e)
{
    LogInForm loginfrm = new LogInForm();

// declaring and instantiating the login form here means
// it "disappears" ... goes out of scope ... when this method is finished

    string username, password;

    loginfrm.SendResult = (uname, pword) =>
    {
        username = uname;
        password = pword;
    };

// this injects executable code (as a Delegate) into the new log in form

    DialogResult loginResult = loginfrm.ShowDialog();

    if (loginResult == DialogResult.OK)
    {
        // login success
        // user input now  in variables username, password;

        // now validate, make your connection string, etc.

    }
    else if (loginResult == DialogResult.Cancel)
    {
        // user canceled
    }
    else if (loginResult == DialogResult.Abort)
    {
        // login abort: SendResult not defined in login form
    }
}

2) code in the LogInForm

using System;
using System.Windows.Forms;

namespace YourNameSpace
{
    public partial class LogInForm : Form
    {
        public LogInForm()
        {
            InitializeComponent();
        }

        public Action<string, string> SendResult;

//  Action<string, string> is equivalent to void Delegate(string, string)

        private void btnLoginAttempt_Click(object sender, EventArgs e)
        {
            if (textBox1.Text != "" && textBox2.Text != "")
            {
                if (SendResult != null) // defensive programming
                {
                    SendResult(textBox1.Text, textBox2.Text); // call the executable code in the main form

                    this.DialogResult = DialogResult.OK;
                }
                else
                {
                    // throw error ? do nothing ? or ...
                    this.DialogResult = DialogResult.Abort;  
                }
            }
            else
            {
                // do nothing ? cancel ? put up error warning ?
            }
        }

        private void btnCancel_Click(object sender, EventArgs e)
        {
            this.DialogResult = DialogResult.Cancel;
        }
    }
}

An alternative use of the Delegate/Func: unless the user's log-in data is validated, the log-in form stays open. In real=world code, ypu'd want to keep track of the attempts, and abort the log in after so many attempts;

// in the Main Form

private void Form1_Load(object sender, EventArgs e)
{
    LogInForm loginfrm = new LogInForm();

// declaring and instantiating the login form here means
// it "disappears" ... goes out of scope ... when this method is finished

    string username, password;

    loginfrm.SendResult = SendResult;

// this injects executable code (as a Delegate) into the new log in form

    DialogResult loginResult = loginfrm.ShowDialog();

    if (loginResult == DialogResult.OK)
    {
        // login success

        // user input now  in variables username, password;

        // now validate, make your connection string, etc.

    }
    else if (loginResult == DialogResult.Cancel)
    {
        // user canceled
    }
    else if (loginResult == DialogResult.Abort)
    {
        // login abort: SendResult not defined in login form
    }
}

private bool SendResult(string uname, string pword)
{
    // validate and return true of okay

    username = uname;
    password - pword;

    // validate here and return 'true if success
    return false;

}

the revised log-in form:

using System;
using System.Windows.Forms;

namespace YourNameSpaace
{
    public partial class LogInForm : Form
    {
        public LogInForm()
        {
            InitializeComponent();
        }

        // note change here from Action to Func
        public Func<string, string, bool> SendResult;

        private void btnLoginAttempt_Click(object sender, EventArgs e)
        {
            if (textBox1.Text != "" && textBox2.Text != "")
            {
                if (SendResult != null)
                {
                    if (SendResult(textBox1.Text, textBox2.Text))
                    {
                        this.DialogResult = DialogResult.OK;
                    }
                }
                else
                {
                    // throw error, do nothing ? or ...
                    this.DialogResult = DialogResult.Abort;  
                }
            }
            else
            {
                // cancel ? put error warning ?
            }
        }

        private void btnCancel_Click(object sender, EventArgs e)
        {
            this.DialogResult = DialogResult.Cancel;
        }
    }
}

«One day it will have to be officially admitted that what we have christened reality is an even greater illusion than the world of dreams.» Salvador Dali

modified 3-Nov-20 21:08pm.

Re: use connection from login form in other forms

Newkid on the block3-Nov-20 5:45

Newkid on the block

3-Nov-20 5:45

Thanks, i will have a good read and give that a bash Smile | :)

Re: use connection from login form in other forms

BillWoodruff3-Nov-20 14:46

BillWoodruff

3-Nov-20 14:46

I will add an alternate example where the 'SendResult Func/Delegate is triggered within the log-in form, and a more standard EventHandler declaration is used in the main form: this may be clearer.

«One day it will have to be officially admitted that what we have christened reality is an even greater illusion than the world of dreams.» Salvador Dali

Crystal reports and datagridviews

Damir Djordjevic31-Oct-20 4:39

Damir Djordjevic

31-Oct-20 4:39

Im very new to this and i usually search the web for the answer but i got stucked and i need help from community.

I have two datagridview on different tables and i wanna show them on a same crystal report.

Iv done it with one of em using XML Schema but what to do with other datagridview.

TY in advance

Re: Crystal reports and datagridviews

Gerry Schmitz31-Oct-20 5:15

Gerry Schmitz

31-Oct-20 5:15

2 reports right after one another is the same as 1 report. Or combine the 2 grids if you want "2 up" (and can't figure out how to put 2 grid controls on one row).

It was only in wine that he laid down no limit for himself, but he did not allow himself to be confused by it.
― Confucian Analects: Rules of Confucius about his food

IF Else statement on background colour of label.

Member 1497767230-Oct-20 2:29

Member 14977672

30-Oct-20 2:29

Hello,

Can anybody give me any guidance on how to create an if else statement on a background colour of a label.
For example, if the background colour of a label is white then do this else do this.

Re: IF Else statement on background colour of label.

Richard MacCutchan30-Oct-20 2:36

Richard MacCutchan

30-Oct-20 2:36

if (backcolor == "white")
{
    // do this
}
else
{
    // do that
}

Although you may wish to clarify your question with some more details of exactly what your code is trying to do.

Re: IF Else statement on background colour of label.

Member 1497767230-Oct-20 2:47

Member 14977672

30-Oct-20 2:47

Hello

thanks for such a quick reply and help, I have a mouse leave event on label 28. where once you leave the label it changes white.

then when you finish the maze at finish_point i want it to check if the label28 background colour is white. if it is then do the below close between the {} else bring up a message box stating you haven't found the treasure/ loot.

private void Finish_Point(object sender, EventArgs e)

{
this.Close();
th = new Thread(opennewform);
th.SetApartmentState(ApartmentState.STA);
th.Start();
}

Re: IF Else statement on background colour of label.

OriginalGriff30-Oct-20 2:52

OriginalGriff

30-Oct-20 2:52

Don't rely on colours - instead create a class level bool that tells you "the user left the label" instead. It's a lot more readable (and thus maintainable) and less prone to error later when you change things around.

Re: IF Else statement on background colour of label.

OriginalGriff30-Oct-20 2:50

OriginalGriff

30-Oct-20 2:50

if (myLabel.BackColor == Color.White)
    {
    ... do something
    }
else
    {
    ... do something else
    }

Be aware though both that a color test is specific: a tiny change in shade will fail the test, and that you can't assume any colour scheme on the part of the user: if you check for White, and the user prefers a Dark scheme it will fail, while SystemColors.Control may match.

Re: IF Else statement on background colour of label.

Member 1497767230-Oct-20 3:01

Member 14977672

30-Oct-20 3:01

Brilliant, Thank you this has worked.
Great help

Add treasure to my maze game

Member 1497767229-Oct-20 4:10

Member 14977672

29-Oct-20 4:10

Hello
I have a maze game with 3 forms/ levels.
When hit certian labels it will take you to another level by closing the current form and then opening the specified form.

I am now wanting to add some sort of treasure or scoring system that you need to collect and then the game keep a track of your score.

Is there anybody who can help me with this? I can supply you with code if you wish to look at the application.

Thanks

Re: Add treasure to my maze game

OriginalGriff29-Oct-20 4:20

OriginalGriff

29-Oct-20 4:20

We can't really help you with any specifics: we have no idea how your code works - and I for one don't want to wade through a pile of code trying to work out what part does what and why!

The way I'd do it is different: I wouldn't close the form and reopen a new one, I'd reuse the current form by clearing the play area and loading a new one from a file, using the same method I used when I first loaded a form - it's a lot more flexible that way than by designing a "static form" as a maze each time!

Having said that, I'd have a GameObject abstract base class, and derive Wall, Door, Player, Monster, Treasure, and ExitLevel classes from that. Your game board then becomes an array of GameObject instances, and the base class ensures that the derived classes have Move, Open, Attack, and so forth methods which they can handle. The Wall and Door classes for example refuse to move in any direction, but the Player can move provided nothing blocks his way. Doors and Chests can Open, Monsters can Attack and be Attacked and so forth.

How does yours work? Please, don't say "a button for each space on the board" because I'll get quite depressed ... Laugh | :laugh:

Re: Add treasure to my maze game

Gerry Schmitz29-Oct-20 5:14

Gerry Schmitz

29-Oct-20 5:14

Some people use "story boards" to help with their design. You need to decide what to do with this "treasure", etc.

How to Storyboard Your Game - Gamescrye Blog

It was only in wine that he laid down no limit for himself, but he did not allow himself to be confused by it.
― Confucian Analects: Rules of Confucius about his food

Is it possible to save DataGridView contents to a file with a specific suffix which can be loaded just by my own application?

Alex Dunlop28-Oct-20 8:09

Alex Dunlop

28-Oct-20 8:09

Hi,
I have a DataGridView, a save button, and a load button. I have seen in some tutorial that it is possible to export DataGridView content into Excel or *.txt file. But I want to save my contents into an unknown file which can only be read by my own App. How is it possible? Is there any tutorial for this purpose (I use C#)? Sleepy | :zzz:

Re: Is it possible to save DataGridView contents to a file with a specific suffix which can be loaded just by my own application?

Dave Kreskowiak28-Oct-20 9:21

Dave Kreskowiak

28-Oct-20 9:21

You're overthinking this. Put the data in each row into your own data structure, adding each structure to a collection. You can then use BinaryFormatter to serialize the collection to a file.

BinaryFormatter Class (System.Runtime.Serialization.Formatters.Binary) | Microsoft Docs[^]

Asking questions is a skill
CodeProject Forum Guidelines
Google: C# How to debug code
Seriously, go read these articles.

Dave Kreskowiak

Re: Is it possible to save DataGridView contents to a file with a specific suffix which can be loaded just by my own application?

OriginalGriff28-Oct-20 9:27

OriginalGriff

28-Oct-20 9:27

Basically, it's not possible: you can't "restrict" which apps can open a file (if you could, MS would use it for Word, Excel, and PowerPoint files for sure). Any app can open any file.

But ... they may not understand the content they look at - and that may be enough for you. If you encrypt your data before you write it to the file, and decrypt it when you read it, the it will certainly be harder for other apps to use.

The problem is that no matter how secure you need your data to be, remember that any app can read any file - and that does include both your data file and your application EXE file. So since your app would need to know the decryption key in order to read your encrypted data, it's a relatively simple matter to get the key from your EXE and then use it on the data files.

It's up to you to decide how "unreadable" you need your data to be and how much work you are prepared to put into it. Be aware that with any security intensive development, unless you research really well, fully understand the code you are writing / using, you can easily make your data less secure than plain text, rather than more!

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.