concatenating two wide character strings

Question

0.00/5 (No votes)

See more:

I just wrote this code to concatenate two wide characters strings. Could someone please comment if it looks OK? (seems to work at least).

C++

1. SomeStringClass amount = Window->get_text();
2. wchar_t strAmount[100] = L"Amount: "; // I know I could remove 100 from here too
3. wchar_t *ptr = wcscat( strAmount, amount.c_str() );
4.  SomeStringClass  finalStr;
5. finalStr.set(ptr, 10 /* 10 is roughly due to length of Amount line 2*/ + amount.length());

Now, finalStr contains what I wanted, e.g., "Amount: 123"

Posted 23-May-13 1:42am

Dan page

Updated 23-May-13 1:43am

v2

Add a Solution

Comments

Mohibur Rashid 23-May-13 7:50am

if you are using MFC
then try CString amount=...
CString strAmout=L"Amount : "
CString finalStr;
finalStr.Format("%s%d", strAmou, amount);

Dan page 23-May-13 8:13am

no, it's not MFC

CPallini 23-May-13 8:12am

Looks a lot of unnecessary code. For instance, what's the usefulness of the amount variable?

Dan page 23-May-13 8:13am

it's there to retrieve value of amount entered by user on display

CPallini 23-May-13 8:19am

Well, you may use directly Window->get_text() result, right?

Dan page 23-May-13 8:24am

Sure just I wanted to format it a bit before I display it

CPallini 23-May-13 8:28am

Yes, but you don't need the intermediate variable amount in order to format it.

Dan page 23-May-13 8:33am

a, ok you mean just use? Window->get_text();

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2013-05-23T02:35:00

Solution 1

C++

SomeStringClass amount = Window->get_text();
wchar_t strAmount[100];
int swprintf(strAmount, L"Amount: %s", amount);

Posted 23-May-13 2:35am

Richard MacCutchan