Welcome to the Lounge

Chris Maunder wrote:

This makes me feel old because it reminds me of when we used to cram our code into as small a space as possible to handle 25 line screens.

void someFunction() {
   if (something) {
      doThings();
      }
   }

void someFunction() {
  if (something) {
    DoThings();
  }
  else {
    DoDifferentThing();
  }
}

trønderen wrote:

But with the modern style of always putting braces on separate lines, always put braces around even a simple assignment if it is e.g. an if clause (so the minimum number of lines for an if statement is 4). Some people even insist on always putting blank lines before and after any 'structured' statement (such as if/else, loops etc.),

Marc Clifton wrote:

there should always be a single point of return

Slacker007 wrote:

Marc Clifton wrote:there should always be a single point of return

Slacker007 wrote:

I also like to reduce nesting If statements. Some devs love 50,000 nested If statements. No thank you.

int f(MyObject obj)
{
    int result = 0;
    MyObject2 obj2 = obj.FunctionA();
    if (obj2 != null)
    {
        MyObject3 obj3 = obj2.FunctionB();
        if (obj3 != null)
        {
            MyObject4 obj4 = obj3.FunctionC();
            if (obj4 != null)
            {
                result = obj4.value;
            }
        }
    }
    return result;
}

int f(MyObject obj)
{
    MyObject2 obj2 = obj.FunctionA();
    if (null == obj2)
    {
        return 0;
    }

    MyObject3 obj3 = obj2.FunctionB();
    if (null == obj3)
    {
        return 0;
    }

    MyObject4 obj4 = obj3.FunctionC();
    if (obj4 != null)
    {
        return 0;
    }

    result = obj4.value;
}

public string this[int i]
{
    get => types[i];
    set => types[i] = value;
}

public string Name
{
   get => locationName;
   set => locationName = value;
}