Welcome to the Lounge

8-Dec-21 18:22

I am working on an existing C# application, and find that there is a set of class definitions like this:

public class Class1<Ttype> { }

public abstract class Class2 { }

public class Concrete2 : Class2 { }

public class Report { }

public class Class3 : Concrete2 
{
    public Class1<Report> report = new ();
}

Would you call this spaghetti code? Or, is this a standard Design Pattern? Currently, it is causing my mind to whirl.

modified 9-Dec-21 0:29am.

Randor 8-Dec-21 18:59

Randor

8-Dec-21 18:59

Hmmm,

Kinda looks like a abstract factory pattern.

Amarnath S8-Dec-21 19:14

8-Dec-21 19:14

Thanks. Will go through this Abstract Factory pattern.

BernardIE53179-Dec-21 10:32

9-Dec-21 10:32

Greetings Kind Regards May I please inquire as to why your name is red colored Thank You - Cheerio

Randor 9-Dec-21 19:01

Randor

9-Dec-21 19:01

Hmmm,

Let's make a deal. If you tell me why you don't use any punctuation in your writings then I will tell you why my name is Red.

Deal?

BernardIE53179-Dec-21 19:47

9-Dec-21 19:47

Okee-Dokee I know a fellow much smarter than myself He suggested it He annoys me greatly if I don't take his advice This one I more or less am inclined to as he convinced me that punctuation marks seem as maculation on the page though I have a certain fondness for a well placed comma but periods I can live without His stated argument was when people speak they do not speak "comma" or "period" as would otherwise be placed in text Of course pauses and intonation do the job as he well knows but so far so good more or less Though I may return to my previous usual usage of ,'s, .'s and ?'s etc. - Cheerio

Member 106520839-Dec-21 21:55

Member 10652083

9-Dec-21 21:55

What makes you think this fellow is much smarter than yourself?

BernardIE53179-Dec-21 23:41

9-Dec-21 23:41

As for your inquiry for one thing he explained to me what a fractional root means and why Something I wondered about prior For another he explained how my childhood theory of gravity which by the way I knew was incorrect at the time should have led me to the idea of virtual particles Also from time to time he suggests solutions to minor occasional every-day problems which do not occur to me I hate his guts - Cheerio

Randor 9-Dec-21 22:50

Randor

9-Dec-21 22:50

PaltryProgrammer wrote:
when people speak they do not speak "comma" or "period" as would otherwise be placed in text

It just occurred to me that you may have a disability that requires speech-to-text. I apologize for asking, I should have thought about this.

I've been here on codeproject for nearly 20 years. Many years ago Chris added support for colorized usernames, around 15 years ago the forums were full of users with colored names, it seems I am one of the last users left that use this feature. The color has no meaning.

Best Wishes,
-David Delaune

BernardIE53179-Dec-21 23:42

9-Dec-21 23:42

Rest assured no need to be concerned I have no such disability My only disability is the love of pizza fresh vegetables in exotic hot sauces McDonald's Egg McMuffins freshly baked bread whole wheat of course and popcorn to name but a few Somehow I manage to stay slim and trim I probably would have chosen green to wit British Racing Green or perhaps red i.e. Alpha Romeo Red - Cheerio

Randor 10-Dec-21 1:27

Randor

10-Dec-21 1:27

Hi Bernard,

All this time I thought you were just trolling the site, but using the tools at my disposal I was able to find your identity. Your prose is natural, you weren't lying. Smile | :)

Welcome to codeproject, don't worry, I won't DOX you. $Shucks | :-\$

Member 1419238210-Dec-21 5:48

Member 14192382

10-Dec-21 5:48

Let's eat Grandma

MSBassSinger10-Dec-21 8:29

MSBassSinger

10-Dec-21 8:29

People do, in fact, speak with commas, periods, hyphens, etc. They are implemented in the length of time between words and voice inflections. Punctuation reflects how the words should be spoken as an intelligible phrase. Not using punctuation (when one can, of course) is just poor writing or laziness.

As for the OP question "Is this spaghetti?", it depends on the context of the project as a whole. I lean towards the old saying, "The more they overtake the plumbing, the easier it is to stop up the drain." Or a similar old saying, "Make it as simple as possible, but no simpler." The context of the project as a whole may dictate the inheritance complexity you see, or it could just be some developer who understands how to implement some arcane design pattern, but not why or when it is apporpriate.

BillWoodruff8-Dec-21 18:59

BillWoodruff

8-Dec-21 18:59

Namaskara,

I'd call it "sloppy pasta" without mnemonic flavors of some strange twisty type, but, definitely not idiyappam Smile | :)

imho, the best way to evaluate/study it is to ... if you are convinced it is safe, and, it does something interesting ... set break-points and single-step through some code that instantiates the classes.

cheers, Bill

«The mind is not a vessel to be filled but a fire to be kindled» Plutarch

Amarnath S8-Dec-21 19:14

8-Dec-21 19:14

Namaskara,

That's what I am doing, putting breakpoints, and going through it step by step.

Thanks

OriginalGriff8-Dec-21 20:04

OriginalGriff

8-Dec-21 20:04

The sauce however lacks body and flavour. Big Grin | :-D

"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!

Super Lloyd8-Dec-21 19:53

Super Lloyd

8-Dec-21 19:53

this just look like a bunch of class in the same file. there is hardly enough to call that anything... Smile | :)

for example

public class List<T> {}

public abstract Visual {}
public class UIElement : Visual {}

public class String {}

public class FrameworkElement : UIElement
{
  public List<string> strings = new ();
}

Unless you mean to suggest? perhaps split that in a few files?
that not spaghetti, but that would be a little more organisation! Smile | :)

spaghetti code is about code lacking.... hierarchical stucture, well defined responsibility, that sort of thing.
Not so much about whether the code is one humongous file or many small ones.

A new .NET Serializer
All in one Menu-Ribbon Bar
Taking over the world since 1371!

modified 9-Dec-21 1:59am.

Amarnath S8-Dec-21 20:01

8-Dec-21 20:01

This makes sense. I am starting to understand the code.

OriginalGriff8-Dec-21 20:20

OriginalGriff

8-Dec-21 20:20

It would depend on what the classes contained: it's quite possible for that to be a good design - and the Concrete2 class could be just trying to get round a bug in teh VS designer that has been unfixed since the first release of .NET: you can't use the designer on a Control derived from an abstract class without a dummy concrete class between them:

public abstract class MyBase: UserControl { ... }
public class _MyBase: MyBase {}
public class MyControl : _MyBase { ... }

The designer can open MyBase and MyControl, but can't open _MyBase

Amarnath S8-Dec-21 20:30

8-Dec-21 20:30

Thanks for your reply. I am starting to understand the code, and it seems to be too intelligent a design for a lay person like me.

obermd9-Dec-21 4:56

obermd

9-Dec-21 4:56

If you have to ask, then the answer is probably YES.

Gerry Schmitz9-Dec-21 6:15

Gerry Schmitz

9-Dec-21 6:15

Looks like the natural progression of a first time C# project.

It was only in wine that he laid down no limit for himself, but he did not allow himself to be confused by it.
― Confucian Analects: Rules of Confucius about his food