Click here to Skip to main content
15,357,967 members

Welcome to the Lounge

   

For discussing anything related to a software developer's life but is not for programming questions. Got a programming question?

The Lounge is rated Safe For Work. If you're about to post something inappropriate for a shared office environment, then don't post it. No ads, no abuse, and no programming questions. Trolling, (political, climate, religious or whatever) will result in your account being removed.

 
GeneralRe: I don't like code reviews Pin
OriginalGriff6-Sep-21 21:25
mveOriginalGriff6-Sep-21 21:25 
GeneralRe: I don't like code reviews Pin
Jörgen Andersson6-Sep-21 22:31
professionalJörgen Andersson6-Sep-21 22:31 
GeneralRe: I don't like code reviews Pin
BillWoodruff7-Sep-21 3:18
mveBillWoodruff7-Sep-21 3:18 
GeneralRe: I don't like code reviews Pin
Super Lloyd6-Sep-21 21:35
MemberSuper Lloyd6-Sep-21 21:35 
GeneralRe: I don't like code reviews Pin
OriginalGriff6-Sep-21 21:41
mveOriginalGriff6-Sep-21 21:41 
GeneralRe: I don't like code reviews Pin
Super Lloyd6-Sep-21 21:49
MemberSuper Lloyd6-Sep-21 21:49 
GeneralRe: I don't like code reviews Pin
OriginalGriff6-Sep-21 21:53
mveOriginalGriff6-Sep-21 21:53 
GeneralRe: I don't like code reviews Pin
Eric Lapouge8-Sep-21 2:37
MemberEric Lapouge8-Sep-21 2:37 
C#
for (int room = 0, roomCount = rooms.Count; room < roomCount; room++)
{
rooms[room] = new Room();
}


room can be replaced by pos (or anything more meaningful); anyway: anything not like this as a code will not go live for me...

Besides this point, when I had to manage core reviews, I dit it with the whole team so anybody could have seen and emphasis on different things and not only what I wanted to pinpoint.

One point missing, is that code reviews in 2021 aren't the same as those done in the 1990: now we have tools like R# Shart (no publicity intended) which are removing a lot of "discrepancies" (bugs), automating test tools, and so on. So now, code reviews are more about code's readability and maintenance.
Because of these (hey folks, dont forget you're using Intellisense which types most of the code for you!), so definitively no excuse to have readable code.

modified 8-Sep-21 13:12pm.

GeneralRe: I don't like code reviews Pin
Slacker0076-Sep-21 21:39
professionalSlacker0076-Sep-21 21:39 
GeneralRe: I don't like code reviews Pin
Super Lloyd6-Sep-21 21:52
MemberSuper Lloyd6-Sep-21 21:52 
GeneralRe: I don't like code reviews Pin
Slacker0076-Sep-21 21:49
professionalSlacker0076-Sep-21 21:49 
GeneralRe: I don't like code reviews Pin
Super Lloyd6-Sep-21 22:48
MemberSuper Lloyd6-Sep-21 22:48 
GeneralRe: I don't like code reviews Pin
Sander Rossel6-Sep-21 22:32
professionalSander Rossel6-Sep-21 22:32 
GeneralRe: I don't like code reviews Pin
Jörgen Andersson6-Sep-21 22:56
professionalJörgen Andersson6-Sep-21 22:56 
GeneralRe: I don't like code reviews Pin
yacCarsten6-Sep-21 23:20
MemberyacCarsten6-Sep-21 23:20 
GeneralRe: I don't like code reviews Pin
Super Lloyd6-Sep-21 23:32
MemberSuper Lloyd6-Sep-21 23:32 
GeneralRe: I don't like code reviews Pin
BillWoodruff6-Sep-21 23:45
mveBillWoodruff6-Sep-21 23:45 
GeneralRe: I don't like code reviews Pin
Super Lloyd7-Sep-21 1:14
MemberSuper Lloyd7-Sep-21 1:14 
GeneralRe: I don't like code reviews Pin
BillWoodruff7-Sep-21 3:30
mveBillWoodruff7-Sep-21 3:30 
GeneralRe: I don't like code reviews Pin
jsc427-Sep-21 0:31
professionaljsc427-Sep-21 0:31 
GeneralRe: I don't like code reviews Pin
dandy727-Sep-21 2:53
Memberdandy727-Sep-21 2:53 
GeneralRe: I don't like code reviews Pin
obermd7-Sep-21 3:24
Memberobermd7-Sep-21 3:24 
GeneralRe: I don't like code reviews Pin
Slacker0077-Sep-21 3:30
professionalSlacker0077-Sep-21 3:30 
GeneralRe: I don't like code reviews Pin
BillWoodruff7-Sep-21 3:50
mveBillWoodruff7-Sep-21 3:50 
GeneralRe: I don't like code reviews Pin
Slacker0077-Sep-21 4:20
professionalSlacker0077-Sep-21 4:20 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.


Straw Poll

Do you take a development machine with you on holidays?
A laptop, a mini PC, a tablet that allows you to remote to a Virtual Desktop. There are options.
  Results   627 votes