The Lounge - CodeProject

honey the codewitch1-Dec-19 14:59

1-Dec-19 14:59

So I use Is and Has differently on my property and field names, depending on what they do.

Is implies the state of something, whereas Has implies containing something.

I've even had to use both for the same item. On my FSM code I have IsAccepting and HasAccepting, the first indicates whether the state is accepting, the second indicates whether itself or any states it contains is accepting- basically if it has any accepting states. Heavily commented in that case, and is fortunately the only place I've ever had that happen.

But it leads me to weird things like "IsEnded" instead of "HasEnded"

When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.

Re: Some coding style weirdness, Is and Has

Ravi Bhavnani1-Dec-19 16:14

Ravi Bhavnani

1-Dec-19 16:14

If a State object can be accepting when its IsAccepting property is true, I recommend renaming HasAccepting to HasAcceptingStates.

#readability

/ravi

My new year resolution: 2048 x 1536
Home | Articles | My .NET bits | Freeware
ravib(at)ravib(dot)com

Re: Some coding style weirdness, Is and Has

honey the codewitch1-Dec-19 16:18

honey the codewitch

1-Dec-19 16:18

I considered that too. It conflicted with another method that operates on a collection of otherwise potentially unrelated states, but then I ended up renaming it later to HasAnyAcceptingStates()

The api is kind of confusing because of the self-repeating, fractally nature of state machines like this. There are all kinds of subtly different but highly related operations on them. Even shoring up the API and naming took me going back to it over the years, never 100% satisfied, but it's more or less frozen at this point.

And, given what I've seen of the other similar APIs out there (usually in Java), mine is far cleaner. They're all nasty. Mine at least reins in the crazy somewhat, but then I'm sure everyone thinks that about their own code Roll eyes | :rolleyes:

When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.

Re: Some coding style weirdness, Is and Has

Super Lloyd1-Dec-19 18:15

Super Lloyd

1-Dec-19 18:15

this is strange... and has some weirdness to it too! Poke tongue | ;-P

A new .NET Serializer
All in one Menu-Ribbon Bar
Taking over the world since 1371!

Re: Some coding style weirdness, Is and Has

Jörgen Andersson1-Dec-19 20:13

Jörgen Andersson

1-Dec-19 20:13

IsNull or HasValue? Smile | :)

Wrong is evil and must be defeated. - Jeff Ello

Re: Some coding style weirdness, Is and Has

honey the codewitch1-Dec-19 20:16

honey the codewitch

1-Dec-19 20:16

I'd prefer IsNull or IsEmpty (depending on what it was)

but actually for those things I typically sidestep it altogether with

bool TryGetValue(...,out T value)

When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.

Re: Some coding style weirdness, Is and Has

OriginalGriff1-Dec-19 21:12

OriginalGriff

1-Dec-19 21:12

Use YodaNaming: "EndedItIs" and "EndedItHas" - that way masked nicely any confusion is.

"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
AntiTwitter: @DalekDave is now a follower!

Re: Some coding style weirdness, Is and Has

honey the codewitch1-Dec-19 21:17

honey the codewitch

1-Dec-19 21:17

they would match my yoda conditionals like

if(null!=str) ...

When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.

Re: Some coding style weirdness, Is and Has

BillWoodruff1-Dec-19 22:29

BillWoodruff

1-Dec-19 22:29

States

    GetStates(State state)  => IEnumerable<State>
    
    GetAcceptingStates(State state) => IEnumerable<State>
    
    GetNonAcceptingStates(State state) => IEnumerable<State>
    
    GetStateStatus(State state) => enum // ended active closed ... ?
    
    SetStateStatus(State state) => bool ? or error code ?
    
    HasAcceptingStates(State state) => bool
    
    IsStateAccepting(State state) => bool

«One day it will have to be officially admitted that what we have christened reality is an even greater illusion than the world of dreams.» Salvador Dali

Re: Some coding style weirdness, Is and Has

honey the codewitch2-Dec-19 5:20

honey the codewitch

2-Dec-19 5:20

That's very close to how it ended up.

When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.

Re: Some coding style weirdness, Is and Has

PIEBALDconsult2-Dec-19 5:18

PIEBALDconsult

2-Dec-19 5:18

Is this simply confusion with IS_A and HAS_A ?

Re: Some coding style weirdness, Is and Has

honey the codewitch2-Dec-19 5:19

honey the codewitch

2-Dec-19 5:19

I WOULDN'T EVEN NAME MY CONSTANTS LIKE THAT. Mad | :mad:

When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.

Re: Some coding style weirdness, Is and Has

PIEBALDconsult2-Dec-19 5:28

PIEBALDconsult

2-Dec-19 5:28

Those are concepts; not code.

Re: Some coding style weirdness, Is and Has

honey the codewitch2-Dec-19 5:29

honey the codewitch

2-Dec-19 5:29

I'm just messing with you. Big Grin | :-D

When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.

Re: Some coding style weirdness, Is and Has

Gary Wheeler2-Dec-19 5:54

Gary Wheeler

2-Dec-19 5:54

honey the codewitch wrote:
But it leads me to weird things like "IsEnded" instead of "HasEnded"

No criticism intended, but I use:

public bool Ended
{
    get
    {
        bool value = false;
        //...
        return value;
    }
}

I've never liked the IsCondition or HasThing naming style, probably because they have a whiff of Hungarian notation about them.

Software Zen: delete this;

Re: Some coding style weirdness, Is and Has

honey the codewitch2-Dec-19 5:56

honey the codewitch

2-Dec-19 5:56

when I'm in .NET land I adhere closely to the .NET naming conventions.

Over the years I've become far less about personal preference, and far more about when in Rome.

At best i tend to build on them rather than change them.

When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.

Re: Some coding style weirdness, Is and Has

Gary Wheeler2-Dec-19 6:09

Gary Wheeler

2-Dec-19 6:09

honey the codewitch wrote:
far more about when in Rome

I have to do that a lot more now than I used to. My group has been down-sized from 17 to 5 people over the last 5 years, and so I get to maintain a fair amount of other folks' code. Sometimes it takes a shot of whiskey with a Zofran[^] chaser to stay consistent with how they did things, but as long as it pays the bills...

Software Zen: delete this;

Re: Some coding style weirdness, Is and Has

honey the codewitch2-Dec-19 6:13

honey the codewitch

2-Dec-19 6:13

I've had some good luck with Buddhism in terms of overcoming this.

Not trying to convert anyone - I'm not a buddhist myself, but my first serious boyfriend was and he drilled a lot of it into me when i was still impressionable.

The headshrinkers call it Dialectical Behavioral Therapy, but all it really means is just relax. $Shucks | :-\$

The world will keep turning no matter how people name things.

If I can understand it, then all is good. If I can't, then there is opportunity for growth in the challenge.

Or, more likely I'll just smash something. Laugh | :laugh:

When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.

Health and Safety Zen

OriginalGriff1-Dec-19 11:22

OriginalGriff

1-Dec-19 11:22

If a tree falls in the forest and no one hears it, is that a very risky situation for the hearing impaired?

"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
AntiTwitter: @DalekDave is now a follower!

Re: Health and Safety Zen

Ravi Bhavnani1-Dec-19 11:47

Ravi Bhavnani

1-Dec-19 11:47