|
Sounds a lot like the poor code at a place that I used to work. And one of the reasons that I don't work there anymore. 
Also the reason for my tag line 
Just because the code works, it doesn't mean that it is good code.
|
|
|
|
|
|
DialogResult is null when the dialog box is shown but neither accepted nor canceled.
You just confirmed why I never forayed into WPF. WTF???
Marc
|
|
|
|
|
I usually solve the pitfall by using a viewmodel. Any kind of close event I care about is redirected to a command in the VM, which then fires an event (Either some kind of success event, which has it's specific event args, or whatever I need and care about).
Both the window and caller subscribe to the event - The calling instance gets the data, and the window closes itself.
|
|
|
|
|
But let's agree on the fact that a nullable boolean is a stupid idea. I mean it defeats the sole purpose of a bool, doesn't it?
|
|
|
|
|
Marco Bertschi (SFC) wrote: But let's agree on the fact that a nullable boolean is a stupid idea.
Well, given that a field in a DB record can be null (which in itself is a whole can of worms as to what null means in a field) it makes sense that the language supports nullable value types -- I thought it was a significant improvement in C# when that support was added. So, from that perspective, a nullable bool is just like any other nullable value type, and I don't have a problem with it.
What I do have a problem with is when the null state is used as a valid state. In my opinion, any nullable type that is null when you need to use it for something should result in an exception. By that definition, "nullable" to me (and when I design databases) means "it's OK if we don't know the value of this type right now, but when we use it for something, it darn well better not be null."
The exception to that might be business rules that handle "I don't know."
Marc
|
|
|
|
|
Marc Clifton wrote: Let's use bool? as a 3 state variable instead of a readable enum.
You have to admit, that's almost ingenious before it was mixed in with round of WTF by not making it readable.
I've actually used a triple state boolean before... with yes, no, and maybe for the valid values.
Jeremy Falcon
|
|
|
|
|
Code it as a single bit for extra points!
Sudden Sun Death Syndrome (SSDS) is a very real concern which we should be raising awareness of. 156 billion suns die every year before they're just 1 billion years old.
While the military are doing their part, it simply isn't enough to make the amount of nukes needed to save those poor stars. - TWI2T3D (Reddit)
|
|
|
|
|
Jeremy Falcon
|
|
|
|
|
I often wonder what the Gurus that haunt this website would feel about my code.
if (Object.DividedByZero == true) { Universe.Implode(); }
Meus ratio ex fortis machina. Simplicitatis de formae ac munus. -Foothill, 2016
|
|
|
|
|
On my personal scale of unmaintainable code that's about 15 of 100. The real grandmasters use such things as mere decoration. Their centerpiece is absolutely uncorrectable. make one little change and everything falls apart like a row of dominos.
What they did? Nothing special. They put a part of the application's logic into the data layer as stored procedures. SQL is great to see what's being done, but you get absolutely no clue to what this is supposed to accomplish. Dozens of SPs with no less than 500 lines already make the whole thing unreadable, but that still does not make it uncorrectable.
The final blow comes from a first unexpected direction. On every table are at list 5 - 10 triggers which do really obscure things under even more obscure circumstances and modify things in other tables, which fires even more triggers. To keep the whole trigger avalanche under control, there are columns in the tables to hold status codes instead of data. Let's forget database design for a second and just try to figure out what status 1, 2, 3, -1 and -112 could mean.
It would have been to easy if any documentation had existed at all and to add insult to injury, the mastermind behind that thing would deny any knowledge, but take any 'unjustified' criticism against his life's work personally. Obviously we were all too dumb to see the true ingenuity behind it all.
And now stop complaining. 
The language is JavaScript. that of Mordor, which I will not utter here
This is Javascript. If you put big wheels and a racing stripe on a golf cart, it's still a f***ing golf cart.
"I don't know, extraterrestrial?"
"You mean like from space?"
"No, from Canada."
If software development were a circus, we would all be the clowns.
modified 2-Mar-17 3:31am.
|
|
|
|
|
I've never seen it quite that bad, but such bastardized designs (with a native app service component that uses that database, of course) is a big part of why I've been pushing so hard lately to switch to a document store.
If you want to use programmability for BI queries and your analytics...fine. But don't make application code dependent on it.
"There are three kinds of lies: lies, damned lies and statistics."
- Benjamin Disraeli
|
|
|
|
|
CDP1802 wrote: To keep the whole trigger avalanche under control, there are columns in the tables to hold status codes instead of data.
That triggers my "run awayyyyy!" response.
CDP1802 wrote: And now stop complaining.
Indeed. 
Marc
|
|
|
|
|
Marc Clifton wrote: That triggers my "run awayyyyy!" response.
Most that worked there did just that.
The language is JavaScript. that of Mordor, which I will not utter here
This is Javascript. If you put big wheels and a racing stripe on a golf cart, it's still a f***ing golf cart.
"I don't know, extraterrestrial?"
"You mean like from space?"
"No, from Canada."
If software development were a circus, we would all be the clowns.
|
|
|
|
|
Marc Clifton wrote: 10. Let's use bool? as a 3 state variable instead of a readable enum.
I think that's called "job security".
/ravi
|
|
|
|
|
Jeremy Falcon
|
|
|
|
|
Haven't met a developer yet that doesn't bitch about how lousy the code is that he has to maintain that was written by someone else!
|
|
|
|
|
I bitch about my own code written some years before.
* CALL APOGEE, SAY AARDWOLF
* GCS d--- s-/++ a- C++++ U+++ P- L- E-- W++ N++ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t++ 5? X R++ tv-- b+ DI+++ D++ G e++>+++ h--- ++>+++ y+++* Weapons extension: ma- k++ F+2 X
* Never pay more than 20 bucks for a computer game.
* I'm a puny punmaker.
|
|
|
|
|
Me too!
|
|
|
|
|
ClockMeister wrote: Haven't met a developer yet that doesn't bitch about how lousy the code is that he has to maintain that was written by someone else!
Including the code of my former self. That said, it's stuff like this that is fodder for blog posts and articles on how to write better code. Ahhh, self-improvement, a never ending process. 
Marc
|
|
|
|
|
... it's amazing sometimes to look back at code that you wrote 15 or 20 years ago and see what you've learned in that time.
|
|
|
|
|
ClockMeister wrote: ... it's amazing sometimes to look back at code that you wrote 15 or 20 years ago and see what you've learned forgotten in that time.
FTFY
|
|
|
|
|
Trust me... Every place in the IT universe has abhorrent code.
Like the "Borg", resistance is futile and you cannot escape it.
So much for the "silver bullets" of the modern age like Agile...
Steve Naidamast
Sr. Software Engineer
Black Falcon Software, Inc.
blackfalconsoftware@outlook.com
|
|
|
|
|
Steve Naidamast wrote: So much for the "silver bullets" of the modern age like Agile...
As Duncan would say, Agile is about team management, not process management.
Where I'm at, there is no process management when it comes to code quality.
Marc
|
|
|
|
|
Marc:
Agile has been touted as the best thing since "sliced bread" for development.
The idea behind Agile and XP before that was to find a way to make teams\people work as fast as possible by eliminating or reducing vital aspects of the design and development processes. It has done a terrible job in that project failures tend to still be in the continuous high percentile ranges.
You are right in saying that the Agile paradigm is supposed to be about team management but the effects always have a way of filtering down to the code processes. When you remove critical foundations of development such as quality design to begin coding, coding will suffer proportionately as it has been shown to do.
There was never any need to develop XP or Agile as a good review of actual software engineering standards and principals had already provided everything any team would have required to get their projects in on time and within budget with a high degree of quality.
Problem is that these promoters of Agile are like trying to break the laws of physics, and the results show.
Actual process management of developer code is only well done through such processes as CMMI, which has solutions even for individual developer management of their efforts.
Steve Naidamast
Sr. Software Engineer
Black Falcon Software, Inc.
blackfalconsoftware@outlook.com
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
