|
While we're on the subject of code reviews, what do you guys think about sloppy code that's not formatted well? I tend to not think I'm that anal retentive, but I admit the poindexter comes out when I see sloppy code that's not kept up to a proper margin, not indented decently, old commented code left in, etc.
Oddly enough, the coders that write messy code tend to also have messy cars and homes. It's gross.
Jeremy Falcon
|
|
|
|
|
However awful my code might be, at least it's properly formatted... 
I agree with you; it's the same when I interview a developer that turns up looking like a homeless person: if you can't be bothered to take care of yourself, why would I believe that you'd be any different with your attitude to coding?
|
|
|
|
|
Or if they smell bad man. All the sudden the entire interaction becomes about the stinch and how to get away from it.
Jeremy Falcon
|
|
|
|
|
That is the worst of all possible scenarios. Have had to tell someone that they need to bathe. Was not pleasant.
|
|
|
|
|
So you think Einstein was wrong? 
|
|
|
|
|
|
Quote: if you can't be bothered to take care of yourself
Pic[^]. Do you think he`looks like a physicist or a hobo?
|
|
|
|
|
He looked somewhat disheveled which is not the same as looking like a hobo.
Besides, I, like the man, hate wearing socks.
|
|
|
|
|
I think the comments about the looks on one subject also reflects the action in another. If it truly were like that you'd never be fooled, by, let's say, politicians. 
|
|
|
|
|
I doubt Einstein ever showed up for a job interview looking like that, especially in his younger years. Once you've established yourself you can pull off the disheveled look
(Found a pic [^])
|
|
|
|
|
Very interesting link... Thanks!
If your actions inspire others to dream more, learn more, do more and become more, you are a leader.-John Q. Adams
You must accept one of two basic premises: Either we are alone in the universe, or we are not alone in the universe. And either way, the implications are staggering.-Wernher von Braun
Only two things are infinite, the universe and human stupidity, and I'm not sure about the former.-Albert Einstein
|
|
|
|
|
You're certainly no Einstein if you can't figure it out ... but that was already obvious.
|
|
|
|
|
Probably. 
|
|
|
|
|
That's kind of a shallow analogy.
It's like comparing Tesla's love for physics and women.
You just cannot seek connections between ones physical appearance and mental capabilities.
|
|
|
|
|
Years of research have shown that I can develop software just as well in jeans and tennis shoes as compared to slacks and dress shoes.
|
|
|
|
|
It was, of course, somewhat of a generalization - my wife tells me I look like a tramp on the days I can't be asked to shave.
|
|
|
|
|
Errr.. no.
For years the military has used attention to excruciating detail in training to get soldiers aware of small things.. since ignoring small things can get you killed in combat.
The attitude you bring to the table regarding how you handle details shows up in ALL we do. And good software is definitely about managing details well.
I couldn't disagree with you more.
|
|
|
|
|
Use a tool for codeformatting, make sure to run it before you commit your code, or make your editor format your code.
Codeformatting "by hand" is waste and should be eliminated.
|
|
|
|
|
I do that to other people's code.
|
|
|
|
|
When you do that:
- It seems in the source control that you modified the source code
- It looks insulting for the other developer (the one who originally wrote the code)
If you can't agree in a friendly conversation on one style of code, then you have more important problems to tackle in the team.
Make it simple, as simple as possible, but not simpler.
|
|
|
|
|
Adam Tibi wrote: It seems in the source control that you modified the source code
Indeed.
Adam Tibi wrote: It looks insulting for the other developer (the one who originally wrote the code)
Then they should have done it right the first time.
Seriously, if you're insulted because I tell you to format the code according to our agreed upon standards, then you're working in the wrong place.
|
|
|
|
|
What Karel said. Coding is, well, a love affair, and I expect code to be treated respectfully, and in part that means it should be visually pleasing, from 10 feet away, to look at.
Jeremy Falcon wrote: the coders that write messy code tend to also have messy cars and homes. It's gross.
Have you visited them???
But even more of an issue for me is, coders that write messy code also write bad code, at least in my experience.
Marc
|
|
|
|
|
Marc Clifton wrote: Have you visited them???
Some I've hung out with over the years and some I just listened to them talk about their habits. It's amazing what you can learn if you really listen to the stuff people say.
Marc Clifton wrote: But even more of an issue for me is, coders that write messy code also write bad code, at least in my experience.
Agreed. It's just a lazy mentality. And if they're that lazy about formatting, chances are they're that lazy about learning and education.
Jeremy Falcon
|
|
|
|
|
Jeremy Falcon wrote: It's amazing what you can learn if you really listen to the stuff people say.
Aye, and listening is a skill I find very few people have. This guy[^] has some short TedTalks on the subject I found quite good, if you're interested.
Marc
|
|
|
|
|
I will check that out. Thanks.
Jeremy Falcon
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
