Welcome to the Lounge

Colborne_Greg wrote:

Coding practices is the topic

Colborne_Greg wrote:

Its valid code

<System.Runtime.Serialization.DataMember>
        Private mLastUpdated As DateTime

        <System.Runtime.Serialization.DataMember>
        Private mLastUpdatedBy As String

        <System.Runtime.Serialization.DataMember>
        Private mClearanceRequired As Int64

        <System.Runtime.Serialization.DataMember>
        Private mClearanceIsRequired As Boolean

Quote:

...datamember so many times with the word private seems to be a waste of space.

Quote:

The intent is white space and readability not saving space.

Namespace Sinks
    <System.Runtime.Serialization.DataContract(IsReference:=True)>
    Public MustInherit Class Base
        Inherits Validate
        Implements iInterface

        <System.Runtime.Serialization.DataMember>
        Private mLastUpdated As DateTime, _
                mLastUpdatedBy As String, _
                mClearanceRequired As Int64, _
                mClearanceIsRequired As Boolean

        Public Sub New()
            MyBase.New()
        End Sub
        Public Sub New(Clearance As Int64)
            MyBase.New()
            ClearanceRequired = Clearance
        End Sub

        Public Property LastUpdated As DateTime Implements iInterface.LastUpdated
            Get
                Return mLastUpdated
            End Get
            Set(value As DateTime)
                mLastUpdated = value
            End Set
        End Property
        Public Property LastUpdatedBy As String Implements iInterface.LastUpdatedBy
            Get
                Return mLastUpdatedBy
            End Get
            Set(value As String)
                mLastUpdatedBy = value
            End Set
        End Property
        Public Property ClearanceIsRequired As Boolean Implements iInterface.ClearanceIsRequired
            Get
                Return mClearanceIsRequired
            End Get
            Set(value As Boolean)
                mClearanceIsRequired = value
            End Set
        End Property
        Public Property ClearanceRequired As Long Implements iInterface.ClearanceRequired
            Get
                Return mClearanceRequired
            End Get
            Set(value As Long)
                mClearanceIsRequired = True
                mClearanceRequired = value
            End Set
        End Property

        Public Overloads ReadOnly Property Value(User As Directory.iUser) As Object Implements iInterface.Value
            Get
                Select Case True
                    Case User.Deny : Throw New Exception("User Denied!")
                    Case ClearanceIsRequired And User.ClearanceReadLevel < ClearanceRequired : Throw New Exception("User clearance is lower then required!")
                    Case Else : Return MyBase.Value
                End Select
            End Get
        End Property
        Public Overloads WriteOnly Property Value(UpdatedDate As Date, LastUpdatedBy As String) As Object Implements iInterface.Value
            Set(value As Object)
                Me.LastUpdated = UpdatedDate
                Me.LastUpdatedBy = LastUpdatedBy
                MyBase.Value = value
            End Set
        End Property

        Public Overloads WriteOnly Property Value(UpdatedDate As Date, LastUpdatedBy As Directory.iUser) As Object Implements iInterface.Value
            Set(value As Object)
                If Me.LastUpdated = Nothing Then Me.LastUpdated = Me.Created

                Select Case True
                    Case ClearanceIsRequired
                        LastUpdatedBy.Authorize _
                        (
                            OriginalDate:=Me.LastUpdated,
                            ChangeDate:=UpdatedDate,
                            ClearanceLevel:=Me.ClearanceRequired
                        )
                    Case Else
                        LastUpdatedBy.Authorize _
                        (
                            OriginalDate:=Me.LastUpdated,
                            ChangeDate:=UpdatedDate
                        )
                End Select

                Me.Value(UpdatedDate, LastUpdatedBy.Name) = value
            End Set
        End Property
    End Class
End Namespace

<System.Runtime.Serialization.DataMember> Private mLastUpdated As DateTime
<System.Runtime.Serialization.DataMember> Private mLastUpdatedBy As String
<System.Runtime.Serialization.DataMember> Private mClearanceRequired As Int64
<System.Runtime.Serialization.DataMember> Private mClearanceIsRequired As Boolean

Gates VP wrote:

That stated, if you're mixing types on the "multi-declarations", it's time split them out.

private:
   int x;
   double y;
     .
     .
     .

Quote:

I don't see any confusion, except that someone may be in doubt if the attribute applies only to the first variable or all of them.