|
I just found this:
if ( ( _recStatus.OnlineState() == ONLINE ) || (_falseOnline == true) ) in some code. I didn't write it.
What. The. ![Elephant | [mastadon]](https://www.codeproject.com/script/Forums/Images/elephant.gif) .
... and yes, I know about The Weird and The Wonderful[^], which this is neither. This is motivation for homicide.
Software Zen: delete this;
|
|
|
|
|
Ah, they miss the && (_trueOnline != false).
Or did you mean something else ?
|
|
|
|
|
I need to borrow your CP account name for a while. I promise to give it right back, as soon as I'm finished.
Software Zen: delete this;
|
|
|
|
|
Maybe the author wanted to write:
if ( ( _recStatus.OnlineState() == ONLINE ) || (_pretendOnline == true) ) ...just a thought.
However I have little patience for underscores at the beginning of variable names. Everyone should have got the memo that they are reserved for compiler use since 2003. Seems even Microsoft has heard about that.
Mircea
|
|
|
|
|
Mircea Neacsu wrote: pretendOnline
This is pure gold. Fake it until you make it.
|
|
|
|
|
My thoughts were more along the line of simulateOnline but everyone knows naming is the most difficult part of programming 
Mircea
|
|
|
|
|
This is the female version 
|
|
|
|
|
Mircea Neacsu wrote: Maybe the author wanted to write:
A comment elsewhere in the code indirectly implies that's the intent.
Mircea Neacsu wrote: I have little patience for underscores at the beginning of variable names
We use this for private and protected values. It's been part of our naming convention since the late 1990's, predating the compiler reservation. FWIW, we have never had a conflict in all that time over several code bases that run to millions of lines.
Software Zen: delete this;
|
|
|
|
|
I've never had to work with such large code bases and I certainly respect your internal conventions. However, a little devil inside me thinks that a tool converting _variable to variable_ shouldn't be all that bad 
Mircea
|
|
|
|
|
Mircea Neacsu wrote: a tool converting _variable to variable_ shouldn't be all that bad
Unfortunately a majority of our code base is C++, and Visual Studio support for refactoring it is still error-prone even in VS2022. They still exceed the scope when renaming values.
Software Zen: delete this;
|
|
|
|
|
grep
|
|
|
|
|
Don't you mean grep_?
Jeremy Falcon
|
|
|
|
|
Mircea Neacsu wrote: However, a little devil inside me thinks that a tool converting _variable to variable_ shouldn't be all that bad 
I may be dumb as rocks, but I know a good idea when I see it. If I ever make any global edits to my code, I use regular expressions to do so. Now would be a good time to save a backup. Then run the editing script. I learned that the hard way. The editing script almost always changes things that you don't intend to edit. I've encountered catastrophes doing this. I've written 25,000 lines of JavaScript code on a single web page. With that much code, any attempt at a global edit would likely result in a disaster.
|
|
|
|
|
I upvoted this. While I don't think the original posts warrants jail time. I do think name dangling a variable isn't that big of a deal. Peeps that speak in such absolutes tend to lack experience, never lead or worked in a team successfully, etc. - in my experience.
Yes, today's tools make it a lot less necessary, but imagine a C/C++ application where you intend for it to be portable and have no guarantee any code viewer/editor/IDE will have introspection/intellisense.
If it's something like VS only, Windows specific C++, never to be ported type app, I could see not doing it. Just depends on context. Although, I'd argue that this day and age writing Windows only C++ code is selling the app short.
Jeremy Falcon
|
|
|
|
|
Mircea Neacsu wrote: Maybe the author wanted to write:
That's how I read it, as in there's a way to fake like being online in the application. Probably could've used a non boolean logic type variable name though, but not worth homicide. 
Jeremy Falcon
|
|
|
|
|
Gary Wheeler wrote: if ( ( _recStatus.OnlineState() == ONLINE ) || (_falseOnline == true) )
If online or offline, then return true... 
Gary Wheeler wrote: This is motivation for homicide.
Grab your shovels, your pick axes, and your pitchforks. This egregious violation of logic will not be tolerated. 
|
|
|
|
|
Welcome, God Of Second Guessing One's Self.
cheers
Chris Maunder
|
|
|
|
|
gary - you and I need to grill a couple of steaks together... I do not suffer stupid either.
For you "youngsters" I would give you some career advice... the veteran who walks around pissed off all the time? Find a reason to talk to him. Or her, but.... You might gain some tribal knowledge that is RAPIDLY evaporating. I'm sure the world will go on, but learn to garden 
Charlie Gilley
“They who can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety.” BF, 1759
Has never been more appropriate.
|
|
|
|
|
rename _falseOnline to _fakeOnline or better yet _impersonateOnline
|
|
|
|
|
A guy bought a bootleg Sunton 4.3" inch off AliExpress. For those of you not familiar with it, it's basically a clearinghouse for chinese knockoffs and a good source of hard to find electronics, even if it's sketchy as hell.
Anyway, he couldn't get the display working, because the thing doesn't advertise what it knocked off, did not come with schematics, nor code.
Based on little more than an image and the name of the LCD controller it used I was able to find the sunton device it was clearly a copy of.
Then we got the display working with the Sunton code.
Now it uses a different touch controller IC than the real mccoy so I'm having the guy run an I2C scan to find out the address the device reports on.
From there I will basically work my way backward to a touch driver chip.
It feels a bit like old school hacking.
Check out my IoT graphics library here:
https://honeythecodewitch.com/gfx
And my IoT UI/User Experience library here:
https://honeythecodewitch.com/uix
|
|
|
|
|
I wouldn't put too much effort into it - in my experience, Chinese electronics have the same shelf life as cheesecake ...
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
It depends on the vendor honestly.
Makerfabs makes quality kit. So does Espressif.
Check out my IoT graphics library here:
https://honeythecodewitch.com/gfx
And my IoT UI/User Experience library here:
https://honeythecodewitch.com/uix
|
|
|
|
|
The vendor of the electronics or the vendor of the cheesecake?
cheers
Chris Maunder
|
|
|
|
|
Cheesecake? 
The electronics definitely.
Check out my IoT graphics library here:
https://honeythecodewitch.com/gfx
And my IoT UI/User Experience library here:
https://honeythecodewitch.com/uix
|
|
|
|
|
Griff posted "in my experience, Chinese electronics have the same shelf life as cheesecake ..." and you said "It depends on the vendor honestly" and then I was thinking about cheesecake and relative shelf life.
Because I'm hungry and would kill for a decent cheesecake about now. But it would really depend on the vendor...
cheers
Chris Maunder
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
