|
Wow! You have such a myopic view of what's going on.
I don't think so. Let's revisit this one more time.
So I'm supposed to put all code that modifies a control into wrapper code that calls invoke and this wrapper code ends up being a conditional test to see if invoke is required and then recursively calling the same function thru a special delegate that is created just for that invoke call. I've repeated my example code below:
private delegate void RefreshLbxDg8();
private RefreshLbxDg8 _refreshLbx;
...
_refreshLbx = RefreshLbx;
...
public void RefreshLbx()
{
if (lbxQuotes.InvokeRequired)
{
lbxQuotes.Invoke(_refreshLbx);
}
else
{
lbxQuotes.DataSource = null;
lbxQuotes.DataSource = _quotes;
}
}
All this is required in order that the code gets executed on the GUI thread. Now, I'm simply updating a textbox with a sample (number). Nothing else.
I guess I could have stated my point better: yes, it is an asynchronous system and it is *possible* that a WM_PAINT would get processed while the textbox text is changing. I am aware of this. My complaint was that .NET designers used this sledgehammer solution to prevent any presentation rendering mishap (ie. my number is rendered while it is changing) by constraining all code to execute on the GUI thread. So this means that for every single interaction with any control - and there's a LOT of them, I'm supposed to write wrapper code around everything, and this wrapper code involves defining and creating delegates and rewriting all my code to include a conditional statement which tests for this invokability.
AND YOU'RE FINE WITH THIS.
Me, I think this is a horrible and terribly primitive solution and design. It would be better to leave me with using SendMessage() to inject my action into the GUI's Message-Loop.
And that's not to mention that the compiler gave no warnings, there was no runtime error, the code SILENTLY failed, and I had no idea that the timer implemented its actions with a (hidden) separate thread.
I am LESS than impressed.
|
|
|
|
|
Liek I said, it's a limitation in Windows Win32 since the dark arges, not .NET.
If this bugs the crap out of you, go write code for Linux.
|
|
|
|
|
A SendMessage() call works between threads... at least I thought it did. Thus I thought this was a .NET constraint.
If it's not a .NET new constraint then I just learned something.
Dave Kreskowiak wrote: go write code for Linux.
No! (so there)
|
|
|
|
|
rbsbscrp wrote: No! (so there)
Then quit bitching...
|
|
|
|
|
Dave Kreskowiak wrote: Then quit bitching...
Your discourse is not civil, but constant.
|
|
|
|
|
Let it go. It's like looking at a game who will have the last word on a subject.
FWIW; Linux/Mono would react exactly the same.
|
|
|
|
|
rbsbscrp wrote: Me, I think this is a horrible and terribly primitive solution and design.
Microsoft had the same idea; that's why the threaded version of the timer isn't in the WinForms designer-toolbox. The Timer from the toolbox simply raises events on the GUI-thread. No syncing required.
Bastard Programmer from Hell 
If you can't read my code, try converting it here[^]
|
|
|
|
|
Hmmmmm... I am using a System.Windows.Forms.Timer. Isn't that the one you are referring to that doesn't use a separate thread? Okay, now I'm confused. My code works if i execute it from a button. It works if I invoke it thru a delegate. Other than that nothing happens.
|
|
|
|
|
Let me add to the confusion; there's not two, but three[^] timers available.
So, which timer is it? 
..and there's a picture in that article of a second timer in the toolbox. Nice to see my previous post invalidated that quickly.
Bastard Programmer from Hell
If you can't read my code, try converting it here[^]
|
|
|
|
|
Wow, wonderful article.
Again, the timer that I'm using is the System.Windows.Forms.Timer one (I'm cut&pasting this from the <class>.Designer.cs file - and I don't see any other timers)
Thx for the article. I'll look at all this in a bit.
|
|
|
|
|
rbsbscrp wrote: the timer that I'm using is the System.Windows.Forms.Timer one
That one runs on the UI thread, and doesn't need any invocations to update controls created.
using System;
using System.Windows.Forms;
using System.Threading;
namespace WindowsFormsApplication1
{
public partial class Form1 : Form
{
public Form1()
{
InitializeComponent();
Thread.CurrentThread.Name = "UI Thread";
}
private void timer1_Tick(object sender, EventArgs e)
{
Text = String.Format("{0}, {1}", Thread.CurrentThread.Name, Environment.TickCount);
}
}
}The timer is based on the Windows message-pump;
protected override void WndProc(ref Message m)
{
if (m.Msg == 275)
{
if ((int)m.WParam == this._timerID)
{
this._owner.OnTick(EventArgs.Empty);
return;
}
}
else
{
if (m.Msg == 16)
{
this.StopTimer(true, m.HWnd);
return;
}
}
base.WndProc(ref m);
}
Bastard Programmer from Hell
If you can't read my code, try converting it here[^]
|
|
|
|
|
I know that this is a bit late, but have you ever considered using the BindingList(Of T) Class[^] instead? It will notify any changes to the list so that the bound control can take action.
|
|
|
|
|
I'm not familiar with BindingList. I took a quick look at the link but am unsure of its benefit here. Thx for the heads up, though.
|
|
|
|
|
Perhaps I misunderstood your problem, I thought that it was that the ListBox was not automatically reflecting changes to the underlying DataSource List. The BindingList raises events that would cause the ListBox to update automatically when the List changes.
Here is a simple example. New WinForm project with two buttons and two ListBoxes. Clicking Button1 adds items to the underlying lists, but only the ListBox with the BindingList as the DataSource is update. Clicking Button2 tells ListBox1 to Refresh it's data.
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Text;
using System.Windows.Forms;
namespace WindowsFormsApplication1
{
public partial class Form1 : Form
{
public Form1()
{
InitializeComponent();
}
List<int> L1 = new List<int>();
BindingList<int> L2 = new BindingList<int>();
private void Form1_Load(object sender, EventArgs e)
{
L1.Add(1);
L1.Add(2);
L2.Add(11);
L2.Add(22);
listBox1.DataSource = L1;
listBox2.DataSource = L2;
this.button1.Click += new System.EventHandler(this.button1_Click);
this.button2.Click += new System.EventHandler(this.button2_Click);
}
private void button1_Click(object sender, EventArgs e)
{
L1.Add(3);
L2.Add(33);
}
private void button2_Click(object sender, EventArgs e)
{
((CurrencyManager)this.BindingContext[L1]).Refresh();
}
}
}
|
|
|
|
|
Try This :
public partial class Form1 : Form
{
public Form1()
{
InitializeComponent();
List<KeyValuePair<int, string>> data = new List<KeyValuePair<int, string>>();
KeyValuePair<int, string> item;
for (int i = 1; i < 10; i++)
{
item = new KeyValuePair<int, string>(i, "Item " + i.ToString());
data.Add(item);
}
listBox1.DataSource = data;
listBox1.DisplayMember = "Value";
listBox1.ValueMember = "Key";
}
private void button1_Click(object sender, EventArgs e)
{
KeyValuePair<int, string> item = new KeyValuePair<int,string>(11,"Item 11");
List<KeyValuePair<int, string>> data = (List<KeyValuePair<int, string>>)listBox1.DataSource;
data.Add(item);
listBox1.DataSource = null;
listBox1.DataSource = data;
}
}
|
|
|
|
|
Kuel. I like that you can use a List<> of Key/Values for a ListBox. Did not know that. Then can use the DataMember, ValueMember flexibility. Thx. However...
You are executing the update from a button_click Method - thus the code is executed on the UI thread - thus it will work. My problem is that I am executing from a timer handler - because I need the update at regular intervals (taking samples) - thus the handler is on a different thread and thus, when executed, silently does absolutely nothing.
Thx for the code. Educational. (and 'yes' I got it working)
|
|
|
|
|
I have two objects, PriceRule and WeekDay, and PriceRule has a DayId column I have bound to a ComboBox column in a DataGridView. When I load the grid, if DayId is null, the combo is blank, but as soon as I drop the combo down, I have to select a day. No problem, I can inject an extra empty string day into the combo's data source, but the Id property of WeekDay is not nullable, so I need to do something as clumsy and stupid as insert a false day with Id of -1.
How do I catch this -1 and make it null before saving, and vice versa, catch a null DayId and make it -1 when loading?
Is there no other way to do what is a bloody common task that MS clearly isn't capable of handling themselves?
|
|
|
|
|
I'm creating an user control like treeView, in this control, I want to put a button to let my user control hide/show in Owner form.
how could I do?
thanks
|
|
|
|
|
|
Just delete it in C# forum
|
|
|
|
|
|
kenmaMoon wrote: how could I do?
Toggle the Visible property?
The problem is a logical one; if you hide the control containing the button to toggle visibility, the user will not be able to make it visible again, as the button that toggles it is invisible too.
Bastard Programmer from Hell 
If you can't read my code, try converting it here[^]
|
|
|
|
|
thanks for your reply.
yes, but the button is in the userControl, next time I want the user control shown by click the button.
|
|
|
|
|
kenmaMoon wrote: yes, but the button is in the userControl, next time I want the user control shown by click the button.
Re-read what I wrote; the button will be invisible if you hide the container it's in. You cannot click an invisible button.
Either put the button somewhere else and have it toggle the Visible property, or put the button somewhere on location (0,0) and resize the control to shrink to the size of the button.
Third, best option; throw the button and the control you wish to show/hide on a new usercontrol.
Bastard Programmer from Hell
If you can't read my code, try converting it here[^]
|
|
|
|
|
I am working on a heavily used winform C# application.
I have a user control, that has 3 textboxes and it can contain another user control. user can add n number of main user control on the form. due to this, if the user adds more than 20 controls, after the 20th control, the UI doesnt show anything. It is not giving any exception, its simply not drawing the controls? My application is not exceeding GDI objects
Also the textbox is using WPF textbox.
All suggestions welcome. Thanks.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
