Database

16-Sep-05 12:08

Hi,

I have a table on SQL Server where one column allows Null values (docMName) and I'm trying to perform a like query using one parameter. When executed the query fails to include rows with Null values for the docMName column. Is there a way to include these missing rows? Any help would be greatly appreciated.

SELECT docIndex, docLName, docFName, docMName
FROM tblStaffPhysicians
WHERE (docFName + ' ' + docMName + ' ' + docLName LIKE '%' + ? + '%')

-- modified at 18:09 Friday 16th September, 2005

turbochimp16-Sep-05 17:39

16-Sep-05 17:39

I'm not really sure why you'd create a search like the this intentionally. It's going to wreak havoc on any indexes the execution planner might have taken advantage of.

Why not just use separate arguments for the first, middle and last names?

SELECT <br />
    docIndex, docLName, docFName, docMName<br />
FROM <br />
    tblStaffPhysicians<br />
WHERE<br />
    (docFName LIKE '%' + ? + '%') AND<br />
    ((docMName IS NULL) OR (docMName LIKE '%' + ? + '%')) AND<br />
    (docLName LIKE '%' + ? + '%')

If there is a compelling reason why the statement must use a single parameter value, there are other ways of approaching this, but since you're concatenating a string with spaces right in the SQL statement, it seems like it would be equally sensible to split the parameter value in code on the location(s) of spaces and provide multiple parameters to the command.

Hope this helps,

The most exciting phrase to hear in science, the one that heralds the most discoveries, is not 'Eureka!' ('I found it!') but 'That's funny...’

rich_wenger17-Sep-05 1:18

17-Sep-05 1:18

Thank you for responding to my query. When I setup the stored procedure for the application I was unaware that there would be a Null value issue. This is just one view on the data and the concept here was to provide a single textbox to search. I'd rather rewrite the stored procedure than the application if possible. Thanks again.

rich_wenger17-Sep-05 3:21

17-Sep-05 3:21

This was the reply I got Tom on the Microsoft SQL Forum and it works like a charm.

Thomas A. Moreau, BSc, PhD, MCSE, MCDBA
SQL Server MVP
Columnist, SQL Server Professional
Toronto, ON Canada
www.pinpub.com

Toms Code=================================================

SELECT docIndex, docLName, docFName, docMName
FROM tblStaffPhysicians
WHERE (docFName + ' ' + ISNULL(docMName, '') + ' ' + docLName LIKE '%' + ? + '%')

turbochimp17-Sep-05 5:56

17-Sep-05 5:56

So, if you have a first name and last name, but no middle name in one of your rows, and a user enters text of the form [first name]<space>[last name], how exactly is that going to work, since you will be comparing against a concatenated string value of [first name]<space>''<space>[last name]?

I would say that the application really does need to change, or you need to make your stored procedure a little smarter about how the comparison string is concatenated (basically, smarter about where to insert spaces).

Good luck,

The most exciting phrase to hear in science, the one that heralds the most discoveries, is not 'Eureka!' ('I found it!') but 'That's funny...’

turbochimp17-Sep-05 5:36

17-Sep-05 5:36

The example you gave did not look like a stored procedure. It looked like a text SQL command. Stored procedures don't use wildcards (?) as parameter tokens.

If you would like to provide the stored procedure source, I will try to help you. I'd prefer to see what you've got versus rewriting something and missing some behavioral nuance.

The most exciting phrase to hear in science, the one that heralds the most discoveries, is not 'Eureka!' ('I found it!') but 'That's funny...’

rich_wenger18-Sep-05 14:49

18-Sep-05 14:49

Sorry, just got back in town; here is the stored procedure. Looks like you're right, it doesn't pull if I query both a First and Last name.

SET QUOTED_IDENTIFIER ON
GO
SET ANSI_NULLS ON
GO

CREATE PROCEDURE ia.SP_StaffPhysicianSelectCommand
(
@Param2 varchar(35)
)
AS
SET NOCOUNT ON;

SELECT docIndex, docLName, docFName, docMName FROM dbo.tblStaffPhysicians
WHERE (docFName + ' ' + ISNULL (docMName, '') + ' ' + docLName LIKE '%' + @Param2 + '%')
ORDER BY docLName, docFName

GO
SET QUOTED_IDENTIFIER OFF
GO
SET ANSI_NULLS ON
GO

-- modified at 20:49 Sunday 18th September, 2005

turbochimp18-Sep-05 18:06

18-Sep-05 18:06

Something like the following would work while preserving some benefit from any indices on the table columns and avoiding the double-space problem you'll encounter with the short version you're using now.

The procedure below parses the name provided as follows:
1. Everything from the start of the string to the position of the first space is considered the first name.
2. Everything from the position of the first space to the position of the second space is considered the middle name.
3. Everything from the position of the second space to the end of the string is considered the last name.

There are obvious issues with even the long version I'm attaching here. For instance, with names that include spaces (e.g. 'Jack Van Horn'). This name will cause problems with either version of the stored procedure; in the version you're using, if no middle name is stored in the database, you'll get the double-space issue, and in my version, 'Van' will get chosen as the middle name, and 'Horn' as the last which will lead to the same conclusion - possibly no returned records.
I don't know how critical this search mechanism is to your users, but I really would suggest looking at using a different solution for finding these names. One possibility would be to just do away with using the middle name in the search altogether, and having a new (calculated) column in your table representing First + ' ' + Last names, then just search on that, or do an edit distance algorithm or something.
Anyway, here's another way to do it, as promised:

<code>
CREATE PROCEDURE ia.SP_StaffPhysicianSelectCommand
(
@Param2 varchar(35)
)
AS
SET NOCOUNT ON;

-- Declare local variables
declare @firstName nvarchar(35)
declare @middleName nvarchar(35)
declare @lastName nvarchar(35)
declare @count int
declare @pos int
declare @oldPos int
declare @Param2 nvarchar(35)

-- Initialize local variables
set @oldPos = 0
set @count = 0
set @Param2 = 'a c'

-- Parse the name parameter
set @pos = charindex(' ', @Param2)
while (@pos > 0)
begin
	set @count = @count + 1
	if (@count <= 2)
		begin
			if (@count = 1)
				-- First name
				set @firstName = substring(@Param2, @oldPos, @pos - @oldPos)
			else
				-- Middle name
				set @middleName = substring(@Param2, @oldPos, @pos - @oldPos)
		end
	else if (@count = 3)
		begin
	 		-- Last name
			set @lastName = right(@Param2, len(@Param2) - @oldPos + 1)
			break
		end

	-- Set a position marker and iterate
	set @oldPos = @pos + 1
	set @pos = charindex(' ', @Param2, @pos + 1)

	-- If there are no further spaces, but the end of the string
	-- has not been reached, place the remainder into the next 
	-- open slot
	if (@pos = 0 and @count < 3)
		begin
			if (@count = 1)
				set @middleName = right(@Param2, len(@Param2) - @oldPos + 1)
			else 
				set @lastName = right(@Param2, len(@Param2) - @oldPos + 1)
			set @count = @count + 1
		end
end

-- Evaluate the count: if only 2 words were found, 
-- assume they were a first and last name, adjut the 
-- values accordingly
if (@count = 2)
	begin
		set @lastName = @middleName
		set @middleName = null
	end

-- Finally, select the matching names
SELECT 
	docIndex, docLName, docFName, docMName 
FROM 
	dbo.tblStaffPhysicians
WHERE 
	docFName like '%' + @firstName + '%' AND
	((docMName is null and @middleName is null) OR (docMName like '%' + isnull(@middleName, '') + '%')) AND 
	docLName like '%' + @lastName + '%'	
ORDER BY docLName, docFName
</code>

The most exciting phrase to hear in science, the one that heralds the most discoveries, is not 'Eureka!' ('I found it!') but 'That's funny...’