|
Most of what FxCop looks for are design issues to try to stay compliant with what MS has outlined. Most of this is done just to make it so that a 3rd party using your library will know how to name stuff they wish to use (handy when you lack an IDE with intellisense  )
I wouldn't even bother replying if the comments generated weren't for your nBASS wrapper
leppie wrote:
also the extra processing (repeated get/sets) makes it inefficient.
The JITter is generally smart enough to inline small methods to make the call non-existant. I'm not sure what you mean by chaining properties though.
leppie wrote:
Add a constructor with a string parameter to custom exception 'BASSException'. Add a constructor with a string parameter and exception parameter to custom exception 'BASSException'. (cont'd)
These are for consistancy, but the framework uses the information provided by them to customize the exception dialogs.
leppie wrote:
Add a protected constructor with a SerializationInfo object parameter and a StreamingContext object parameter to custom exception 'BASSException'. // again why? if you dont need it, why clutter your code with useless code?
This might be needed; not by you or your code but by the framework. The 'might' depends on how remote debugging works, if it attempts to serialize exceptions to send to the debugger then this function won't work for your code.
The only other time it is used is for serialization of your exception object for use in remoting, but I can't see your library being used in that situation 
leppie wrote:
The type name 'Error' conflicts in whole or part with reserved keyword 'Error'. // reserved????
Error is a reserved keyword in VB.NET
leppie wrote:
Sign 'nBASS' with a strong name key. // not neccesary
Yes neccesary! For an example, create an application that is strong named and add a reference to nBASS, now try to build the application. You'll get an error (which stops the build) saying that nBASS isn't signed.
leppie wrote:
Add a GC.KeepAlive(this) to the method 'Void Stop()'.
The GC.KeepAlive method will hold a reference to the object passed in, so that it doesn't get collected prematurely.
I don't know the context in which this report is generated but for example you would use this to keep a reference to a delegate when you pass it to a P/Invoke'd method. Unless you use methods/properties of the delegate after the unmanaged method is done using it, the GC may see that the delegate isn't referenced anymore so it could perform a collection...invalidating your delegate and possibly doing bad things in the unmanaged function.
James
"And we are all men; apart from the females." - Colin Davies
|
|
|
|
|
Firstly, Thanx for your time James
James T. Johnson wrote:
The JITter is generally smart enough to inline small methods to make the call non-existant. I'm not sure what you mean by chaining properties though.
myobject.User.Name.Surname = "Smith";
where the last 3 are properties. Is this bad? I prefer to steer clear as (like this example) value types dont seem to work...
Altough this does work (making objects public):
myobject.user.name.surname = "Smith";
OK this is not real code, so I didnt test it, but I have seen that there IS a difference between the 2, even though the properties are only basic get/sets.
James T. Johnson wrote:
The only other time it is used is for serialization of your exception object for use in remoting, but I can't see your library being used in that situation
WOW! Remote sound objects Although a "media" server ....nah to complicated
James T. Johnson wrote:
The GC.KeepAlive method will hold a reference to the object passed in, so that it doesn't get collected prematurely.
Isnt that what the whole IDisposable issue is about? How can the GC collect a object that is in unmananged space?
James T. Johnson wrote:
Error is a reserved keyword in VB.NET
DOPE!  I will change that for my VB.NET user (well I know of one).
James T. Johnson wrote:
Yes neccesary! For an example, create an application that is strong named and add a reference to nBASS, now try to build the application.
But why do I need to sign/strong name my application? I know it the "right" thing todo , but why? Speed? Security? Version tracking?
Thanx again
Give them a chance! Do it for the kittens, dear God, the kittens!
|
|
|
|
|
leppie wrote:
I prefer to steer clear as (like this example) value types dont seem to work...
The reason this doesn't work with value types is because you are making changes to copies of what the first two properties hold.
This is a hard problem to wrap your head around because what happens is that every time a get is called on a value type based property a copy of what is stored is returned. So when you chain them together you wind up with (using your example):
myobject.(get)User.(get)Name.(set)Surname
So you've made a change to a copy of the Name type which was a copy of the User type.
When you don't use properties you are accessing the values directly, so no copies are made at all.
leppie wrote:
Isnt that what the whole IDisposable issue is about?
No; IDisposable addresses managed code using unmanaged objects; the issue that I think is at hand is unmanaged code using managed objects (roles are switched).
When unmanaged code has a reference to a managed object the GC has no idea what happens to it; if additional references are made or if it doesn't even use it. That is why you use GC.KeepAlive, so that even if your code doesn't maintain a reference to the object, the GC will.
Note that I haven't looked at the code in question so I'm not sure why you had that issue reported; I just assumed the common case
leppie wrote:
But why do I need to sign/strong name my application?
Mainly security.
Its not a strong form of security; it only ensures that the assembly hasn't been modified since it was signed. But if you know the Public Key token of the person who signed the assembly you can use that as a means of verifying that it was signed by the same person; assuming the private/public key pair hasn't been stolen.
If you browse to %WINDOWSDIR%\assembly on your computer you should see the contents of the global assembly cache; which thanks to the Fusion shell extension also displays among other things the public key token. You can also see that most of the assemblies from Microsoft have the same public key token.
James
"And we are all men; apart from the females." - Colin Davies
|
|
|
|
|
Thanx
James T. Johnson wrote:
Its not a strong form of security; it only ensures that the assembly hasn't been modified since it was signed.
I know what u mean now . It happened a few months back, when i used an unsigned compiled assembly (no source available, well not to the project). It threw an exception and showed me the code of the assembly, without realising it , I modified the assembly to correct the problem. And I was total amazed to seen my changes was reflected, even though I never opened a source file from the assembly and recompiled it. I was very nice in this case, but I can see the security problem, especially in my case.
|
|
|
|
|
How can I display popup menu when I click on a items of list view?
When I overriden Click event of list view,it occures for both right click and left click.How can I manage it only for right click?
Mazy
"If I go crazy then will you still
Call me Superman
If I’m alive and well, will you be
There holding my hand
I’ll keep you by my side with
My superhuman might
Kryptonite"Kryptonite-3 Doors Down
|
|
|
|
|
You have two options :
The first is done by using the VS.NET Toolbox window and produces code like this :
this.ContextMenu = new System.Windows.Forms.ContextMenu();
Other, in your listview click handler :
if (this.MouseButtons==MouseButtons.Right)
System.Windows.Forms.ContextMenu.Show (this, this.MousePosition);
MS quote (http://www.microsoft.com/ddk) : As of September 30, 2002, the Microsoft® Windows® 2000 DDK, the Microsoft Windows 98 DDK, and the Microsoft Windows NT® 4.0 DDK will no longer be available for purchase or download on this site.
|
|
|
|
|
Thanks.
Mazy
"If I go crazy then will you still
Call me Superman
If I’m alive and well, will you be
There holding my hand
I’ll keep you by my side with
My superhuman might
Kryptonite"Kryptonite-3 Doors Down
|
|
|
|
|
Aloha everyone...I have a question:
How can I implement auto-updating to my app? I have created a simple TCP/IP application and I would like the client to be able to get the newest version from the server and overwrite itself with the new version.
Obviously this will create problems with trying to overwrite a file in use, so how do you do it?
- Does .NET provide built in "shadow copying"? (I know ASP.NET does)
- Does Windows provide a service to auto-copy a file once an application closes?
- Is there some black-book trick I am unaware of???
Any help would be really appreciated!
|
|
|
|
|
BITS
"When the only tool you have is a hammer, a sore thumb you will have."
|
|
|
|
|
|
|
Thanks, but I'm not sure this does what I need. I have no problem getting the file to the client machine. I have written a simple TCP/IP system to download any size file from the server to the client.
The problem I am trying to figure out is how am I going to replace my application .EXE while it is running? Or rather, how do I smoothly exit the program, get the copy done and re-load (without user interaction).
I only ask because I see other programs doing this and it is very nice
|
|
|
|
|
|
floydboy58 wrote:
The problem I am trying to figure out is how am I going to replace my application .EXE while it is running? Or rather, how do I smoothly exit the program, get the copy done and re-load (without user interaction).
Have a look at System.Diagnostics.Process class. It's easy enough to run a "updater" app to close the process and restart an instance of of the main app.
Else forcefully close the program after an update, forcing the user to open the newly updated one.
Third option is to go the AppDomain way, but that can be scary (to me anyways )
Hope this helps
|
|
|
|
|
Have your application shell out to another application (then die) that is responsible for downloading the newer version then shelling out to get the new exe running.
My only question now is.... how do you update the updater?
|
|
|
|
|
Ray Cassick wrote:
My only question now is.... how do you update the updater?
I have an auto-update app that is a Windows Installer app.
I have a version check exe, that compares the version on my website every time it is invoked and if there is no new version, ShellExecutes the main app exe.
else, it ShellExecutes the link to setup.exe on my site.
Now when the setup is running, the app and the auto update is not in use and can be updated.
Thomas
modified 29-Aug-18 21:01pm.
|
|
|
|
|
|
is there any difference between IntPtr.Zero
and AfxGetInstanceHandle( ) ?
in what dll AfxGetInstanceHandle( ) is defiend ?
r00d0034@yahoo.com
|
|
|
|
|
am i dreaming, or is this the right code to get an equivilant HANDLE object for a process.
IntPtr tknPtr = IntPtr.Zero;
Process pr = Process.GetCurrentProcess();
IntPtr ptr = pr.Handle;
OpenProcessToken(pr.Handle, 0, out tknPtr); This is what i am using, but when i get the last error with Marshal.GetLastWin32Error() [after calling AdjustTokenPrivileges) it is returning an error code of 6 which i think is ERROR_INVALID_HANDLE.
In theory, the above code should get a handle to the processes tokens, but im not sure as i dont fully understand it all.
[and for those of you who are tired of these posts, i am very sorry, but this isnt just about me and my little method anymore, this is WAR against Advapi32.dll, and the depriving of privileges!  ]
 Email: theeclypse@hotmail.com URL: http://www.onyeyiri.co.uk
"All programmers are playwrights and all computers are lousy actors."
|
|
|
|
|
Nnamdi Onyeyiri wrote:
OpenProcessToken(pr.Handle,0, out tknPtr);
Now I have told you THAT cannot be ZERO.
You can see from the follow that 0 is not valid:
#define TOKEN_ASSIGN_PRIMARY (0x0001)
#define TOKEN_DUPLICATE (0x0002)
#define TOKEN_IMPERSONATE (0x0004)
#define TOKEN_QUERY (0x0008)
#define TOKEN_QUERY_SOURCE (0x0010)
#define TOKEN_ADJUST_PRIVILEGES (0x0020)
#define TOKEN_ADJUST_GROUPS (0x0040)
#define TOKEN_ADJUST_DEFAULT (0x0080)
#define TOKEN_ADJUST_SESSIONID (0x0100)
#define TOKEN_ALL_ACCESS_P (STANDARD_RIGHTS_REQUIRED |\
TOKEN_ASSIGN_PRIMARY |\
TOKEN_DUPLICATE |\
TOKEN_IMPERSONATE |\
TOKEN_QUERY |\
TOKEN_QUERY_SOURCE |\
TOKEN_ADJUST_PRIVILEGES |\
TOKEN_ADJUST_GROUPS |\
TOKEN_ADJUST_DEFAULT )
#if ((defined(_WIN32_WINNT) && (_WIN32_WINNT > 0x0400)) || (!defined(_WIN32_WINNT)))
#define TOKEN_ALL_ACCESS (TOKEN_ALL_ACCESS_P |\
TOKEN_ADJUST_SESSIONID )
#else
#define TOKEN_ALL_ACCESS (TOKEN_ALL_ACCESS_P)
#endif
#define TOKEN_READ (STANDARD_RIGHTS_READ |\
TOKEN_QUERY)
#define TOKEN_WRITE (STANDARD_RIGHTS_WRITE |\
TOKEN_ADJUST_PRIVILEGES |\
TOKEN_ADJUST_GROUPS |\
TOKEN_ADJUST_DEFAULT)
#define TOKEN_EXECUTE (STANDARD_RIGHTS_EXECUTE)
BTW, does Marshal.GetLastWin32Error() do the same as the GetLastError() in the Win API?
|
|
|
|
|
|
Nnamdi Onyeyiri wrote:
well this is what msdn says:
This method exists because it is not safe to make a direct platform invoke call to GetLastError to obtain this information. The common language runtime might have made internal calls to API's that overwrite the operating system maintained GetLastError.
Hmm nice
Nnamdi Onyeyiri wrote:
ok, now, if i was a computer, im sure all that code would make sense to me
That would be ideal for a flagged enum, lookout for them in the headers, its much better to use enums than to define endless constants. This what makes a strongly-typed language so nice I tried c++ once to test the intellisense, guess what it gave me a list of a few thousand different functions and constants. Alt - F4 did the job 
So you would write it as (you can copy, its correct ):
[Flags]
public enum TokenAccessRights
{
ASSIGN_PRIMARY =(0x0001),
DUPLICATE =(0x0002),
IMPERSONATE =(0x0004),
QUERY =(0x0008),
QUERY_SOURCE =(0x0010),
ADJUST_PRIVILEGES =(0x0020),
ADJUST_GROUPS =(0x0040),
ADJUST_DEFAULT =(0x0080),
ADJUST_SESSIONID =(0x0100),
ALL_ACCESS_P =(STANDARD_RIGHTS_REQUIRED |
ASSIGN_PRIMARY |
DUPLICATE |
IMPERSONATE |
QUERY |
QUERY_SOURCE |
ADJUST_PRIVILEGES |
ADJUST_GROUPS |
ADJUST_DEFAULT ),
ALL_ACCESS =(ALL_ACCESS_P |
ADJUST_SESSIONID ),
READ =(STANDARD_RIGHTS_READ |
QUERY),
WRITE =(STANDARD_RIGHTS_WRITE |
ADJUST_PRIVILEGES |
ADJUST_GROUPS |
ADJUST_DEFAULT),
EXECUTE =(STANDARD_RIGHTS_EXECUTE),
}
[Flags]
public enum AccessMask
{
DELETE =(0x00010000),
READ_CONTROL =(0x00020000),
WRITE_DAC =(0x00040000),
WRITE_OWNER =(0x00080000),
SYNCHRONIZE =(0x00100000),
STANDARD_RIGHTS_REQUIRED =(0x000F0000),
STANDARD_RIGHTS_READ =(READ_CONTROL),
STANDARD_RIGHTS_WRITE =(READ_CONTROL),
STANDARD_RIGHTS_EXECUTE =(READ_CONTROL),
STANDARD_RIGHTS_ALL =(0x001F0000),
SPECIFIC_RIGHTS_ALL =(0x0000FFFF),
}
|
|
|
|
|
|
Nnamdi Onyeyiri wrote:
errr thanks, but i dont need that i need my code to work
You will need that too make your code work!* You will need to redefine your function as (this way u cannot go wrong (well mostly)).
[DllImport("Advapi32.dll")]
static extern bool OpenProcessToken(IntPtr ProcessHandle,
[MarshalAs(UnmanagedType.U4)] TokenAccessRight DesiredAccess,
out IntPtr TokenHandle);
* Found in the remarks, overlooked it a couple of times 
Windows XP Professional: If the computer is joined to a workgroup and the "Force network logons using local accounts to authenticate as Guest" policy is enabled, the function fails. Note that this policy is enabled by default for a computer running Windows XP Professional that is joined to a workgroup.
|
|
|
|
|
How can I get name and number of NT services that installed on a machine in my program?
Mazy
"If I go crazy then will you still
Call me Superman
If I’m alive and well, will you be
There holding my hand
I’ll keep you by my side with
My superhuman might
Kryptonite"Kryptonite-3 Doors Down
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
