|
The problem you have is that you don't assign anything to _Gold unless value is 30. This is because you do _Gold = value inside the if statement. Move this line outside the if block in your setter and it should start working.
This space for rent
|
|
|
|
|
Thanks Pete.
That was easier to fix than I thought it might be.
Brian
|
|
|
|
|
Not a continuous loop, but an "unbounded recursion" - similar thing, but the later will blow the stack at some point.
Just to add to what Pete says, the naming conventions say that a backing field should have the same name as the property it is associated with, but prefixed with underscore:
private int _MyProperty;
public int MyProperty
{
get { return _MyProperty; }
set { _MyProperty = value; }
}
Sent from my Amstrad PC 1640
Never throw anything away, Griff
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
I twitch when I see a private backing field that has an uppercase letter following an initial underscore : I'm sorry.
However, when I consider this example is still current in the MS docs [^]:
public enum Color {...}
public class Control {
public Color Color { get {...} set {...} }
} I throw up.
Remember the daze when common practice was to use: _mSomeName ?
«Where is the Life we have lost in living? Where is the wisdom we have lost in knowledge? Where is the knowledge we have lost in information?» T. S. Elliot
|
|
|
|
|
Thanks everyone who has helped me with this code problem.
I now have a way of sending a value to a class, have the class change the value (if the test passes) and have the class return the result (which is displayed on the form.
Brian
|
|
|
|
|
Do keep in mind that MS Guidelines suggest using Properties only as gateways to internal fields [^] Quote: In general, methods represent actions and properties represent data. Properties are meant to be used like fields, meaning that properties should not be computationally complex or produce side effects. When it does not violate the following guidelines, consider using a property, rather than a method, because less experienced developers find properties easier to use. not to produce 'side-effects" by way of internal computation in the setter and/or getter ... and advocates using methods to replace any internal computation.
While I feel "relaxed" about some computation in a Property setter/getter, there are folks who have strong opinions this is bad practice. Another argument against computation in Properties is that end-users of your code may not be aware of the "cost" of access.
Of course, you can implement INotifyPropertyChanged as a "trigger" for some external action.
«Where is the Life we have lost in living? Where is the wisdom we have lost in knowledge? Where is the knowledge we have lost in information?» T. S. Elliot
modified 30-May-19 5:10am.
|
|
|
|
|
Hi Bill.
You wrote that
INotifyPropertyChanged can be used as a "trigger" for some external action.
Can you use this to auto add text to a rich text window on a form when you change the string variable in a class that the rich text window is connected to?
Brian
|
|
|
|
|
Brian_TheLion wrote: Can you use this to auto add text to a rich text window on a form when you ... Theoretically, given the right structure, and valid references to run-time objects, the handler(s) that subscribe to the event can do anything any other method can do.
Take a look at the examples here: [^]
«Where is the Life we have lost in living? Where is the wisdom we have lost in knowledge? Where is the knowledge we have lost in information?» T. S. Elliot
modified 30-May-19 11:01am.
|
|
|
|
|
@Brian_TheLion good article on INotifyPropertyChanged: [^]
«Where is the Life we have lost in living? Where is the wisdom we have lost in knowledge? Where is the knowledge we have lost in information?» T. S. Elliot
|
|
|
|
|
Using Properties - C# Programming Guide | Microsoft Docs
The Master said, 'Am I indeed possessed of knowledge? I am not knowing. But if a mean person, who appears quite empty-like, ask anything of me, I set it forth from one end to the other, and exhaust it.'
― Confucian Analects
|
|
|
|
|
Gerry, I'm grateful for any knowledge I receive.
Brian
|
|
|
|
|
Hello,
I'm on WinForms and my window is FormBorderStyle.None. If the window is maximized and I drag the taskbar from the bottom to the side, the maximized window will not be adjusted to the new size. Events like LocationChanged, SizeChanged or Resize doesn't fire. What can I do?
Greetings
Ken
|
|
|
|
|
|
Hi Eddy,
this looks like a solution for WPF. But i'm on WinForms.
Greetings
|
|
|
|
|
It looks? So you stopped reading eh?
Bastard Programmer from Hell
If you can't read my code, try converting it here[^]
"If you just follow the bacon Eddy, wherever it leads you, then you won't have to think about politics." -- Some Bell.
|
|
|
|
|
Sorry, I know AppBar in WPF-Context. I took another look at it and compiled it. Looks promising.
|
|
|
|
|
First: the guidelines for Win apps warn against forcing the users to use some "fixed" style of UI: whether taskbar(s) auto-hide, and, where they are located, are usually left up to the user. Exceptions to this are "kiosk" apps, and single-purpose machines deliberately configured a certain way. Think long and hard before locking your user into a certain window configuration. Or, think about creating your own virtual desktop [^].
If you are showing a WinForm with 'WindowState = FormWindowState.Maximized, it will fill the screen completely, covering any TaskBars that are not hidden.
So, I do not understand your question ... yet.
Do you have experience with interop in C# using the Shell ... i.e., using WndProc, using P/Invokes ?
«Where is the Life we have lost in living? Where is the wisdom we have lost in knowledge? Where is the knowledge we have lost in information?» T. S. Elliot
modified 28-May-19 23:36pm.
|
|
|
|
|
Hi Bill,
"
If you are showing a WinForm with 'WindowState = FormWindowState.Maximized, it will fill the screen completely, covering any TaskBars that are not hidden. "
I've solved this problem already with
private void frmMain_Load(object sender, EventArgs e)
{
MaximizedBounds = Screen.FromHandle(Handle).WorkingArea;
WindowState = FormWindowState.Maximized;
}
But: My application doesn't receive any event, that informs about the movement of the TaskBar. If i set FormBorderStyle.Sizeable everything is OK.
Do you have experience with interop in C# using the Shell ... i.e., using WndProc, using P/Invokes ?
Yes, i have.
Greetings
|
|
|
|
|
Ken Guru wrote: If i set FormBorderStyle.Sizeable everything is OK. Please explain this further; it's "ok" because ? happens, or, because the user can ... ?
Does any issue arise if other apps have windows set to 'TopMost.
«Where is the Life we have lost in living? Where is the wisdom we have lost in knowledge? Where is the knowledge we have lost in information?» T. S. Elliot
|
|
|
|
|
Quote: I drag the taskbar from the bottom to the side
I think I did that once in the last 20 years.
The Master said, 'Am I indeed possessed of knowledge? I am not knowing. But if a mean person, who appears quite empty-like, ask anything of me, I set it forth from one end to the other, and exhaust it.'
― Confucian Analects
|
|
|
|
|
You don't know our users
|
|
|
|
|
@Ken-Guru I think I've found a way to get you somewhat there: this works for me in VS 2017 using .NET 4.7. I set the Form 'WindowState to 'Normal, and the 'StartPosition to 'Manual because ... those settings "worked."
I tried using the old P/Invokes ... FindWindow and IsWindowVisible ... to try to get the state of TaskBar visibility, but kept getting a 'visible result even when the TaskBar was hidden.
Hopefully, you can take it from here, and please do post any better technique you may come up with.
using System;
using System.ComponentModel;
using System.Drawing;
using System.Windows.Forms;
using Microsoft.Win32;
namespace MaxonTBarChange
{
public partial class Form1 : Form
{
public Rectangle AppBounds;
public Form1()
{
InitializeComponent();
AppBounds = Screen.PrimaryScreen.WorkingArea;
this.Bounds = AppBounds;
SystemEvents.UserPreferenceChanged += SystemEventsOnUserPreferenceChanged;
this.Closing += OnClosing;
}
private void OnClosing(object sender, CancelEventArgs e)
{
SystemEvents.UserPreferenceChanged -= SystemEventsOnUserPreferenceChanged;
}
private void SystemEventsOnUserPreferenceChanged(object sender, UserPreferenceChangedEventArgs e)
{
var bnds = Screen.PrimaryScreen.WorkingArea;
if (AppBounds != bnds)
{
AppBounds = bnds;
this.Bounds = AppBounds;
}
}
}
}
«Where is the Life we have lost in living? Where is the wisdom we have lost in knowledge? Where is the knowledge we have lost in information?» T. S. Elliot
modified 31-May-19 2:17am.
|
|
|
|
|
Can you send me dll code in how to download pdf file link in mail.
|
|
|
|
|
No.
Sent from my Amstrad PC 1640
Never throw anything away, Griff
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
The only code you get is the code YOU write.
We're not here to do your work for you.
modified 28-May-19 14:01pm.
|
|
|
|