C# Discussion Boards - CodeProject

15-Mar-06 4:57

I have created a class to hold some related data (ResultsOfTest). I am reading a record from an Access file, loading the data into the members of the ResultsOfTest class, then inserting into a database.

This works properly, except I am consuming massive amounts of memory. My understanding was the memory would be released when the new'ed object went out of scope (which should be at the end of the while loop). This doesn't seem to be the case, so I stuck in a garbage collection collect call every 1000 iterations. This doesn't seem to have any effect on the memory consumption.

while (readerAccess.Read())
{
	ResultsOfTest testResult = new ResultsOfTest();
	try
	{
		if (!readerAccess.IsDBNull(iTestIndex)) { testResult.TestID = Convert.ToDecimal(readerAccess.GetInt32(iTestIndex)); }
		if (!readerAccess.IsDBNull(iEmployeeIndex)) { testResult.EmployeeID = Convert.ToDecimal(readerAccess.GetInt32(iEmployeeIndex)); }
		if (!readerAccess.IsDBNull(iTestDateIndex)) { testResult.DateOfTest = readerAccess.GetDateTime(iTestDateIndex); }
		if (!readerAccess.IsDBNull(iReasonIndex)) { testResult.ReasonForTest = Convert.ToDecimal(readerAccess.GetInt32(iReasonIndex)); }
		if (!readerAccess.IsDBNull(iDeferredDateIndex)) { testResult.DeferredDate = readerAccess.GetDateTime(iDeferredDateIndex); }
		if (!readerAccess.IsDBNull(iReadDateIndex)) { testResult.ReadDate = readerAccess.GetDateTime(iReadDateIndex); }
		if (!readerAccess.IsDBNull(iResultIndex)) { testResult.TestResultCode = Convert.ToDecimal(readerAccess.GetInt32(iResultIndex)); }
		if (!readerAccess.IsDBNull(iCommentIndex)) { testResult.Comments = readerAccess.GetString(iCommentIndex); }
		iRecordsRead++;
	}
	catch (OleDbException odex)
	{
		logger.Error("Unable to read record from Access db. {0}", odex.ToString());
	}
	if (testResult.TestID > 0)
	{
		if (db.UpdateTestResults(ref testResult))
		{
			iRecordsWritten++;
		}
	}
	if ((iRecordsRead % 1000) == 0)
	{
		StatusScreen.SetStatus("Garbage collection in process...");
		GC.Collect();
	}
}

What can/should I do differently, so the program will release the un-needed memory?

Thanks,
Glenn

-- modified at 10:57 Wednesday 15th March, 2006 (placed pre inside the code marker)

Colin Angus Mackay15-Mar-06 6:02

Colin Angus Mackay

15-Mar-06 6:02

Glenn E. Lanier II wrote:
My understanding was the memory would be released when the new'ed object went out of scope (which should be at the end of the while loop). This doesn't seem to be the case, so I stuck in a garbage collection collect call every 1000 iterations. This doesn't seem to have any effect on the memory consumption.

Garbage collection occurs when it needs to. When objects go out of scope they mearly become available for garbage collection.

If you are looking at the memory in the Task Manager then it will be showing the amount it has reserved from the operating system, not the actual amount in use. There are a number of performance counters you can look at for .NET applications. They will give you a more accurate picture of what is going on.

ColinMackay.net
Scottish Developers are looking for speakers for user group sessions over the next few months. Do you want to know more?

Glenn E. Lanier II15-Mar-06 6:15

15-Mar-06 6:15

Colin Angus Mackay wrote:
If you are looking at the memory in the Task Manager then it will be showing the amount it has reserved from the operating system, not the actual amount in use. There are a number of performance counters you can look at for .NET applications. They will give you a more accurate picture of what is going on.

Such as?

I let this code run yesterday (without the GC.Collect()) on about 60000 records. I logged each update, and noticed that while I was getting > 1 insert/second initially, by record 20000 insert time was reduced (as was machine response time) and by the time I got to record 32000, I was getting an insert every two-three minutes. Task Manager showed this process was using ~485M of memory. As soon as I killed the process, memory usage (again, using task manager) dropped almost immediately. I started the import again (skipping the already imported records), and I saw similiar results.

I'm open to any suggestion(s) that will allow this code to run efficiently. Confused | :confused:

--G

Judah Gabriel Himango15-Mar-06 7:06

Judah Gabriel Himango

15-Mar-06 7:06

When you're done using the SqlDataReader, call Dispose() on it. This will release some unmanaged resources and may also allow some managed objects to eventually be freed. The same goes for your SqlCommand and your SqlConnection.

Another thing might be your call to db.UpdateTestResults(ref testResult). If you're storing your testResult somewhere, it won't be freed, obviously. So perhaps your large consumption of memory is due to having lots of ResultsOfTest objects lying around.

Go check out the CLR profiler[^], or use a tool like Ants Memory and Performance profiler[^].

Tech, life, family, faith: Give me a visit.
I'm currently blogging about: Moral Muscle
The apostle Paul, modernly speaking: Epistles of Paul

Judah Himango

Glenn E. Lanier II15-Mar-06 8:39

15-Mar-06 8:39

Judah Himango wrote:
When you're done using the SqlDataReader, call Dispose() on it. This will release some unmanaged resources and may also allow some managed objects to eventually be freed. The same goes for your SqlCommand and your SqlConnection.

I am disposing the OracleDataReader (and OracleCommand and OracleConnection). The only thing

Judah Himango wrote:
Another thing might be your call to db.UpdateTestResults(ref testResult). If you're storing your testResult somewhere, it won't be freed, obviously.

db.UpdateTestResults(ref testResult) simply builds the SQL (either insert or update), connects to the database, performs an ExecuteNonQuery, cleans up and returns.

Thanks for the links -- I'll check them out.

--G

Judah Gabriel Himango15-Mar-06 9:00

Judah Gabriel Himango

15-Mar-06 9:00

Ok, well if the reality of things is that you're allocating too many objects before the GC can collect them, you are certainly free to call GC.Collect(). It's not recommended as the GC supposedly adapts to its usage, but you're not the first case I've read where the GC has become too lazy.

Tech, life, family, faith: Give me a visit.
I'm currently blogging about: Moral Muscle
The apostle Paul, modernly speaking: Epistles of Paul

Judah Himango

Glenn E. Lanier II15-Mar-06 8:44

Re: How to print a C# form

15-Mar-06 8:44

Judah Himango wrote:
Go check out the CLR profiler

Working Link: http://www.microsoft.com/downloads/details.aspx?FamilyId=86CE6052-D7F4-4AEB-9B7A-94635BEEBDDA&displaylang=en
[^]

How to print a C# form

JuJAngel15-Mar-06 3:56

JuJAngel

15-Mar-06 3:56

i have a form containing labels pictures and user controls
how can i print the form containing them just like it appears

through my search i found JUST "How to print a document"

Ed.Poore15-Mar-06 6:47

Re: How to print a C# form

15-Mar-06 6:47

The simplest way I would think is to use the Win32 API to capture a picture. Take a look at the following articles (you'd need to use the form's handle rather than the desktop's one).

Screen Capturing (.NET 2.0 & pure managed)
Screen Capturing
Capturing the Screen Image in C#

Just do a search for screen capture in Code Project articles, there's lots of them! D'Oh! | :doh:

-- modified at 12:47 Wednesday 15th March, 2006

[mod]Sorry forgot to say, once you've got the image then you just need to draw it on the printer's canvas like anyother text / image[/mod]

Ed

JuJAngel18-Mar-06 9:36

JuJAngel

18-Mar-06 9:36

Thanx 4 ur help, i solved the problem by drawing the shapes of the controls on a document and print this document Smile | :)

Re: How to print a C# form

Ed.Poore18-Mar-06 10:45

how to do "123=6 23567=23"???

18-Mar-06 10:45

Not to burst your bubble but what happens when you run the program under for example Windows XP when you've been running it under 2000? You won't get the themeing.

Sorry if my assumption is incorrect Unsure | :~

gursucan15-Mar-06 3:56

gursucan

15-Mar-06 3:56

i need a program that sums the number values of a nuber for example:
when i enter the number 12345 it sums numbers values 1+2+3+4+5=15..
pls help....
also tnx for ur helps

Re: how to do "123=6 23567=23"???

Guffa15-Mar-06 4:03

Guffa

15-Mar-06 4:03

Loop through the characters in the string, convert each character to a number, and add them together.

---
b { font-weight: normal; }

Re: how to do "123=6 23567=23"???

Lju215-Mar-06 9:07

Lju2

15-Mar-06 9:07

Or divide with 10 until you get to zero...
num=next%10;
sum+=num;
next=next/10;

Re: how to do "123=6 23567=23"???

Luis Alonso Ramos15-Mar-06 18:49

Luis Alonso Ramos

15-Mar-06 18:49

We won't do your homework for you. You've already received two answers with different suggestions, but if you need more help, try yourself before, and then post the code telling us what exact problem you are having.

-- LuisR

Luis Alonso Ramos
Intelectix - Chihuahua, Mexico

Not much here: My CP Blog!

The amount of sleep the average person needs is five more minutes. -- Vikram A Punathambekar, Aug. 11, 2005

How to do syntax hightlighting?

SirErugor15-Mar-06 3:26

SirErugor

15-Mar-06 3:26

Salutations,

I'm doing an editor wherein I need some syntax highlighting.
Also, let it be known that I'm using Mono.

It all comes down to a rather simple question: How do I set some text to a specific color or weight?

Thanks!

- -
Regards SirErugor

Ed.Poore15-Mar-06 5:41

15-Mar-06 5:41

This is a complex task, why don't you have a look at the source for SharpDevelop.

Ed

SirErugor15-Mar-06 5:48

SirErugor

15-Mar-06 5:48

Is it written using Mono-libraries?
Because I don't think so and that is the single must

- -
Regards SirErugor

-- modified at 11:48 Wednesday 15th March, 2006

Colin Angus Mackay15-Mar-06 6:06

Colin Angus Mackay

15-Mar-06 6:06

SirErugor wrote:
Is it written using Mono-libraries?
Because I don't think so and that is the single must

I would think that the principles of the algorithm to determine syntax highlighting is the same regardless of the language or framework.

ColinMackay.net
Scottish Developers are looking for speakers for user group sessions over the next few months. Do you want to know more?

Ed.Poore15-Mar-06 6:26

15-Mar-06 6:26

I don't thinks great care has been taken to make it portable to mono however there is a port called MonoDevelop. I don't know if this runs on Windows but I'd be pretty confident that it does (at least the text editor portion) because it's written using Mono.

Ed

ADOX

JMichael246815-Mar-06 3:01

JMichael2468

15-Mar-06 3:01

I have a mapped drive on my local machine that points to a folder on a server off site. I also have a mapped drive that points to a folder on a server on site identical to the other. In my app I am using ADOX to examine the table and columns of a database. The following code works for the database located on site, but does not work for the database off site. Does anyone know what would cause this, and what the fix would be?

<br />
ADODB.Connection CNN = new ADODB.ConnectionClass();<br />
ADOX.Catalog Cat=new ADOX.Catalog(); <br />
			<br />
//BUILD A CONNECTION STRING, OPEN CONNECTION AND SET CATALOG'S ACTIVE CONNECTION<br />
ConnectionString = DataObj.BuildConnectionString(DBType,"",DBFile);<br />
try<br />
{<br />
     CNN.Open(ConnectionString,"","",0);<br />
     Cat.ActiveConnection = CNN;<br />
}<br />
catch(Exception ex)<br />
{<br />
	throw new Exceptions(ex.Message,ex);<br />
}<br />
try<br />
{<br />
     //ADD EACH COLUMN AND COLUMN INFORMATION TO THE SOURCESCEMA DATASET<br />
     foreach(ADOX.Table t in Cat.Tables)<br />

Re: ADOX

Ed.Poore15-Mar-06 6:36