|
How to override button click event in c#
Thanks & Regards
Thahir
|
|
|
|
|
Sorry?
What do you mean by "override button click event"?
Do you mean add a handler? Or prevent an existing handler from working?
Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water
|
|
|
|
|
prevent an existing handler from working.
|
|
|
|
|
If the app is a .NET WinForms app where you have something that implements a Form or other Container, holding a Button having a Click handler implemented by providing an OnClick() handler, then you should provide your own override OnClick(...) handler and inide it NOT call base.OnClick() . If OTOH the current handler was added using Click+=new EventHandler(myNewClickHandler) then you have to remove that handler, either by removing the code that adds it, or by actually removing it using the -= operator.
See, it would be easier if you stated a more complete and clear question, possibly showing some code.
|
|
|
|
|
I used override keyword, now it is working but triggering twice.
protected virtual void btnDate_Click(object sender, EventArgs e)
{
MessageBox.Show("Base");
}
protected override void btnDate_Click(object sender, EventArgs e)
{
MessageBox.Show("Child");
};
|
|
|
|
|
Disconnect the handler?
Why would you setup a handler and then not use it?? Granted, I know nothing about your project and or what you're doing.
Another method is to override the OnClick method. The Onxxx methods are where the events are raised from in controls. Create your own button and override the OnClick method with some code that determines in the click event should fire. If it does, just call the base OnClick method.
|
|
|
|
|
Hi all,
Suppose I have a button in a windows form app that when clicked just once causes a text box to display one message, and when clicked twice causes the text box to display a different message. I have tried to use an if statement like the following to record the number of mouse clicks but it's not working.
int clickCount=1;
if (clickCount < 2)
{
txtDisplay.Text = txtDisplay.Text + "Side1";
clickCount++;
}
else
{
txtDisplay.Text = txtDisplay.Text + "Side2";
}
It appears that each time the mouse is clicked, clickCount is set to 1 instead of having the value from the previous click. How do I store a value from the previous click event and use it in the current event? Please point me in the right direction, thanks in advance.
|
|
|
|
|
You need to make clickCount a static variable so it is set to 1 at the beginning of the application.
|
|
|
|
|
Sorry to disagree with you, but this behavior of the static keyword corresponds to C++ and not C#. In fact, if you try to set a local variable ( i.e. defined inside a method ) as static in C#, you will obtain a compiler error.
In my opinion, the best option to have clickCount record the number of clicks is to define it as a member variable and not a local one.
|
|
|
|
|
ignrod wrote: but this behavior of the static keyword corresponds to C++ and not C#.
Sorry to disagree with you but I guess you have not read this[^].
|
|
|
|
|
In fact, I have. If you have a look at the link you just posted, you will see a note in yellow color which says: "The static keyword has more limited uses than in C++. To compare with the C++ keyword, see Static (C++)."
So, if you try the following code, it will not compile in C#
class ClickCount {
static void Main() {
ClickCount click = new ClickCount();
click.IncreaseClickCountByOne();
click.IncreaseClickCountByOne();
click.IncreaseClickCountByOne();
}
void IncreaseClickCountByOne() {
static int clickCount = 1;
clickCount = clickCount + 1;
Console.WriteLine(clickCount);
}
}
Of course, member variables ( fields ) can be static or nonstatic. Any of them will keep their value between method calls.
class ClickCount {
static int clickCount = 1;
static void Main() {
ClickCount click = new ClickCount();
click.IncreaseClickCountByOne();
click.IncreaseClickCountByOne();
click.IncreaseClickCountByOne();
}
void IncreaseClickCountByOne() {
clickCount = clickCount + 1;
Console.WriteLine(clickCount);
}
}
class ClickCount {
int clickCount = 1;
static void Main() {
ClickCount click = new ClickCount();
click.IncreaseClickCountByOne();
click.IncreaseClickCountByOne();
click.IncreaseClickCountByOne();
}
void IncreaseClickCountByOne() {
clickCount = clickCount + 1;
Console.WriteLine(clickCount);
}
}
Both work exactly in the same way.
|
|
|
|
|
Yes I agree, but that is not what I was suggesting.
|
|
|
|
|
Sorry to disagree with you, but Richard is correct. Static variables work in C#.
|
|
|
|
|
Huh? when I try a static inside a method, I do get a compiler error (tried with .NET 2.0)
It is the C++ doc, and not the C# doc (unfortunately), that says: When you declare a variable in a function, the static keyword specifies that the variable retains its state between calls to that function.
|
|
|
|
|
Maybe I was not clear but I was talking about a static class variable.
|
|
|
|
|
As I can't get a local static to work in C# (as C/C++ would allow me to), I figured you meant a class member, but then I am puzzled as to why you want it to be static at all. And that is why I provided another answer to the OP, trying to state things more clearly.
|
|
|
|
|
Luc Pattyn wrote: I am puzzled as to why you want it to be static at all
My C++ brain again ...
|
|
|
|
|
you should kickstart the brain that fits the forum.
|
|
|
|
|
Even with a kick it's slow to react.
|
|
|
|
|
Same problem. I should have specified class scope statics.
|
|
|
|
|
Your code seems to suggest that you are maintaining the state of your app in a variable (clickCount) which is declared inside the button Click handler, which means it won't survive the handling of a click, hence it will always restart having the value of 1.
You should move the declaration outside the method, i.e. make it a class member. That way, for each instance of the Form (assuming you might create more than one of them), the button would remember its state.
You do not need the static keyword, unless you want to have all instances of that Form to share their state (which seems unlikely to me).
IMO it is easier and robuster to put the state inside the button itself; there are several ways to achieve this;
- one is to create your own MyButton class, inheriting from Button, and taking care of its peculiarities (IMO it would be overkill here);
- another is to hide the state in the Tag property, which is a field provided but unused by Windows for all WinForms Controls, so it is available for whatever purpose you decide to use it for. Mind you, it is of type object, so you would need some casting. (I prefer this approach).
- and then you could derive the state from existing variables and/or properties; in your example, you could perhaps just check the txtDisplay.Text and when it ends on "Side1" just replace "Side1" by "Side2". (I typically don't do it this way, as it is less robust; e.g. when you change languages, there is more code that needs changing).
modified 23-Jun-12 10:12am.
|
|
|
|
|
Hi Luc, thanks for replying. I have searched for a way to "put the state inside the button itself" like you have suggested but all I've found were maintaining session state for web apps and not windows form apps. I'm also interested in your suggestion to "hide the state in the Tag property" but I can't find an example of how to do that either. Please give me links to articles on how to do those things I've just mention if you can. Thanks again for your help.
modified 24-Jun-12 5:55am.
|
|
|
|
|
What's so hard about it??
SomeButton.Tag = stateValue;
|
|
|
|
|
(Another garbage sentence was needed to get this post accepted amidst bugs and cache issues, sorry for that)
And the harder half of the job is getting the state back, which requires a cast as I said:
int myState=(int)myControl.Tag;
And no, I don't have a reference about this subject.
Inheriting from a class, or creating a more specialized one, is a fundamental concept in Object-Oriented Programming. There are zillions of articles on the subject, why not try and read Custom Button - Issues with Focus Border, Text Color, etc.[^] (I didn't, it was the first I found using CP search).
|
|
|
|
|
Sorry for the delay. If you want to keep number of clicks inside the button, all you have to do is subclass Button class and add a field with the number of clicks. Then, override the OnClick method to increase the number of clicks by one every time the button is clicked. Don't forget to call the parent OnClick so that the normal button click behavior is executed.
You have an example below.
using System;
using System.Drawing;
using System.Windows.Forms;
class CountClickButton : Button {
int clickCount;
public CountClickButton() {
clickCount = 0;
}
protected override void OnClick(EventArgs e) {
clickCount = clickCount + 1;
base.OnClick(e);
}
public int ClickCount {
get {
return clickCount;
}
}
}
class CountClickForm : Form {
CountClickButton b;
public CountClickForm() {
b = new CountClickButton();
b.Text = "Click me!";
b.Size = b.PreferredSize;
ClientSize = new Size(700, 400);
b.Left = (ClientSize.Width - b.Width) / 2;
b.Top = (ClientSize.Height - b.Height) / 2;
b.Click += new EventHandler(b_clicked);
Controls.Add(b);
Text = "I count clicks!";
}
void b_clicked(object sender, EventArgs e) {
string text = String.Format("Button has been clicked {0} times.", b.ClickCount);
if (b.ClickCount < 1) {
text = "Sorry, I was drunk when programming this. Cheers!!";
}
if (b.ClickCount == 1) {
text = "Button has been clicked once.";
}
if (b.ClickCount == 2) {
text = "Button has been clicked twice.";
}
Text = text;
}
[STAThreadAttribute]
static void Main() {
Application.Run(new CountClickForm());
}
}
|
|
|
|