C / C++ / MFC

"The pointy end goes in the other man." - Antonio Banderas (Zorro, 1998)

// this is wrong in C or C++ (array is 1 short - will overwrite memory)
cantpalres=i-1;
palres = (char**) malloc ((sizeof(char*))*cantpalres); //is this ok???????????
// this is right (add toss the exta braces)
cantpalres=i;
palres = (char**) malloc (sizeof(char*)*cantpalres);

// 1st and 2nd part (simpified)

i=0;
while (!feof(archpalres))
{
    if( !fgets (temp,MAX_PAL,archpalres) )
        break;
    ++i; // i++ ok in C but a bad habit in C++
}
cantpalres=i;
// allocate 2 dimensional array of string/charater pointers
palres = (char**) malloc (sizeof(char*)*cantpalres);
if( !palres ) // always check if allocation succeded
    return; // or return some error value
fseek (archpalres,0,SEEK_SET);
i=0;
while (!feof(archpalres))
{
    if( !fgets (temp,MAX_PAL,archpalres) )
        break;
    // replace '\n' with '\0'
    pNewline = strchr(temp,'\n');
    if( pNewline ) // there might not be a newline after last word
        *pNewLine = '\0';
    len = strlen(temp) + 1; // +1 for '\0'
    // allocate array of charaters
    palres[i] = (char*) malloc (sizeof(char)*len);
    if( palres[i] ) // always check if allocation succeded
        strcpy(palres[i],temp);
    ++i;
}

// MFC syntax
void CMyClass::OnListViewClick( NMHDR * pNotifyStruct, LRESULT * result )
{
  NMLISTVIEW* pnmlv = (NMLISTVIEW*) pNotifyStruct;
 
  // Do stuff with pnmlv
}

"The pointy end goes in the other man." - Antonio Banderas (Zorro, 1998)

"The pointy end goes in the other man." - Antonio Banderas (Zorro, 1998)