C / C++ / MFC

Re: problem with using program Creating a Serial communication on Win32

28-May-13 2:19

If you receive valid data (and '13600 kg' looks valid), your serial parameters are correct. The data are repeated because the balance sends them. A quick search finds the manual[^] that states on page 70:

Quote:
If continuous transmission is configured for the EDP
or printer port (STREAM parameter on the SERIAL
menu), the IQ plus 710 sends data using the
Consolidated Controls serial data format shown in
Figure 10-1

sindbad1128-May-13 22:07

Re: problem with using program Creating a Serial communication on Win32

28-May-13 22:07

i do recieve a valid data but when i use Hyper Terminal and configure it to recieve data from the balance it give one value not repeated .

the balance sends data continousely but in my program
i read the data and write it in the recieved Text Box
this program i used it with Toledo Balance the program works very well and the read data not repeated

i think three is something must be done !!!!

Jochen Arndt28-May-13 22:52

Re: problem with using program Creating a Serial communication on Win32

28-May-13 22:52

Let me guess a little bit.
Your balance is sending data continuously as CR terminated lines (C style syntax, \r is CR):

*) 13600 kg\r*) 13600 kg\r*) 13600 kg\r

Because the lines are only CR terminated (not CR-LF), Hyperterminal will not print the next data set on a new line but overwrite the current one. That is: You did not see what you get. This can be changed by configuring HyperTerminal:
Properties (for active connection) - Configuration tab - ASCII configuration button - Append line feed at end of line upon receiving check box (I tried to translate the names from my local version of HyperTerminal). When enabling this option, you will also see repeated data in HyperTerminal.

What you can do is configuring the balance (disable continuous mode, optional enable sending CR-LF with each line) or write code that can handle the data.

To receive such data, your code should read and store the serial bytes until a CR is received. When this happens, copy the string to the text box and resume receiving.

sindbad1128-May-13 23:49

Re: problem with using program Creating a Serial communication on Win32

28-May-13 23:49

thanks ENG. Jochen Arndt for your interest

look eng. Jochen

i want to read only one value that is express the balance reading and i want to use this reading
after that to a bussiness application which i developed using PowerBuilder 10.5

i am a powerBuilder Programmer and my experience in c++ is less than powerBuider

i search for a progarm to read from serial port and i found this program

i have changed the program to call a powerbuilder function that i send the read data to it

the program works very well with Toledo Balance as i mentioned and i install the program in a site which contain Toledo Balance

Toledo Balance also send data continousely but i get only on reading

but the iq plus make the problem as i expalined

i want you to give me a hand in the C++ Program if there is someting wrong

Jochen Arndt29-May-13 0:31

Re: problem with using program Creating a Serial communication on Win32

29-May-13 0:31

I had a look on the sources of the example program: It reads all available serial data and puts them to the edit box. But you are only interested in a single line. So you must modify the code to get the parts you want.

A quick and dirty solution would be truncating the received data at the first CR or LF byte and stop receiving. A better solution would be doing this inside the thread using a buffer that is overwritten with each new line and provide some data exchange mechanism between the receiving thread and your application's main thread.

sindbad1112-Aug-13 1:19

Re: problem with using program Creating a Serial communication on Win32

12-Aug-13 1:19

dear eng:Jochen Arndt

i am trying your idea now

but the problem still happen

would you please give me hand ?

Jochen Arndt16-Aug-13 2:52

: problem with using program Creating a Serial communication on Win32

16-Aug-13 2:52

Sorry for my late reply.

I can't help without seeing your code. I suggest to write a new question showing the relevant code part and explaining the problem. So others may help also.

sindbad116-Sep-13 23:29

Re: : problem with using program Creating a Serial communication on Win32

6-Sep-13 23:29

i am trying to cut string from a pattern like this

@) 1450kg @) 1450kg @) 1450kg

i m trying to cut from the 4th chatacter to the 10th chatacter

var mess contain the chatacter string

i enter the code like this

char mess[MAX_MESSAGE];
unsigned int lenBuff = MAX_MESSAGE;
unsigned long lenMessage;
static CString outPut;
outPut =mess ;
std::string str1 ;
str1=outPut ;

str1 = str1.substr (4,10); /////
CString cs(str1.c_str());
outPut=cs ;

strcpy(mess, outPut);

is this code part is true ???????????????

Jochen Arndt6-Sep-13 23:45

Re: : problem with using program Creating a Serial communication on Win32

6-Sep-13 23:45

Why do you copy the data using so many vars? You should really learn about string operations in C/C++.

The CString class has a constructor that accepts a pointer to a char* string and a length. So you can simply copy the required number of characters:

C++

CString strCut(mess + 3 , 6);

This will copy 6 characters from offset 3 of mess to strCut. Note that offset 3 points to the 4th character.

sindbad117-Sep-13 0:08

Re: : problem with using program Creating a Serial communication on Win32

7-Sep-13 0:08

thanks for reply eng.Jochen Arndt

in this example if i want to cut from 4th character to the kg position which can be dynamic

@) 1450kg @) 1450kg @) 1450kg

how can i get the position of kg

i use this

outPut =mess ; //////
//------------------
std::string str1 ;
str1=outPut ;
unsigned pos = str1.find("KG");

str1 = str1.substr (4,pos - 1);

CString cs(str1.c_str());
outPut=cs ;

strcpy(mess, outPut);

is this code is true

Jochen Arndt7-Sep-13 0:28

Re: : problem with using program Creating a Serial communication on Win32

7-Sep-13 0:28

Still wrong. As I told you, indexes are zero-based. So you must use 3 as start index. To get the length, subtract the start position from the position of 'kg'. Also there is no need to mix CString and std::string:

C++

CString cs(mess); // copy mess to CString object
int nStart = 3; // start at 4th character
int nStop = cs.Find("kg"); // get position of 'kg'
cs = cs.Mid(nStart, nEnd - nStart); // extract the weight value

If you want to get numeric values from strings, use the atoi() function:

C++

int nWeight = atoi(mess + 3);

The atoi() function will parse the string stopping at the first non-digit char and return the converted value.

sindbad117-Sep-13 0:56

Re: : problem with using program Creating a Serial communication on Win32

7-Sep-13 0:56

i tryed this code

char mess[MAX_MESSAGE];
unsigned int lenBuff = MAX_MESSAGE;
unsigned long lenMessage;
static CString outPut;

CString cs(mess); // copy mess to CString object
int nStart = 3; // start at 4th character
int nStop = cs.Find("kg"); // get position of 'kg'
cs = cs.Mid(nStart, nStop - nStart);
//////--------------------------------------------

outPut=cs ;

strcpy(mess, outPut); /////

i finally put the outPut string in the mess character

is this code true

Jochen Arndt7-Sep-13 2:31

PlaySoundA does not return within injected DLL

7-Sep-13 2:31

Again: Why did you use the std::string outPut object?
You can simply copy the extracted sub-string from the CString to mess.

Overall, I can't say if the code is 'true'. You must know what should be done. Check the extracted value using a debugger or printing it out. If it is what you want, you are finished. Otherwise change your code until you get what you want.

Coding guidelines C

topcatalpha27-May-13 2:56

topcatalpha

27-May-13 2:56

Hi,

I like to gather some coding guideline tools for C. More specific for integration into a CI system showing us some statistics of the code quality.

Can anyone post some suggestions, eventually with feedback or experience about the tool?

regards.

T.

Re: Coding guidelines C

Maximilien27-May-13 7:08

Maximilien

27-May-13 7:08

topcatalpha wrote:
More specific for integration into a CI system

What's a CI system ?

Anyway, coding guidelines are quite subjective, google for a few of them and pick whatever looks nice and applicable to your organization (or yourself).

For example, the IBM[^] one looks good.

Nihil obstat

Re: Coding guidelines C

topcatalpha28-May-13 20:41

topcatalpha

28-May-13 20:41

CI = Continious Integration.

Well we reviewed some tools but it would be nice if we had some feedback from users who are actually using them.

thx,

K

Furblog Sidloth26-May-13 0:42

Furblog Sidloth

26-May-13 0:42

Hi, i have the following problem:

I have a process which uses PlaySoundA[^] WINAPI function to play a specific sound (let's be it "c:\test.wav"). So the process has already loaded the needed "winmm.dll"

I want to play the same sound when the DLL is injected into the process, so the code looks like:

C++

#define WINVER 0x600
#define _WIN32_WINDOWS 0x600
#define _WIN32_WINNT 0x600

#include <windows.h>

typedef bool __stdcall (*psfunc)(LPCTSTR pszSound, HMODULE hmod, DWORD fdwSound);

void play() {
    psfunc ps;
    HMODULE winmm = GetModuleHandle("winmm");;
    ps = (psfunc)GetProcAddress(winmm, "PlaySoundA");
    ps("c:\\test.wav", 0, SND_FILENAME | SND_ASYNC);
}

BOOL __stdcall DllMain (HANDLE hDll, DWORD dwReason, LPVOID lpReserved)
{
    switch (dwReason)
    {
        case DLL_PROCESS_ATTACH:
            OutputDebugString("play before");
            play();
            OutputDebugString("play after");
            break;

        case DLL_PROCESS_DETACH:
            break;

        case DLL_THREAD_ATTACH:
            break;

        case DLL_THREAD_DETACH:
            break;
    }
    return TRUE;
}

The dll is injected correctly via CreateRemoteThread & LoadLibrary.
But the sound is never played and the dll is blocking at the call of

C++

ps("c:\\test.wav", 0, SND_FILENAME | SND_ASYNC);

Trying to exit the process freezes too because of the blocking thread.
Why does it never return? Procss Monitor doesn't show any error.
How can I solve this?

Richard MacCutchan26-May-13 0:54

Richard MacCutchan

26-May-13 0:54

~~Are you certain that GetProcAddress is returning a valid handle?~~
See the warning at http://msdn.microsoft.com/en-us/library/windows/desktop/ms682583(v=vs.85).aspx[^]. I do not think you should be calling your play function inside DllMain.

Use the best guess

modified 26-May-13 7:20am.

Furblog Sidloth26-May-13 20:39

Furblog Sidloth

26-May-13 20:39

Oh, I didn't see that.
So I called the function via CreateRemoteThread too and it's working. Thank you!
It would be nice to know what things are allowed/disallowed in DllMain.

Richard MacCutchan26-May-13 21:38

Richard MacCutchan

26-May-13 21:38

Furblog Sidloth wrote:
It would be nice to know what things are allowed/disallowed in DllMain.

I agree, the documentation could be better. However, my understanding is that you should not do anything more than initialise the odd static variable or class, and save a handle to the DLL itself. Anything that takes you out of DllMain is not allowed and can lead to problems - as you already discovered.

Use the best guess

Erudite_Eric27-May-13 5:48

Erudite_Eric

27-May-13 5:48

Not only that he has no error checking....

==============================

Nothing to say.