C / C++ / MFC

16-Jun-10 3:01

I have the following code:

class A
{
public:
	A(void);
	~A(void);
};

class B
{
public:
	B(void);
	~B(void);
};

void testfunction(A* x){};

I want to be able to directly use:

B* x;
testfunction(x);

instead of doing an explicit cast, like

B* x;
testfunction((A*)x);

Is there a way to do this. I tried using a conversion constructor in testclass (i.e. A::A(B)) but that didn't work, also I tried defining a A* operator in B but that also failed. Is there any way I can do this?

Cedric Moonen16-Jun-10 3:06

16-Jun-10 3:06

Why do you want to do something like that ? A and B are two completely different classes so, why do you want to be able to pass a B to a function expecting an A object ? It's a bit like asking how can I convert an apple to a car, it doesn't make any sense.
If the objects are related in some way, then I would suggest that they have a common base class and that your function expect a pointer to the base class. Then you can pass a pointer to an instance of A or a pointer to an instance of B but the function will treat them as a pointer to the base class.

But if the class are unrelated, I think you are making a very bad design decision.

Cédric Moonen
Software developer

Charting control [v3.0]
OpenGL game tutorial in C++

Iosif Murariu16-Jun-10 3:11

16-Jun-10 3:11

The project is bigger than what I've written down. I know it's usually not safe but we're sure the memory layout of the classes permit this forced cast and that it actually works. My questions still stands. Also, the question is how (if at all) this can be done, not whether it is safe or not.

Iosif Murariu16-Jun-10 3:13

16-Jun-10 3:13

Also, the function expects a pointer to an A object, not an A object itself. I'm just looking for a way to tell the compiler I want the (A*) operator implicitly cast so I don't have to change the whole project (which is pretty big).

CPallini16-Jun-10 3:19

CPallini

16-Jun-10 3:19

Arkh wrote:
I know it's usually not safe but we're sure the memory layout of the classes permit this forced cast and that it actually works.

Then state this relation giving them a common base class or interface. Smile | :)

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.

This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke

[My articles]

Cedric Moonen16-Jun-10 3:20

16-Jun-10 3:20

Arkh wrote:
but we're sure the memory layout of the classes permit this forced cast and that it actually works

Honnestly, that's a receipt for disaster: if later you have a programmer who wants to document the class and innocently swap two variables of your class, you are doomed. This is an extremly bad practice, and that's one of the reason why type safety is so strong in C++.
Anyway, you still didn't answer the question: WHY do you want something like that ? It doesn't make any sense that your function accept a pointer to A and you pass a pointer to B making believe the function that it is a pointer to A D'Oh! | :doh:

Cédric Moonen
Software developer

Charting control [v3.0]
OpenGL game tutorial in C++

Iosif Murariu16-Jun-10 3:30

16-Jun-10 3:30

Ok here goes. We're migrating our software to run on more platforms. Initially we had something like:

class A : public B {};
void function(B* x) {};

Obviously

A* y;
function(y);

used to work. Now we have some wrapper classes, call them xA (over A) and xB (over B). Therefore:

class xA : protected A {};
class xB : protected B {};
void function(xB* x){};

Since xA is not derived from xB, calling the function as before no longer works.

xA* x;
// doesn't work:
function(x);
// works:
function((xB*)x);

The protected in the inheritence between the base and wrapper classes is necesarry. All functions in A and B are overwritten in xA and xB respectively but no new members are added. This is part of the specs.

Now can you answer the question?

Cedric Moonen16-Jun-10 3:39

16-Jun-10 3:39

Why don't you keep your function as it was ? This way you can pass a pointer to xA or a pointer to xB which both inherit from B.

Cédric Moonen
Software developer

Charting control [v3.0]
OpenGL game tutorial in C++

Iosif Murariu16-Jun-10 3:42

16-Jun-10 3:42

Because in our software we should no longer have access to classes A and B, only to xA and xB. Classes A and B are specific to the platform we're using now. On other platforms we have classes, say, C and D. But we want to make our software run on all platforms, so functio(B* x) would make no sense in our code if we were running it on the second platform. Any ideas on how to make it work? Anyone?

Cedric Moonen16-Jun-10 3:50

16-Jun-10 3:50

I think you still have a bad design decision: your base class should be independant of any platform but these are abstract classes (they can't be instanciated). Then, for each platform, you would create another class which inherits from the base class. Suppose you want to create a class to display a window (both on Windows and Linux). You would do something like this:

class CWindow
{
//
};

class CWinWindow : public CWindow
{
};

class CLinWindow : public CWindow
{
};

Your function receives a pointer to a CWindow object but should care about the fact that it is for windows or Linux. Then, you should redefine the behavior of your window through virtual functions. Both child classes implements functions like show(..) or move(..) in their own specific way. The rest of your program should in fact only manipulate CWindow pointers.

Cédric Moonen
Software developer

Charting control [v3.0]
OpenGL game tutorial in C++

Iosif Murariu16-Jun-10 3:58

16-Jun-10 3:58

both platforms coincidentaly have the same functions in classes and so on, so our design works. only the class names differ. the design works(tested), we just need to get rid of the explicit casts.

more specifically, in our code we use something like:

#ifdef PLATFORM1
class A : protected AfromPlatform1
#else
class A : protected AfromPlatform2
#endif
{
void f();
}

void A::f()
{
#ifdef PLATFORM1
AfromPlatform1::f();
#else
AfromPlatform2::f();
#endif
}

This works, trust me, as I said before, it's tested.

CPallini16-Jun-10 3:15

CPallini

16-Jun-10 3:15

What are trying to do? What about a good OOP tutorial?
Explicitely casting a pointer of an unrelated object is always a bad idea (well using unitialized pointers, as you did is evene worse).

Smile | :)

Nemanja Trifunovic16-Jun-10 4:12

Nemanja Trifunovic

16-Jun-10 4:12

Can you declare the constructor to take void* instead of void? All pointer types can be passed as void*, and in C also the other way around.

Of course, I agree with others that what you are doing is a bad idea but hey, we're all grown ups (I hope) Smile | :)

utf8-cpp

Iosif Murariu16-Jun-10 4:19

16-Jun-10 4:19

I'll give it a shot, although it's not exactly a solution since i only want to be able to convert from some pointer types to the type the function is looking for. If the constructor does accept a void* parameter, all pointers would be converted to my class when the function is called and i don't necesarily want that. Also, if you read all the replies from above, you will see that it's no really a bad design or implementation, i was just being greedy about the details, because details would only be useful in explaining the reasons I'm trying to do this but not at all helpful in finding a solution. Any other ideas?

Iosif Murariu16-Jun-10 4:23