C / C++ / MFC

name = "";

Chuck Vought wrote:

I am getting two errors, first why cant I declare the array size from a user input called "num"...

Chuck Vought wrote:

name = "";

Chuck Vought wrote:

if(j=5)

Chuck Vought wrote:

put it in the outer for loop or does it go with the declarations?

Chuck Vought wrote:

i still get the error subscript out of range.

Chuck Vought wrote:

name[i] += letters[i%2][rand()%letterlength[i%2]];

int main()
{	
	
	int  numFirst, numLast,num,i,j,count;
	int lowFirst=3, highFirst=12,lowLast=5, highLast=14;
		

		cout << "This program will generate first and last names from\n";
		cout <<"the number of names you choose." << endl;
		 	  
		cout << endl;
		cout << "Please enter the number of names between 1 and 100 you want to \n"
			 << "generate random first and last names for: ";
		cin >> num;

		while (num < 1 || num > 100)
		{
			cout << "\nInvalid number entered!!  Please try again ..." << endl << endl;
			cout << "Please enter the number of integers between 1 and 100 you want to\n"
				<< "generate random first and last names for: ";
			cin >> num;
		}

		cout << "\nPlease enter the number of letters(between 3 and 12) you want for your first name: ";
		cin >> numFirst;
		cout << endl;

		while (numFirst < lowFirst || numFirst > highFirst)
		{
			cout << "\nInvalid number entered!!  Your number must be between 3 and 12. \n"
				 << "Please re-enter a number. \n";
			cin >> numFirst;
			
		}

		cout << "\nPlease enter the number of letters(between 5 and 14) you want for your last name: ";
		cin >> numLast;
		cout << endl;

		while (numLast < lowLast || numLast > highLast)
		{
			cout << "\nInvalid number entered!!  Your number must be between 5 and 14. \n"
				 << "Please re-enter a number.\n";
			cin >> numLast;
		}
		
		string firstname[num],lastname,name;	
		static const int namelen = numFirst;	
		static const char* letters[2] = { "bcdfghjklmnpqrstvwxyz", "aeiouy" };
		static const  int letterlength[2] = { strlen(letters[0]), strlen(letters[1]) };
		srand(time(NULL));
		
		for (int j=0; j<num; j++)
		{
				for (int i=0; i<numFirst; i++)
				{
					
					name += letters[i%2][rand()%letterlength[i%2]];
					
				}
				
				name[0]=toupper(name[0]);
				firstname[j]=name;
				name = "";
							
		}
			
				for (int i=0; i<numLast; i++)
				{
					lastname[i] += letters[i%2][rand()%letterlength[i%2]];
					lastname[0] = toupper(lastname[0]);
				}

				for(j=0;j<num;j++)
				{
					cout <<firstname[j].c_str() <<" ";
					if(j<=5)
					{ 
						cout<<endl;
					}
				}

cout<<endl<<endl;
return 0;
}

Chuck Vought wrote:

string firstname[num],lastname,name;

vector<string> firstname;

Chuck Vought wrote:

firstname[j]=name;

firstname.push_back(name);

Chuck Vought wrote:

still getting the error.

Chuck Vought wrote:

can you repost the code you ran and i will try it again.

vector <string> firstnames;
vector <string> lastnames;
string lastname;
string firstname;	
static const char* letters[2] = { "bcdfghjklmnpqrstvwxyz", "aeiouy" };
static const  int letterlength[2] = { strlen(letters[0]), strlen(letters[1]) };
srand(time(NULL));
		
for (int j=0; j<num; j++)
{
	for (int i=0; i<numFirst; i++)
		{
			firstname += letters[i%2][rand()%letterlength[i%2]];
		}
				
		firstname[0]=toupper(firstname[0]);
		firstnames.push_back(firstname);
		firstname = "";
}

for (int x=0; x<num; x++)
{
	for (int y=0; y<numLast; y++)
	{
	lastname += letters[i%2][rand()%letterlength[i%2]];
	}
		lastname[0]=toupper(lastname[0]);
		lastnames.push_back(lastname);
		lastname = "";
	}
}

for(z=0;z<num;z++)
{
   cout <<firstnames[z].c_str()<<" " << lastnames[z].c_str()<<endl;
 	
}

Chuck Vought wrote:

lastname += letters[i%2][rand()%letterlength[i%2]];

Zyr Yayaouyeea
Yyv Yoiooioeyu
Qay Yiuooeyoeu
Zyh Uyiaauuiuu
Rok Ioiouiaooi
Les Oyauaiuiyu
Xam Aoieyuiaoy
Mij Oyeaaaoiya
Yuq Yyiuaoyooa
Hil Uayayyouyu

Chuck Vought wrote:

they are variables so how could i declare them? they are declared as int types.