C / C++ / MFC Discussion Boards

«_Superman_»2-Mar-09 17:15

2-Mar-09 17:15

Below is the assembly code generated by Visual Studio 2008 for both the functions.
The code was generated with full optimization.

?Length0@@YANNNNNNN@Z PROC

	fld	QWORD PTR _x2$[esp-4]
	fsub	QWORD PTR _x1$[esp-4]
	fld	QWORD PTR _y2$[esp-4]
	fsub	QWORD PTR _y1$[esp-4]
	fld	QWORD PTR _z2$[esp-4]
	fsub	QWORD PTR _z1$[esp-4]
	fld	ST(1)
	fmulp	ST(2), ST(0)
	fld	ST(2)
	fmulp	ST(3), ST(0)
	fxch	ST(1)
	faddp	ST(2), ST(0)
	fmul	ST(0), ST(0)
	faddp	ST(1), ST(0)

	ret	0
	
?Length0@@YANNNNNNN@Z ENDP

?Length1@@YANNNNNNN@Z PROC

	fld	QWORD PTR _x2$[esp-4]
	fsub	QWORD PTR _x1$[esp-4]
	fld	QWORD PTR _y2$[esp-4]
	fsub	QWORD PTR _y1$[esp-4]
	fld	QWORD PTR _z2$[esp-4]
	fsub	QWORD PTR _z1$[esp-4]
	fld	ST(1)
	fmulp	ST(2), ST(0)
	fld	ST(2)
	fmulp	ST(3), ST(0)
	fxch	ST(1)
	faddp	ST(2), ST(0)
	fmul	ST(0), ST(0)
	faddp	ST(1), ST(0)

	ret	0
	
?Length1@@YANNNNNNN@Z ENDP

Here you will notice that both are exactly the same.
The compiler has taken away the responsibility from the programmer about optimizing code. At least a lot of it. Smile | :)

«_Superman_»
I love work. It gives me something to do between weekends.

Re: Efficiency question

Eytukan2-Mar-09 20:17

Eytukan

2-Mar-09 20:17

yellowine wrote:
double Length0(double x1, double y1, double z1, double x2, double y2, double z2)
{
double dx = x2 - x1;
double dy = y2 - y1;
double dz = z2 - z1;

return (dx*dx + dy*dy + dz*dz);
}

You can see no specific improvements with that change there. but on the other hand There would be some improvements with the first case (length0), If the calculations happen inside a loop. just a rough example:

double y1, double z1, double x2, double y2, double z2)
{
double dx = x2 - x1;
double dy = y2 - y1;
double dz = z2 - z1;

double result =0.0;

for(int i=xx;i<yx;i++)>
{
   result +=  (dx* i + dy * i + dz * i);
}
return result;
}

There it would make sense to keep them out of the loop and see some performance improvements.

He never answers anyone who replies to him. I've taken to calling him a retard, which is not fair to retards everywhere.-Christian Graus

Replacing contents of a file

Neelesh K J Jain2-Mar-09 9:58

Neelesh K J Jain

2-Mar-09 9:58

Hello Everybody,
I have a file Abc.txt with the following contents

Testing

]]>

In the above contents, I have to replace only the "cdef" present in the starting of the file, with some numbers say "1234". I couldn't able to do it using the CFile class. I have done a alternative way, by reading the contents and replacing the word and then re-create the file with the same name. I don't want to recreate the file instead I have to replace the string. Please help in solving this issue.

Thanks,
Neelesh K J Jain.

Re: Replacing contents of a file

CPallini2-Mar-09 10:09

CPallini

2-Mar-09 10:09

No cookie for you: you've just found the only viable solution and discarded it badly.
Smile | :)

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.

This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke

[My articles]

Re: Replacing contents of a file

Rajesh R Subramanian2-Mar-09 19:53

Rajesh R Subramanian

2-Mar-09 19:53

CPallini wrote:
No cookie for you: you've just found the only viable solution and discarded it badly.

I'm proposing this for the most memorable quotes of CP for this year.

It is a crappy thing, but it's life -^ Carlo Pallini

Re: Replacing contents of a file

CPallini2-Mar-09 21:18

CPallini

2-Mar-09 21:18

Well,to be included, the sentence must be really memorable, I suppose the OP should try harder, the next time.. Roll eyes | :rolleyes:

OnAppExit not called when X button clicked

TimmySRX2-Mar-09 9:49

TimmySRX

2-Mar-09 9:49

I have a multi-tabbed app that on exit is trying to override the OnAppExit() function to call a bit of house claening code so that I don't have a memory leak. My problem is that if I use the file->menu->exit route it will call the OnAppExit() function and I can call my function to house clean. But if I close by using the X in the upper right pane it never calls the exit function and a leak occurs. I have tried all I know to figure out why but am lost so here I am. I am fairly green to MFC so any tips or help would be appreiceated. The code that I have done is:

void CdatamaxApp::OnAppExit()
{
if( IsOnline() == TRUE )
{
int nRetValue;
nRetValue = MessageBox( NULL,"Still ONLINE, YES to Quit, NO returns to App", TEXT("Datamax Exit"), MB_ICONERROR|MB_YESNO );
if(nRetValue == IDYES)
{
OnGoOffline();
AfxGetMainWnd()->;PostMessage ( WM_CLOSE );
}
else
{

}
}
else
{
AfxGetMainWnd()->;PostMessage ( WM_CLOSE );
}
}

How can I debug or set a breakpoint to figure out why this function doesn't get called when I close app with the x close button vs using the file menu, don't they both issue the same event?

Re: OnAppExit not called when X button clicked

Stuart Dootson2-Mar-09 10:15

Stuart Dootson

2-Mar-09 10:15

You're probably best off overriding CWinApp's ExitInstance method? That should be called whatever (standard) mechanism you use to exit the application.

Java, Basic, who cares - it's all a bunch of tree-hugging hippy cr*p

Re: OnAppExit not called when X button clicked

TimmySRX2-Mar-09 11:05

TimmySRX

2-Mar-09 11:05

Thanks for the feedback, it does work to call ExitInstance(). I think the answer is yes but I no longer need to post message to WM_CLOSE window as I was doing before, it workS without the call but just wanted to make sure that nothing else is needed inside the ExitInstance when it is called other than my own code.

Re: OnAppExit not called when X button clicked

Iain Clarke, Warrior Programmer2-Mar-09 23:04

Iain Clarke, Warrior Programmer

2-Mar-09 23:04

TimmySRX wrote:
but just wanted to make sure that nothing else is needed inside the ExitInstance

Then call the base implementation also. It's the only way to be sure.

This code is taken from the documentation for ExitInstance (You do read those, I hope?)

// MySampleApp.cpp.

int CMySampleApp::ExitInstance() 
{
   // TODO: Add your specialized code here and/or
   // call the base class.

   if ( m_pMySampleMem )
      delete m_pMySampleMem;
   
   DoCleanup();

   return CWinApp::ExitInstance();                        // <---- Note the call to the base implementation
}

This is good practise for any MFC thing you override. You don't always want to do it, but you should make a conscious decision about it.

Iain.

Codeproject MVP for C++, I can't believe it's for my lounge posts...

SendKeys won't work

Ran42-Mar-09 8:49

Ran4

2-Mar-09 8:49

(I've now spent the last 2½ hours trying to get this to work. I've read something like 60 pages on google.).

I'm trying to get the SendKeys for C++ to work, but to no avail.
I have tried what I think is all possible variations of SendKeys.h, windows.h, StdAfx.h and "#define _WIN32_WINNT 0x0501" (I have seen 0x0501, 500, 400, 401, 503, 510... Everyone says that what they say work. Well... no.). I simply cannot include that INPUT object (error C2065: 'INPUT' : undeclared identifier).

I am quite certain that all I need is to have ~5 rows of code in the right place. Which are these codes, and in which order should they be?

I'm using Visual C++ 6.0 (I also have the 2008 version available) with Windows XP SP2.

Now, I suppose you are supposed to do something like this:
1. Create a win32 project in visual c++ 6.0
2. Add a main.cpp file which has the main function in it
3. Add the SendKeys.cpp, StdAfk.cpp, SendKeys.h, StdAfx.h and resource.h files to the project (right-click -> add files to folder?)
4. Write something weird at the very beginning of StdAfx.h
5. Include the right things in my main.cpp
6. Create the main function, then create a CSendKeys object and then use it
7... here on, I could probably follow the official guide.

Which of the above is wrong?

Re: SendKeys won't work

led mike2-Mar-09 9:49

led mike

2-Mar-09 9:49

Ran4 wrote:
4. Write something weird at the very beginning of StdAfx.h

ROTFLMAO Yeah that's the technical term for it! Laugh | :laugh:

Ran4 wrote:
Which of the above is wrong?

You are, you're the one that's wrong. You apparently believe you should be able to create software without actually knowing what you are doing. I hope you don't find yourself in the hands of some surgeon that thinks the same way.

Re: SendKeys won't work

Ran42-Mar-09 10:14

Ran4

2-Mar-09 10:14

Huh? What are you talking about? What do you get out of being rude?
I want to create a program, something is in the way of that (this problem), and this is a place where I can hopefully learn how to do it. Learning your compiler is nearly impossible without someone helping you, as you know yourself.

Re: SendKeys won't work

CPallini2-Mar-09 10:19

CPallini

2-Mar-09 10:19

Well, I should admit: learning led mike's compiler is troublesome... Roll eyes | :rolleyes:

modified on Monday, March 2, 2009 4:28 PM

Re: SendKeys won't work

«_Superman_»2-Mar-09 17:33

«_Superman_»

2-Mar-09 17:33

SendKeys is for the .Net platform.
You should be using SendInput.

«_Superman_»
I love work. It gives me something to do between weekends.

Re: SendKeys won't work

davidjaybrown3-Mar-09 8:49

davidjaybrown

3-Mar-09 8:49

I struggled a bit with SendInput, (which you should prefer to use) and I learned the following...

in the MSDN documentation, the call to SendInput must include a size of your input structure.
If you get it wrong, SendInput will do nothing, and not tell you.

Try something like...

<br />
#include <WinAble.h><br />
<br />
#define _MAX_KBDINPUT_LENGTH_ 50<br />
<br />
   INPUT KBa[ _MAX_KBDINPUT_LENGTH_ ];<br />
   ::ZeroMemory(KBa, sizeof(KBa));<br />
<br />
   UINT KBn = 0;  // how many keyboard key msgs to send (this is a counter)<br />
<br />
   Stuff the KBa array with KEYEVENTF_KEYUP and KEYEVENTF_KEYDN (0) messages. like this...<br />
<br />
			KBa[KBn].type       = INPUT_KEYBOARD;<br />
			KBa[KBn].ki.wVk     = wVk;<br />
			KBa[KBn].ki.wScan   = wScan;<br />
			KBa[KBn].ki.dwFlags = 0;  // KEYDOWN is ZERO<br />
                        KBn++;<br />
			KBa[KBn].type       = INPUT_KEYBOARD;<br />
			KBa[KBn].ki.wVk     = wVk;<br />
			KBa[KBn].ki.wScan   = wScan;<br />
			KBa[KBn].ki.dwFlags = KEYEVENTF_KEYUP;<br />
                        KBn++;<br />
<br />
Then, set focus to the target window.  If its not a window your process owns, you must do the following<br />
<br />
		// set focus to target foreign window. Get owning thread of target window.<br />
		DWORD tWNDthread = ::GetWindowThreadProcessId(hwndTARGET,0);<br />
		if (!tWNDthread)<br />
		{<br />
			AfxMessageBox("zSendKeys FAILED to get ABF Thread Id!");<br />
			bValid = FALSE;<br />
		}<br />
<br />
		// MUST attach to it<br />
		BOOL bAttached = FALSE;<br />
		bAttached = AttachThreadInput(GetCurrentThreadId(),tWNDthread,TRUE); // TRUE means ATTACH<br />
<br />
		if ( bAttached )<br />
		{<br />
			::SetForegroundWindow(hwndTARGET);  // pop to top<br />
			::SetFocus(hwndTARGET);             // set it to accept future keystrokes<br />
			<br />
			//mission accomplished, now release my hook into their thread.<br />
			AttachThreadInput(GetCurrentThreadId(),tWNDthread,FALSE); // FALSE means DETACH<br />
<br />
		} else<br />
		{<br />
			AfxMessageBox("zSendKeys FAILED to attach to ABF Thread Id!");<br />
			bValid = FALSE;<br />
		}<br />
<br />
		// do the deed<br />
		if (bValid) bValid = ::SendInput(KBn,&KBa[0],sizeof(INPUT)); // <-- note KBn and sizeof(INPUT) might be different<br />
<br />
	   	// no matter what, lets be safe, and set the forground and focus here again<br />
	   ::SetForegroundWindow(hME);<br />
       ::SetFocus(hME);<br />

I know this is MFC-centric, and not generic C, but I hope it helps you

-Dave

Re: SendKeys won't work

«_Superman_»3-Mar-09 15:59

«_Superman_»

3-Mar-09 15:59

For starters, you might as well use the deprecated keybd_event function.

«_Superman_»
I love work. It gives me something to do between weekends.

Compile Error Actual linking error ....Can someone help.

FISH7862-Mar-09 8:01

FISH786

2-Mar-09 8:01

Hello,

I am trying to compile this small dll function and am getting a linking error can someone help....Please....I am using Visual Studio 2008.

The error i get when i build is error LNK2019: unresolved external symbol _DetourTransactionBegin@0 referenced in function _DllMain@12

Here is the code.

Can someone help..Please
#include "stdafx.h"
#include "detours.h"

BOOL APIENTRY DllMain( HMODULE hModule,
DWORD ul_reason_for_call,
LPVOID lpReserved
)
{
switch (ul_reason_for_call)
{
case DLL_PROCESS_ATTACH:
DetourTransactionBegin();
break;
case DLL_THREAD_ATTACH:
break;
case DLL_THREAD_DETACH:
break;
case DLL_PROCESS_DETACH:
DetourTransactionBegin();
break;
}
return TRUE;
}

thanks A Million.

Re: Compile Error Actual linking error ....Can someone help.

Jonathan Davies2-Mar-09 8:05

Jonathan Davies

2-Mar-09 8:05

Either add detours.cpp to your project (if you have it) or update your project settings to link to the library, perhaps named, detours.lib

Re: Compile Error Actual linking error ....Can someone help.

Cedric Moonen2-Mar-09 8:06

Cedric Moonen

2-Mar-09 8:06

Did you link to the appropriate library ? The one which defines the DetourTransactionBegin (possibly detour.lib ?)

Cédric Moonen
Software developer

Charting control [v1.5]
OpenGL game tutorial in C++

Re: Compile Error Actual linking error ....Can someone help.

FISH7862-Mar-09 8:09

FISH786

2-Mar-09 8:09

yes under tools-> options -> vc++ directories i have both the directories..one under include and the other under lib....

Re: Compile Error Actual linking error ....Can someone help.

Cedric Moonen2-Mar-09 8:12

Cedric Moonen

2-Mar-09 8:12

That's not enough. You need to specify in your settings that you are linking with the library: "Project properties" -> "Linker" -> "Input" and in "Additional Dependencies" put the name of your library.

Cédric Moonen
Software developer

Charting control [v1.5]
OpenGL game tutorial in C++

Re: Compile Error Actual linking error ....Can someone help.

Cedric Moonen2-Mar-09 8:14

Cedric Moonen

2-Mar-09 8:14

By the way, I prefer to set the include and lib directories in the project settings rather than in the options. The difference is that they will be specific to your project and not to visual studio. This has also the advantage that all the required information is contained in your project file that you can distribute with your sources.

Cédric Moonen
Software developer

Charting control [v1.5]
OpenGL game tutorial in C++

Re: Compile Error Actual linking error ....Can someone help.

FISH7862-Mar-09 8:34

FISH786

2-Mar-09 8:34

same error message.....I have a project from someone with detours in it...and it compliled and did build fine with no errors or warnings..Thinking if its the way i started the new project..

Re: Compile Error Actual linking error ....Can someone help.

FISH7862-Mar-09 8:58

FISH786

2-Mar-09 8:58

Started a new project and once i add the detours.cpp i get this

1>------ Build started: Project: simpledll, Configuration: Debug Win32 ------
1>Compiling...
1>detours.cpp
1>e:\mydetour\simpledll\detours.cpp(22) : fatal error C1189: #error : Must define one of DETOURS_X86, DETOURS_X64, or DETOURS_IA64
1>Build log was saved at "file://e:\MyDetour\simpledll\Debug\BuildLog.htm"
1>simpledll - 1 error(s), 0 warning(s)
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

what did i miss....

If i remove the detours.cpp I get

1>------ Build started: Project: simpledll, Configuration: Debug Win32 ------
1>Compiling manifest to resources...
1>Microsoft (R) Windows (R) Resource Compiler Version 6.0.5724.0
1>Copyright (C) Microsoft Corporation. All rights reserved.
1>Linking...
1>dllmain.obj : error LNK2019: unresolved external symbol _DetourTransactionBegin@0 referenced in function _DllMain@12
1>E:\MyDetour\simpledll\Debug\simpledll.dll : fatal error LNK1120: 1 unresolved externals
1>Build log was saved at "file://e:\MyDetour\simpledll\Debug\BuildLog.htm"
1>simpledll - 2 error(s), 0 warning(s)
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.