C / C++ / MFC

17-Oct-06 7:57

Maybe I did something wrong, but I doubt it.

MFC8.0 MDI apps leak resources. To duplicate create a new MFC MDI app, selecting all the default settings. Start Task Manager so you can watch the number of GDI objects. Start the app, press and hold the Ctrl+N key (New document) until you get a bunch of new documents on the screen. GDI object count will climb (obviously). Now press and hold Ctrl+F4 to close all those documents. GDI object count will not go back down.

Not a huge deal for me as the app is not meant to run 24/7, but I spent a lot of time looking for where I was leaking resources, only to find out it was MFC itself that was leaking them. Sniff | :^)

You may be right
I may be crazy
-- Billy Joel --

Within you lies the power for good, use it!!!

David Crow17-Oct-06 8:42

17-Oct-06 8:42

PJ Arends wrote:
MFC8.0 MDI apps leak resources.

If it's any consolation, MFC v4.2 does too.

"Approved Workmen Are Not Ashamed" - 2 Timothy 2:15

"Judge not by the eye but by the heart." - Native American Proverb

James R. Twine17-Oct-06 8:49

James R. Twine

17-Oct-06 8:49

   Is the leak you are seeing related to this: http://support.microsoft.com/kb/319740/en-us[^]?

   That is an older KB article that talks about how MFC leaks on Windows XP and above...

   Peace!

-=- James

If you think it costs a lot to do it right, just wait until you find out how much it costs to do it wrong!
Avoid driving a vehicle taller than you and remember that Professional Driver on Closed Course does not mean your Dumb Ass on a Public Road!
DeleteFXPFiles & CheckFavorites (Please rate this post!)

PJ Arends17-Oct-06 9:31

17-Oct-06 9:31

James R. Twine wrote:
Is the leak you are seeing related to this: http://support.microsoft.com/kb/319740/en-us[^]?

Yeah, that seems to be it. When I switch the theme to windows classic the GDI count does not go up at all when creating the new documents.

Thanks for the link.

You may be right
I may be crazy
-- Billy Joel --

Within you lies the power for good, use it!!!

Rob Caldecott17-Oct-06 9:37

Rob Caldecott

17-Oct-06 9:37

I had a hotfix for this bug from MS a couple of years ago. Problem with uxtheme.dll IIRC.

Kicking squealing Gucci little piggy.

PJ Arends17-Oct-06 9:45

17-Oct-06 9:45

Yeah, that is what the link James posted says anyway.

You may be right
I may be crazy
-- Billy Joel --

Within you lies the power for good, use it!!!

FIXED!

PJ Arends17-Oct-06 12:25

how to extract the system icons and add them to our CImageList object??

17-Oct-06 12:25

The hotfix to patch windows XP sp2 to fix this problem is available at WindowsXP-KB319740-v5-x86-ENU.exe[^].

You may be right
I may be crazy
-- Billy Joel --

Within you lies the power for good - Use it!

Re: FIXED!

Mark Salsbery17-Oct-06 13:37

Mark Salsbery

17-Oct-06 13:37

That's cool!

I can't believe this one's been around so long and still hasn't found its way into
updates or a service pack.

I wrote it off long ago as a TODO item...find the GDI resource leak in MFC.
I sure wasted many hours trying to find it in my code.

It was only a few handles anyway, right? Smile | :)

Thanks,
Mark

indra2017-Oct-06 5:20

Re: how to extract the system icons and add them to our CImageList object??

17-Oct-06 5:20

how to extract the system icons and add them to our CImageList object??

David Crow17-Oct-06 5:25

Re: how to extract the system icons and add them to our CImageList object??

17-Oct-06 5:25

indra20 wrote:
how to extract the system icons...

Systems icons? Are you looking for ExtractIcon()?

"Approved Workmen Are Not Ashamed" - 2 Timothy 2:15

"Judge not by the eye but by the heart." - Native American Proverb

indra2017-Oct-06 5:46

Re: how to extract the system icons and add them to our CImageList object??

17-Oct-06 5:46

Doing the following to add to my own list, AddIcon is passing
but later when i am doing:
TreeView_SetImageList(hWnd, m_clTreeImageList.GetSafeHandle(), TVSIL_NORMAL);
the icons are not getting displayed.

// Lets Add Application defined Image List.. START
IMalloc* pMalloc;
SHGetMalloc(&pMalloc);
HIMAGELIST hSysImageList = NULL;
LPITEMIDLIST pidl = NULL;
SHGetSpecialFolderLocation(NULL, CSIDL_DESKTOP, &pidl);

SHFILEINFO sfi;
ZeroMemory(&sfi, sizeof(SHFILEINFO));
hSysImageList = (HIMAGELIST) SHGetFileInfo((LPCTSTR)pidl, 0,
&sfi, sizeof(SHFILEINFO), SHGFI_PIDL | SHGFI_SYSICONINDEX | SHGFI_SMALLICON);

pMalloc->Free(pidl);
if(!pMalloc)
pMalloc->Release();

//Images for the CoolCool Folders....

CImageList* pImgList = CImageList::FromHandle(hSysImageList);
m_nImgListCnt = pImgList->GetImageCount();

m_clTreeImageList.Create(16,16,ILC_COLOR32|ILC_MASK,0,1);
m_clTreeImageList.SetBkColor(GetSysColor(COLOR_3DFACE));

//IMAGEINFO pImageInfo;
HICON hIcon;

for(long cnt = 0; cnt < m_nImgListCnt; cnt++)
{
hIcon = pImgList->ExtractIcon(cnt);
int nRet = m_clTreeImageList.Add(hIcon);
}

David Crow17-Oct-06 6:32

Re: how to extract the system icons and add them to our CImageList object??

17-Oct-06 6:32

indra20 wrote:
m_nImgListCnt = pImgList->GetImageCount();

What is the value of m_nImgListCnt?

Just a guess, but what happens if you make pImgList a member variable instead? I'm just curious if m_clTreeImageList.Add(hIcon) is making its own copy of hIcon, or if by the time the icons need to be rendered in the tree control, the icon handles no longer exist.

"Approved Workmen Are Not Ashamed" - 2 Timothy 2:15

"Judge not by the eye but by the heart." - Native American Proverb

indra2017-Oct-06 22:44

Re: how to extract the system icons and add them to our CImageList object??

17-Oct-06 22:44

Hi David,

Thanks for having a look at the problem we are facing.

I tried making pImgList a menmber, it didn't work.
m_nImgListCnt is 5.
Strangely on the Desktop icon which is the last in the list is getting displayed.
After trying to add the system icons we are adding our own icons to the list and those are geting displayed properly.

Thanks,
Indrajit

David Crow18-Oct-06 2:47

Re: how to extract the system icons and add them to our CImageList object??

18-Oct-06 2:47

indra20 wrote:
...is getting displayed.
...are geting displayed properly.

So what's the problem then?

"Approved Workmen Are Not Ashamed" - 2 Timothy 2:15

"Judge not by the eye but by the heart." - Native American Proverb

indra2018-Oct-06 20:10

Re: how to extract the system icons and add them to our CImageList object??

18-Oct-06 20:10

only five icons are there in the image list, and none of them are the icons that we want. Any way to retrive all the system icons??

thanks,
Indrajit

David Crow19-Oct-06 4:42

19-Oct-06 4:42

indra20 wrote:
only five icons are there in the image list, and none of them are the icons that we want.

Aren't you getting five desktop icons?

indra20 wrote:
...the system icons??

Such as?

"Approved Workmen Are Not Ashamed" - 2 Timothy 2:15

"Judge not by the eye but by the heart." - Native American Proverb

opening program

Tara1417-Oct-06 4:48

Tara14

17-Oct-06 4:48

Hello,

In order to open an existing project in vc++, we usually click on the .dsw file. This automatically loads all the files related to the project into vc++.

I want to create a program which saves data into a file with .spa extention. When the file is later clcked on, it should automatically opens into the program. Similar to .doc of MS Word, .m file of Matlab etc.

Please can you guide me on how to do this?

Thanks.

Fortitudine Vincimus!

Re: opening program

David Crow17-Oct-06 5:07

Re: Serial Number Via USB

17-Oct-06 5:07

This happens automatically if you create an SDI or MDI application. Otherwise, you'll need to create a .reg file, and then call the RegisterShellFileTypes() method in conjunction with EnableShellOpen().

"Approved Workmen Are Not Ashamed" - 2 Timothy 2:15

"Judge not by the eye but by the heart." - Native American Proverb

Re: opening program

Tara1417-Oct-06 6:47

Tara14

17-Oct-06 6:47

Thank you. I got an idea.

Fortitudine Vincimus!

Serial Number Via USB

VonHagNDaz17-Oct-06 3:43

VonHagNDaz

17-Oct-06 3:43

Hey guys and gals,

I have a question about obtaining the serial number of a USB device via the USB connection. Ive searched the MSDN documentation, and I know I have to use the _MEDIA_SERIAL_NUMBER_DATA structure, and a call to the DeviceIoControl() function with the IOCTL_STORAGE_GET_MEDIA_SERIAL_NUMBER flag as the second parameter; however, the documentation is unclear as to the proper way to open the device using CreateFile() to obtain the HANDLE for the first arguement for the DeviceIoControl()function. Any help or suggestions would be greatly appreciated.

David Crow17-Oct-06 4:01