|
How are you calling Maximum from VBA? From your fist post, seems like you're providing no arguments.
This has underwent so many changes that maybe it'd be a good idea to post again the (relevant) code in its current form.
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
In my first post you could see thge following code :
Public Declare Function Maximun Lib "D:\essai2\Debug\essai2.dll"(byval a as integer,byval b as integer) as integer
In fact, in a vba project linked to an excel workbook, i put this code into a module window. And that's all i do. So, i don't know if answer properly to your question!?!
regards
|
|
|
|
|
I mean, when you actually invoke the function Maximum, how do you do it? Do you actually pass two numbers?
Also, your firs posts are probably obsolete by know (for instance, I guess you already corrected the Maximun/Maximum typo), so it'd be great if you repost the code in its actual form.
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
Ok, i think that when you speak about invoking the function Maximum in VBA, it's to ask me how i use this function into another "sub or function", or how i do the declaration into vba? Because as i said below, i have only written into the module window the code the code you have read ("Public declare...") I didn't use any other function which call this routine, i call it directly from excel. Perhaps it's a mistake? And in excel, i put 2 values into 2 cells, for example, into A1 i put "2", and in A2, "5", so in another cell, i call the function Maximum thanks to the button "fx" in the toolbar. So, do i an error by proceeding like that?
thanks for your patience.
gerald
|
|
|
|
|
thanks for your patience.
No problem, we're building one of the most beatiful waterfall-like threads so far here in CP.
Well, please post your code (that is, the VBA import code and the C++ part) to see how it looks like now. Little help can be provided without that.
As for the means of invokation, in your particular scenario please locate the cursor on the cell where Maximum is invoked. At the upper area of Excel, just below the toolbars, you will have to see something like
=Maximum(A1;A2) Otherwise, you're probably calling your function the wrong way.
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
Ok, as the app i test is for the moment just a test, the following code, called essai2.cpp, have only one function, "Maximum". (I have made sthg simple to learn first the syntax before doing sthg more complex)
So:
// essai2.cpp : Defines the initialization routines for the DLL.
//
#include "stdafx.h"
#include "essai2.h"
#ifdef _DEBUG
#define new DEBUG_NEW
#undef THIS_FILE
static char THIS_FILE[] = __FILE__;
#endif
//
// Note!
//
// If this DLL is dynamically linked against the MFC
// DLLs, any functions exported from this DLL which
// call into MFC must have the AFX_MANAGE_STATE macro
// added at the very beginning of the function.
//
// For example:
//
// extern "C" BOOL PASCAL EXPORT ExportedFunction()
// {
// AFX_MANAGE_STATE(AfxGetStaticModuleState());
// // normal function body here
// }
//
// It is very important that this macro appear in each
// function, prior to any calls into MFC. This means that
// it must appear as the first statement within the
// function, even before any object variable declarations
// as their constructors may generate calls into the MFC
// DLL.
//
// Please see MFC Technical Notes 33 and 58 for additional
// details.
//
/////////////////////////////////////////////////////////////////////////////
// CEssai2App
BEGIN_MESSAGE_MAP(CEssai2App, CWinApp)
//{{AFX_MSG_MAP(CEssai2App)
// NOTE - the ClassWizard will add and remove mapping macros here.
// DO NOT EDIT what you see in these blocks of generated code!
//}}AFX_MSG_MAP
END_MESSAGE_MAP()
/////////////////////////////////////////////////////////////////////////////
// CEssai2App construction
CEssai2App::CEssai2App()
{
// TODO: add construction code here,
// Place all significant initialization in InitInstance
}
/////////////////////////////////////////////////////////////////////////////
// The one and only CEssai2App object
CEssai2App theApp;
extern "C" __declspec(dllexport) int Maximum(int a,int b)
{
AFX_MANAGE_STATE(AfxGetStaticModuleState());
int max;
if(a
|
|
|
|
|
Replace
extern "C" __declspec(dllexport) int Maximum(int a,int b) with
extern "C" __declspec(dllexport) int <font color=#ff0000>WINAPI</font> Maximum(int a,int b)
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
I have tried your suggestion without any success.
so in the vba code i've done a simple Sub, which only call the function Maximum and put the result into a excel's cell, as following:
///////////////////////////////////////////////////////////
Sub test22()
Cells(5, 5) = Maximum(2, 6)
End Sub
//////////////////////////////////////////////////////////
when i play it, i have the following error message:
(sorry but as my excel version is french, the error message is in english)
so:
"Entry point" Maximum of a dll which cannot be found in D:\essai2\Debug\essai2.dll.
Of course after this message, i have checked if the path was correct, and it was!!!
so, do you think that i'm unlucky
|
|
|
|
|
Ok, now I think we got it.
On the C++ part, leave it all as it is now (i.e., maintain the WINAPI thing, please).
On the VBA part, replace your declaration with the following:
Public Declare Function Maximum Lib "D:\essai2\Debug\essai2.dll" Alias "_Maximum@8" (Byval m1 as long,Byval m2 as long) as long I've tried it myself and it works, please tell me back if it did for you.
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
Et bien? (avec un air d'expectation)
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
Sorry for this later answer, but in my job i'm not a full-time programmer, so i have others things to do(conference...)
So, i tried your solution, and it didn't work at all, so i don't know what is wrong in my code or in sthg extern of the 2 environments. But, for the moment, i will try again checking if i haven't forgotten anything. So, before i will come back just a question, how do you find this solution, and what is this alias?
thanks a lot
|
|
|
|
|
just for information the C++ code and vba code:
//////VBA//////////////////////////////////////////////////
Public Declare Function Maximum Lib "D:\essai2\Release\essai2.dll" Alias "_Maximum@8" (ByVal m1 As Long, ByVal m2 As Long) As Long
Function test2(m As Long, n As Long)
test2 = Maximum(m, n)
If test2 = "" Then
test2 = 0
Else
test2 = test2
End If
End Function
Sub test22()
Cells(5, 5) = Maximum(2, 6)
//////C++/////////////////////////////////////////////////
/ essai2.cpp : Defines the initialization routines for the DLL.
//
#include "stdafx.h"
#include "essai2.h"
#ifdef _DEBUG
#define new DEBUG_NEW
#undef THIS_FILE
static char THIS_FILE[] = __FILE__;
#endif
//
// Note!
//
// If this DLL is dynamically linked against the MFC
// DLLs, any functions exported from this DLL which
// call into MFC must have the AFX_MANAGE_STATE macro
// added at the very beginning of the function.
//
// For example:
//
// extern "C" BOOL PASCAL EXPORT ExportedFunction()
// {
// AFX_MANAGE_STATE(AfxGetStaticModuleState());
// // normal function body here
// }
//
// It is very important that this macro appear in each
// function, prior to any calls into MFC. This means that
// it must appear as the first statement within the
// function, even before any object variable declarations
// as their constructors may generate calls into the MFC
// DLL.
//
// Please see MFC Technical Notes 33 and 58 for additional
// details.
//
/////////////////////////////////////////////////////////////////////////////
// CEssai2App
BEGIN_MESSAGE_MAP(CEssai2App, CWinApp)
//{{AFX_MSG_MAP(CEssai2App)
// NOTE - the ClassWizard will add and remove mapping macros here.
// DO NOT EDIT what you see in these blocks of generated code!
//}}AFX_MSG_MAP
END_MESSAGE_MAP()
/////////////////////////////////////////////////////////////////////////////
// CEssai2App construction
CEssai2App::CEssai2App()
{
// TODO: add construction code here,
// Place all significant initialization in InitInstance
}
/////////////////////////////////////////////////////////////////////////////
// The one and only CEssai2App object
CEssai2App theApp;
extern "C" __declspec(dllexport) int WINAPI Maximum(int a,int b)
{
AFX_MANAGE_STATE(AfxGetStaticModuleState());
int max;
if(a
|
|
|
|
|
What does "sthg" mean?
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
|
Are you here or not? because i'm totally lost...please
|
|
|
|
|
I posted a message to you directly by email, but it must have gotten lost in its way to your address...
Well, your code seems fine to me. As I was saying in that email, if you can afford sending me the whole stuff by email (the MFC project and the Excel sheet), I'll take a look at it this afternoon.
Apart from this, you'd be probably better off trying to obtain the help of someone near you with some expertise in this area.
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
i've found the solution in the vba references, in fact, in this dialog box i have flagged some specifics option as vc++ debug... and it works now, with exactly the code you submitted me before. So...
Now, i could really thank you for your patience.
regards
gerald
|
|
|
|
|
Would you be so kind as to passing me that VBA reference you're talking about? I'd like to learn something from this thread also
Congratulations and good luck with your project.
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
Gérald Mercet wrote:
"Entry point" Maximum of a dll which cannot be found in D:\essai2\Debug\essai2.dll.
THAT IS YOUR PROBLEM...
VB is a little fastidious for find functions in a dll....;)
You need to declare the EXPORT in the .def file
EXPORTS
@10 Maximum
Include the .def file in your project and ready.
Regards
Carlos Antollini.
Sonork ID 100.10529 cantollini
|
|
|
|
|
as you ask me yesterday, sorry to be late, but when you post it i believe that it wasn't the same hour in my office than in yours!
so you could see the following code C++ and VBA, for the moment it works, but perhaps you could think that it needs modifications?!?
// essai2.cpp : Defines the initialization routines for the DLL.
//
#include "stdafx.h"
#include "essai2.h"
#ifdef _DEBUG
#define new DEBUG_NEW
#undef THIS_FILE
static char THIS_FILE[] = __FILE__;
#endif
//
// Note!
//
// If this DLL is dynamically linked against the MFC
// DLLs, any functions exported from this DLL which
// call into MFC must have the AFX_MANAGE_STATE macro
// added at the very beginning of the function.
//
// For example:
//
// extern "C" BOOL PASCAL EXPORT ExportedFunction()
// {
// AFX_MANAGE_STATE(AfxGetStaticModuleState());
// // normal function body here
// }
//
// It is very important that this macro appear in each
// function, prior to any calls into MFC. This means that
// it must appear as the first statement within the
// function, even before any object variable declarations
// as their constructors may generate calls into the MFC
// DLL.
//
// Please see MFC Technical Notes 33 and 58 for additional
// details.
//
/////////////////////////////////////////////////////////////////////////////
// CEssai2App
BEGIN_MESSAGE_MAP(CEssai2App, CWinApp)
//{{AFX_MSG_MAP(CEssai2App)
// NOTE - the ClassWizard will add and remove mapping macros here.
// DO NOT EDIT what you see in these blocks of generated code!
//}}AFX_MSG_MAP
END_MESSAGE_MAP()
/////////////////////////////////////////////////////////////////////////////
// CEssai2App construction
CEssai2App::CEssai2App()
{
// TODO: add construction code here,
// Place all significant initialization in InitInstance
}
/////////////////////////////////////////////////////////////////////////////
// The one and only CEssai2App object
CEssai2App theApp;
extern "C" __declspec(dllexport) COleDateTime WINAPI Maximini(COleDateTime a,COleDateTime b)
{
AFX_MANAGE_STATE(AfxGetStaticModuleState());
COleDateTime max;
if(a
|
|
|
|
|
Gérald Mercet wrote:
so you could see the following code C++ and VBA, for the moment it works, but perhaps you could think that it needs modifications?!?
Because you are declaring the function in this way..
Public Declare Function Maximini Lib "D:\essai2\Debug\essai2.dll" Alias<br />
"_Maximini@8" (ByVal m1 As Long, ByVal m2 As Long) As Long
If you use a .def file you will can declare the function in the following way:
Public Declare Function Maximini Lib "D:\essai2\Debug\essai2.dll" (ByVal m1 As Long, ByVal m2 As Long) As Long
If your code works fine, great, but with my way you don't need to look for the internal name in the dll. That is the unique difference...
Gérald Mercet wrote:
as you ask me yesterday, sorry to be late, but when you post it i believe that it wasn't the same hour in my office than in yours!
Not problem: I live in South America, And we have several hours of diffence, and plus I'm in vacation, only I am in CP, because I can't live without CP.
Regards...
Carlos Antollini.
Sonork ID 100.10529 cantollini
|
|
|
|
|
I have a MDI application of CListView.
One of the listviews has a maximum of 20 entries(rows) with various column data and settings.
In one of the settings I would like the user to configure a keyboard accelerator key or hotkey for each row. When the user double clicks on a row a dialog box opens which allows the user to enter the hotkey in an EditBox.
I have read about ACCEL table, CreateAcceleratorTable, TranslateAccelerator and PreTranslateMessage, but is does not make sense to me at this time.
Can someone please show what the code for this look like.
Thanks
|
|
|
|
|
I don't know if got your problem well,but first you can ovverriden NM_DBCLK of your view,and inside it create your dialog class,and in your dialog class use WM_SETHOTKEY or WM_SYSCOMMAND
Mazy
Don't Marry a Person You Can Live With...
Marry Someone You Can Not Live Without
|
|
|
|
|
Thanks. I do appreciate you input.
I still have no joy though. I read the info on the MSDN but it makes little sense to me. The sample code are not relevant to MFC. It could be that I do not have the latest MSDN Cds.
I am not sure whether I am way off the tracks,
but would appreciate any help on this.
This is what I have in mind at the moment :
typedef struct _Accel
{
BYTE fVirt;
WORD Key;
WORD cmd;
}Accel;
class MyListView : public CListView {
public :
Accel *pAccel;
HACCEL haccel;
int count; // number of hotkeys can be defined
.....
};
// in the CPP file
// in class constructor
void MyListView :: MyListView ()
{
count = 20;
haccel = CreateAcceleratorTable(pAccel, count);
}
void MyListView :: OnDblclk (...., ....)
{
// assign hotkey string to structure
...
// I DO NOT KNOW HOW TO ASSIGN THE HOTKEY TO THE PARTICULAR ID RESOURCE NAME
...
}
void MyListView :: OnKeyDown (....)
{
// read the key being pressed and activate the neccessary toolbar button
HOW IS THIS DONE
}
// DestroyAcceleratorTable when application closes
...
.....
Thanks
Louis
|
|
|
|
|
As far as I can tell from my experimentation with the accelerators functions, you need to do something like the following. In my example, the user would hold down Ctrl and a key they have assigned to the item.
you have the following member variables in your header file:
ACCEL* m_pAccel; //pointer to an array of ACCEL structs
HACCEL m_hAccel; //the actual accel table
int m_count; //number of accelerators
in your implementation file:
//your constructor
void MyListView :: MyListView ()
{
m_count = 20;
m_pAccel = new ACCEL[count];
}
//your handler for double click
void MyListView :: OnDblClk(....,....)
{
int index = HitTest(....,....);
...
// store hotkey information
pAccel[index].fVirt = FCONTROL|FVIRTKEY; //virtual keys work best imho
pAccel[index].key = VK_1; //the key
pAccel[index].cmd = IDM_FIRST_ROW; //a menu id
...
//unregister the hotkeys
::DestroyAcceleratorTable( hAccel );
//register the hotkeys
hAccel = ::CreateAcceleratorTable( pAccel, count );
}
//your handler for pre-translate message
BOOL MyListView :: PreTranslateMessage(MSG* pMsg)
{
::TranslateAccelerator( this->GetSafeHwnd(), hAccel, pMsg );
return CListView::PreTranslateMessage(pMsg);
}
Good luck. 
Sef Tarbell
"A mind all logic is like a knife all blade, it makes the hand bleed that wields it." --Rabindranath Tagore
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
