C / C++ / MFC

11-Aug-02 5:47

My app is crashing on machines that aren't equipped with a lot of memory due to the fact that it is eating up all of the system's GDI resources and, apparently, not freeing them. I'm trying to figure out what I'm doing wrong. I've tried DeleteObject after creating a CPen, selecting it into the DC, using it, and selecting the old pen back into the DC as I have read on this message board and in the MSDN library and it hasn't worked. I've also tried using the CAutoPen class that I found on this site for creating a CPen, selecting it into the DC, and selecting the old pen back into the DC when the pen goes out of scope. Nothing seems to be working to give back the GDI resources. Does anyone have any ideas as far as what they think I might be missing?

C^hris L^osinger11-Aug-02 6:22

11-Aug-02 6:22

are you using other GDI resources, besides CPen (CBrush, CBitmap, etc) ?

-c

Conservative:
One who admires radicals centuries after they're dead.
-- Leo C. Rosten

Stew11-Aug-02 14:32

11-Aug-02 14:32

I'm using CPen, CFont, and CRgn

C^hris L^osinger11-Aug-02 14:33

11-Aug-02 14:33

are you doing the same :

CGDIObejct *pOld = dc.SelectObejct(&newObj);
...
dc.SelectObject(pOld);
newObj.DestroyObject();

sequence for all of them?

-c

Conservative:
One who admires radicals centuries after they're dead.
-- Leo C. Rosten

Stew11-Aug-02 14:42

11-Aug-02 14:42

I'm not selecting the region into the DC or deleting it or anything. You think that might be my issue? The only thing is. I've whittled down my app, for testing to find this problem, to not do anything except let me draw a line. In the line class, I have the selectobject and deleteobject calls for the pen and it still eats the GDI memory like crazy because I redraw it each time I mouse over it. But the function for drawing the line when I first draw it or when I mouse over it and off of it is the same function. I'm not sure what I'm missing, but it's obviously something.

C^hris L^osinger11-Aug-02 14:44

11-Aug-02 14:44

can you post the line-only code?

-c

Conservative:
One who admires radicals centuries after they're dead.
-- Leo C. Rosten

Stew11-Aug-02 14:53

11-Aug-02 14:53

Here is the Constructor:

CLine::CLine(CPoint Start, CPoint End, COLORREF aColor, int aWidth, int aStyle, int aType, int aRouteType)
{
m_StartPoint = Start;
m_EndPoint = End;
m_Color = aColor;
m_Width = aWidth;
m_Style = aStyle;
m_StartPointRect = (0,0,0,0);
m_EndPointRect = (0,0,0,0);
m_Type = aType;
m_RouteType = aRouteType;
m_StartPointRect = CRect(m_StartPoint.x-3, m_StartPoint.y-3, m_StartPoint.x+3, m_StartPoint.y+3);
m_EndPointRect = CRect(m_EndPoint.x-3, m_EndPoint.y-3, m_EndPoint.x+3, m_EndPoint.y+3);

TermRectRgnPts[0] = CPoint(m_EndPoint.x, m_EndPoint.y - RADIUS);
TermRectRgnPts[1] = CPoint(m_EndPoint.x + RADIUS, m_EndPoint.y);
TermRectRgnPts[2] = CPoint(m_EndPoint.x, m_EndPoint.y + RADIUS);
TermRectRgnPts[3] = CPoint(m_EndPoint.x - RADIUS, m_EndPoint.y);

m_RouteTermRect = CRect(m_EndPoint.x - RADIUS, m_EndPoint.y - RADIUS, m_EndPoint.x + RADIUS, m_EndPoint.y + RADIUS);

m_EnclosingRect = CRect(Start, End);
m_EnclosingRect.NormalizeRect();

m_StartPtScreenPct.XPercent = 0.0;
m_StartPtScreenPct.YPercent = 0.0;
m_EndPtScreenPct.XPercent = 0.0;
m_EndPtScreenPct.YPercent = 0.0;

}

Here is the Draw Function:

void CLine::Draw(CDC* pDC, int aStyle, int aWidth, CElement* pElement, int aRouteType)
{
//Create a pen and initialize it to the object color and line width of 1 pixel
CPen aPen;
COLORREF aColor = m_Color;

m_DC = pDC;

if(this == pElement)
{
aColor = SELECT_COLOR;
m_Style = aStyle;
m_Width = aWidth;
//m_Width = 0;
}
if(!aPen.CreatePen(PS_SOLID, m_Width, aColor))
{
// Pen creation failed. Abort the program
AfxMessageBox("Pen creation failed drawing a line", MB_OK);
AfxAbort();
}

unsigned Type1[4];
int c1 = GetPattern(Type1, true, m_Width, aStyle);

CPen *pOldPen;

SetPattern(Type1, c1);
{
// do drawing inside path for win95/8 compatibility
pDC->BeginPath();
MoveTo(m_StartPoint);
LineTo(m_EndPoint);
pDC->EndPath();

LOGBRUSH lbrush;
lbrush.lbStyle = BS_SOLID;
lbrush.lbColor = aColor;
CPen Pen(PS_GEOMETRIC | PS_SOLID |
(true ?
(PS_JOIN_ROUND | PS_ENDCAP_ROUND):
(PS_JOIN_MITER | PS_ENDCAP_FLAT) ) , m_Width, &lbrush);
pOldPen = m_DC->SelectObject(&Pen);
pDC->StrokePath();
pDC->SelectObject(pOldPen);
aPen.DeleteObject();

// make pen and stroke path
//DrawPathOutline(aColor);
}

pOldPen = pDC->SelectObject(&aPen);

/*pDC->MoveTo(m_StartPoint);
pDC->LineTo(m_EndPoint);*/

if (aRouteType != 0)
{
int Xv, Yv;
int Xp, Yp;
int C = 14;
double Xprime, Yprime;
CPoint PerpEndPoint, PerpStartPoint;

Xv = m_EndPoint.x - m_StartPoint.x;
Yv = m_EndPoint.y - m_StartPoint.y;

Xp = Yv;
Yp = (-1) * Xv;

Xprime = ( Xp / sqrt( Xp * Xp + Yp * Yp )) * C / 2;
Yprime = ( Yp / sqrt( Xp * Xp + Yp * Yp )) * C / 2;

PerpStartPoint.x = (long)(m_EndPoint.x + Xprime);
PerpStartPoint.y = (long)(m_EndPoint.y + Yprime);
PerpEndPoint.x = (long)(m_EndPoint.x - Xprime);
PerpEndPoint.y = (long)(m_EndPoint.y - Yprime);

if (aRouteType == ROUTE_TYPE_PASS)
{
CArray <cpoint, cpoint=""> ArrowPointArray;
CPoint ArrowPoint;
LPPOINT test;
tagPOINT *PerpStart, *PerpEnd, *Arrow;

ArrowPoint.x = (long)(((Xv / sqrt( Xv * Xv + Yv * Yv)) * C/2) + m_EndPoint.x);
ArrowPoint.y = (long)(((Yv / sqrt( Xv * Xv + Yv * Yv)) * C/2) + m_EndPoint.y);

ArrowPointArray.Add(PerpStartPoint);
ArrowPointArray.Add(PerpEndPoint);
ArrowPointArray.Add(ArrowPoint);

/* Draw the route terminator for blocking routes */
pDC->BeginPath();
pDC->MoveTo(PerpStartPoint);
pDC->LineTo(PerpEndPoint);
pDC->LineTo(ArrowPoint);
pDC->LineTo(PerpStartPoint);
pDC->EndPath();

}
else
{
/* Draw the route terminator for blocking routes */
pDC->BeginPath();
pDC->MoveTo(PerpStartPoint);
pDC->LineTo(PerpEndPoint);
pDC->EndPath();
}

// make pen and stroke path
DrawPathOutline(aColor);
}

pDC->SelectObject(pOldPen);
delete[] m_Pattern;
aPen.DeleteObject();
}

C^hris L^osinger11-Aug-02 14:58

11-Aug-02 14:58

Stew wrote:
LOGBRUSH lbrush;
lbrush.lbStyle = BS_SOLID;
lbrush.lbColor = aColor;
CPen Pen(PS_GEOMETRIC | PS_SOLID |
(true ?
(PS_JOIN_ROUND | PS_ENDCAP_ROUND):
(PS_JOIN_MITER | PS_ENDCAP_FLAT) ) , m_Width, &lbrush);
pOldPen = m_DC->SelectObject(&Pen);
pDC->StrokePath();
pDC->SelectObject(pOldPen);
aPen.DeleteObject();

here, you're creating and selecting "Pen", but doing a DeleteObject on aPen.

?

-c

Conservative:
One who admires radicals centuries after they're dead.
-- Leo C. Rosten

Stew11-Aug-02 15:17

11-Aug-02 15:17

Minor mishap. With all the things I've been trying, I missed that. At any rate, I changed it and it's still usurping all of the GDI resources and not freeing them. Let me ask you this, do cursors take up GDI resources? I don't think they do, but I'm not sure.

C^hris L^osinger11-Aug-02 16:32

11-Aug-02 16:32

i don't think so.

this is probably something really simple, but easy to overlook...

-c

Conservative:
One who admires radicals centuries after they're dead.
-- Leo C. Rosten

Mustafa29-Jun-03 18:11

Mustafa

29-Jun-03 18:11

Hi Stew,

I am currently facing the same problem...did you solve it??. I noticed that GDI resource are returned properly to system after calling StrokePath() or StrokeAndFillPath().

My code

<br />
pDC->BeginPath();// GDI used<br />
pDC->MoveTo(some point);<br />
pDC->LineTo(another point);<br />
pDC->EndPath();<br />
pDC->WidenPath();<br />
HRGN hRgn=::PathToRegion(pDC->GetSafeHdc());<br />
::FillRgn(pDC->GetSafeHdc(),m_hLastSecondRgn,(HBRUSH)GreyBrush);<br />

This code doesn't return GDI resource...please help cause I have been stuck on this for quite some time now...
Regards
Mustafa

Internetworking with TCP/IP Vol. III Client-Server Programming and Applications-Windo

cmk29-Jun-03 18:17

cmk

29-Jun-03 18:17

I am pretty sure MFC does a lot of caching which will make it that much harder to determine if/where you have a leak as the memory will not be releasing when you think it should.
May want to try straight Win32 first - if you haven't already.

...cmk

smallcoder11-Aug-02 4:36

smallcoder

11-Aug-02 4:36

yes as the title is saying i'm searching for a book that can give me enougth stuff for network code

i've one book :
Network Programming for Microsoft Windows, Second Edition

it help me learning about winsocks.
but as i want to learn about instant messaging or ftp server and plus someone advise me this book :

Internetworking with TCP/IP Vol. III Client-Server Programming and Applications-Windows Sockets Version

has someone read or heard about this book and can give me some advises it would be helpfull for me

or if you know a links for download online books it would be helpfull too

if you think that you can't , that means that you can : if you understand this there youn can

Re: Internetworking with TCP/IP Vol. III Client-Server Programming and Applications-Windo

Ancient Dragon11-Aug-02 10:58

Ancient Dragon

11-Aug-02 10:58

Search www.amazon.com

http://www.amazon.com/exec/obidos/search-handle-form/102-9678160-8616910

Re: Internetworking with TCP/IP Vol. III Client-Server Programming and Applications-Windo

cmk29-Jun-03 18:21

cmk

29-Jun-03 18:21

For instant messaging you can download the TOC specification from AOL.
It is their 'open source' protocol (as opposed to OSCAR their proprietary).
There are also a lot of open source projects that wrap the various IM protocols (AIM, Yahoo IM, MSN, ...).

...cmk

TSR kind...

fdmanana11-Aug-02 4:12

fdmanana

11-Aug-02 4:12

Anyone knows a simple way to create a program which acts like a ms-dos TSR program, which doesn't appear minimized at the taskbar and doesn't appear the program's icon on the system tray? A program which will act exactly like a linux deamon. I trying to create a daemon which stays listening for incoming connection requests, and acts like a linux telnet deamon. Could you show me a code example just for that? Thanks.

Re: TSR kind...

C^hris L^osinger11-Aug-02 5:03

11-Aug-02 5:03

time to learn about NT services.

-c

Conservative:
One who admires radicals centuries after they're dead.
-- Leo C. Rosten