C / C++ / MFC

Chuck O'Toole24-Sep-12 5:16

Chuck O'Toole

24-Sep-12 5:16

+5. Great explanation. For me too, I've been reversing upcast and downcast terms, didn't think of the diagram. Saw the obvious error in his example though.

pasztorpisti24-Sep-12 6:00

24-Sep-12 6:00

Thank you!

pasztorpisti24-Sep-12 6:19

24-Sep-12 6:19

Regarding the upcast/downcast naming: A lot of coders exchange these names so when someone starts using them I always ask him to clarify how to interpret "his upcast" right at the start of the conversation. I also used them in reverse order for a long time until reading some uml docs that clarified it for me. For some reason thinking that upcast is casting up to a higher level smarter derived class seemed to be more logical for me. Smile | :)

Question about MFC implementation

Chuck O'Toole24-Sep-12 7:53

Chuck O'Toole

24-Sep-12 7:53

Which is how I use "upcast", to a "bigger" container, the derived class. Of course, that's just a convenience notation. The real idea is

Cast Derived to Base - OK
Cast Base to Derived - Bad

CallBack Function

Smart Arab23-Sep-12 4:47

Smart Arab

23-Sep-12 4:47

Hi, have a good day
I am using Already built DLL , with callback function inside it :

After I execute this code my application freeze ( SomeCallback : read only once ) and freeze

I don't know what is wrong ?

DLL Define code ( DLL is open source ) :

C++

typedef int __stdcall cbtype (char *what, Number int1, Number int2, char *str);

extern "C" int __cdecl FreeArcExtract (cbtype *callback, ...);

My Code :

#include <cstdlib>
#include <iostream>
#include "windows.h"

using namespace std;

typedef bool  (*cbtype)  (char *what, int, int, char *str);

bool SomeCallback( char *c1 , int i1 , int i2, char *c2)
{
     printf("%s\r\n" , c1);
     printf("%d\r\n" , i1);
     printf("%d\r\n" , i2);
     printf("%s\r\n" , c2);
     return true;
}

void ArcExtract ()
{  
	
	HINSTANCE GetProcDLL = LoadLibrary("unarc.dll");
    FARPROC GetProcessID = GetProcAddress(
HMODULE (GetProcDLL), "FreeArcExtract");

	typedef int (__cdecl * CallingFun)(cbtype, LPCTSTR , LPCTSTR, LPCTSTR , LPCTSTR,LPCTSTR , LPCTSTR,LPCTSTR , LPCTSTR,LPCTSTR , LPCTSTR);

    CallingFun FreeArcExtract;
    FreeArcExtract = CallingFun(GetProcessID);
	
	FreeArcExtract((cbtype)SomeCallback,
"l", "--", "d:\\test.arc", "", "", "", "", "", "", "");
    FreeLibrary(GetProcDLL);
}

int main(int argc, char *argv[])
{
    ArcExtract ();
    //system("pause");

    return EXIT_SUCCESS;
}

I think the error are in the call back function

I write the same code on C# and it's work like charming.

with same dll , and the same d:\test.arc

C# Code :

class ArcArchive
        {
            public delegate bool unarcCallBack(string what, int param1, int param2, string text2);

            [DllImport("unarc.dll")]
            public static extern int FreeArcExtract(unarcCallBack callback, 
string cmd1, string cmd2, string cmd3, string cmd4, string cmd5, string cmd6, string cmd7, string cmd8, string cmd9, string cmd10);
        }

        static void Main(string[] args)
        {
            ArcArchive.unarcCallBack ArcCallBack = new ArcArchive.unarcCallBack(CallBackFunction);
            ArcArchive.FreeArcExtract(ArcCallBack,
 "l", "--", "d:\\test.arc", "", "", "", "", "", "", "");
        }

        static bool CallBackFunction(string what, int param1, int param2, string t2)
        {

            Console.WriteLine(what);
            Console.WriteLine(param1);
            Console.WriteLine(param2);
            Console.WriteLine(t2);
            return true;

        }

please is there is anyway to write callback function in c++ ? or is my c++ code had some logical errors.

Thank you

Re: CallBack Function

Mohibur Rashid23-Sep-12 6:06

Mohibur Rashid

23-Sep-12 6:06

You have mixed up a lot, specially with typedef and function pointer definition and usage. To understand function pointer definition clearly read about Function Pointer[^]. Also look at wiki link[^] to learn about typedef in detail.

To solve your problem
1. write include of windows.h as
#include <windows.h>
and it has nothing to do with your problem

2. If you have the .lib file then it is great just include the header file as below:
#include "the_header_file.h"

and also include the library file with your project.

if you dont have then follow the code it might help:

C++

#include <cstdlib>
#include <iostream>
#include <windows.h>
 
using namespace std;
 
typedef bool  (*cbtype)  (char *what, int, int, char *str);
 
bool SomeCallback( char *c1 , int i1 , int i2, char *c2)
{
     printf("%s\r\n" , c1);
     printf("%d\r\n" , i1);
     printf("%d\r\n" , i2);
     printf("%s\r\n" , c2);
     return true;
}
 
void ArcExtract ()
{  
	
	HINSTANCE GetProcDLL = LoadLibrary("unarc.dll");
	if(GetProcDLL==NULL)
        {
		//handle error
	}
 
	typedef int (__cdecl * CallingFun)(cbtype, ...);
 
    	CallingFun FreeArcExtract;
    FreeArcExtract =(CallingFun) GetProcAddress(HMODULE (GetProcDLL), "FreeArcExtract");
	if(FreeArcExtract==NULL)
	{
		//handle error
	}
	FreeArcExtract((cbtype)SomeCallback,
"l", "--", "d:\\test.arc", "", "", "", "", "", "", "");
    FreeLibrary(GetProcDLL);
}
 
int main(int argc, char *argv[])
{
    ArcExtract ();
    //system("pause");

    return EXIT_SUCCESS;
}

I wish I could believe there is an after life.

Re: CallBack Function

Smart Arab24-Sep-12 1:39

Smart Arab

24-Sep-12 1:39

Thank you Sir, I have Solved the problem

Here is the Fixed Code

#include <cstdlib>
#include <iostream>
#include <windows.h>

using namespace std;

typedef int __stdcall cbtype (char *what, int int1, int int2, char *str);

int  __stdcall somecallback (char *what, int int1, int int2, char *str)
{
   cout << what << endl;
   cout << int1 << endl;
   cout << int2 << endl;
   cout << str << endl;
}

void ArcExtract ()
{  
	
	HINSTANCE GetProcDLL = LoadLibrary("unarc.dll");
    FARPROC GetProcessID = GetProcAddress(HMODULE(GetProcDLL), "FreeArcExtract");
    
	typedef int (__stdcall * CallingFun)(cbtype, ...);

    CallingFun FreeArcExtract;
    FreeArcExtract = CallingFun(GetProcessID);
 
	FreeArcExtract(somecallback,"l", "--", "d:\\test.arc", "", "", "", "", "", "", "");

    FreeLibrary(GetProcDLL);
}

int main(int argc, char *argv[])
{
    ArcExtract ();
    system("pause");

    return EXIT_SUCCESS;
}

Jian Jun Liu23-Sep-12 2:33

Jian Jun Liu

23-Sep-12 2:33

Can anybody tell me why there are TWO implementations for the MFC message map? I think the non _AFXDLL version will be OK in both the static library and dynamic library.

#ifdef _AFXDLL
#define DECLARE_MESSAGE_MAP() \
private: \
	static const AFX_MSGMAP_ENTRY _messageEntries[]; \
protected: \
	static AFX_DATA const AFX_MSGMAP messageMap; \
	static const AFX_MSGMAP* PASCAL _GetBaseMessageMap(); \
	virtual const AFX_MSGMAP* GetMessageMap() const; \

#else
#define DECLARE_MESSAGE_MAP() \
private: \
	static const AFX_MSGMAP_ENTRY _messageEntries[]; \
protected: \
	static AFX_DATA const AFX_MSGMAP messageMap; \
	virtual const AFX_MSGMAP* GetMessageMap() const; \

#endif

pasztorpisti23-Sep-12 3:20

23-Sep-12 3:20

I have never noticed this but partly the answer is obvious if you take a look at the name of the defined identifier after the #ifdef, its _AFXDLL. The MFC libraries can be linked statically into your executable/DLL or you can choose to be linked dynamically so that your program will depend on the existence of an mfc library dll where your program is used. It seems that they needed different macros to wire together their system in these 2 different cases but this is a tiny implementation detail inside MFC you dont have to be aware of. In general you often have to handle some problems specially when you put part of your code into a DLL, but its not important what their reason was for creating those 2 different defines because they provide the same interface for you.

Jian Jun Liu24-Sep-12 15:01

Jian Jun Liu

24-Sep-12 15:01

Thanks a lot.

pasztorpisti24-Sep-12 15:23

24-Sep-12 15:23

You are welcom!

Jian Jun Liu26-Sep-12 16:59

Jian Jun Liu

26-Sep-12 16:59

I noticed that the latest MFC messageMap has a new implementation, it is not ambiguous anymore! there is no _AFXDLL version.

Chris Meech23-Sep-12 4:57

Chris Meech

23-Sep-12 4:57

pasztorpisti has gven you some good advice and I would just add to it, to ensure that you do not mix MFC within an application. By that, I mean if you are building a DLL for an application and that application uses MFC linked statically, then ensure that your DLL has MFC linked statically as well. The converse is also true. If the application links MFC dynamically, then ensure that you're DLL links MFC dynamically. Smile | :)

Chris Meech
I am Canadian. [heard in a local bar]

In theory there is no difference between theory and practice. In practice there is. [Yogi Berra]

posting about Crystal Reports here is like discussing gay marriage on a catholic church’s website.[Nishant Sivakumar]

pasztorpisti23-Sep-12 7:34

23-Sep-12 7:34

Agree, very useful info to help avoiding some disasters.

What makes C and C++ a "good" language?

Chris Meech23-Sep-12 12:03

Chris Meech

23-Sep-12 12:03

Thanks.

source code

pei0825010321-Sep-12 15:51

pei08250103

21-Sep-12 15:51

how to watch the code of the software of th ImageStone?
why I cannot see the code of some function? Confused | :confused:

,
for example how the see the function code of colour level,

Re: source code

Richard MacCutchan21-Sep-12 21:13

Richard MacCutchan

21-Sep-12 21:13

If you have the source code then you need to build it in Debug mode. If you do not have the source code then see here[^].

One of these days I'm going to think of a really clever signature.

Brandon-X1200018-Sep-12 16:06

Brandon-X12000

18-Sep-12 16:06

Can someone tell me why C++ and C programming languages are used than any other programming languages, what can these languages do that others can't. I do know that C can create drivers or system files, which is very important when you become serious about your projects. But why is the industry still use it? And will C or C++ ever die, even though it's a non-stop updating language everyday, and what other languages update just like C/C++.

EDIT:
While also asking this question, will C++/CLI take over or kill out Standard/Win32 C++?

Cause I'm on a website called Codejock Software, looking for a ribbon control to work for Standard/Win32 C++ only, and I can't find it. Most of the controls are only made for C++/CLI.

Simple Thanks and Regards,
Brandon T. H.

Programming in C and C++ now, now developing applications, services and drivers (and maybe some kernel modules...psst kernel-mode drivers...psst).

Many of life's failures are people who did not realize how close they were to success when they gave up. - Thomas Edison

modified 3-Oct-12 14:46pm.

Richard Andrew x6418-Sep-12 16:20

Richard Andrew x64

18-Sep-12 16:20

Brandon T. H. wrote:
what can these languages do that others can't.

Directly access the hardware, directly manage memory, and create high performance code.

(As opposed to managed languages)

The difficult we do right away...
...the impossible takes slightly longer.

image processing toolkits | batch image processing

C^hris L^osinger18-Sep-12 16:37

C^hris L^osinger

18-Sep-12 16:37

Brandon T. H. wrote:
But why is the industry still use it?

because it still works.

Brandon T. H. wrote:
even though it's a non-stop updating language everyday, and what other languages update just like C/C++

C++ has had all of four official standard changes since 1998.

Stephen Hewitt18-Sep-12 18:46

Stephen Hewitt

18-Sep-12 18:46

Stop worrying about mortality, it's of little use.

Steve

CPallini18-Sep-12 21:27

CPallini

18-Sep-12 21:27

If you know them then you know the reason why.
On the other hand, if you don't know them, it's time to learn.
Smile | :)

Veni, vidi, vici.

pasztorpisti19-Sep-12 2:47

19-Sep-12 2:47

The C and C++ languages are disastrous. They leave so many doors open for bugs and programming mistakes and they have other design failures (like header files that terribly slow down the compile time). The only valid reason for their existence is that most of today's libraries and operating systems are written using these languages. The interface of the majority of libraries and operating system APIs are still C based. Even if you try to replace these languages I think you need 3 different languages to build a whole operating system up on top of bare hardware. A minimal amount of assembly to communicate with hardware, a thin layer of relatively high level but unsafe language that allows for manual memory management in the low-level part of the operating system, and a high level safe language that can be used to write the top level of the operating system and the user programs. C/C++ could be something like the middle from these 3 languages but it would be easier to design a much better language than C/C++ with the same capabilities. Again, the only reason for the existence of C/C++ is massive amount of legacy code.

EDIT: This post of mine became quite 'popular', for this reason I would like to link one of my other posts that contains a more comprehensive (but not full) list of my reasonings at the end of this quite long debate: http://www.codeproject.com/Messages/4377527/Re-What-makes-C-and-Cplusplus-a-good-language.aspx[^]
Also would like to mention that I have extensive background in low level programming including assembly, C, and C++, reverse engineering and I'm not a 'just because'-type of hater of C/C++ who used only scripts and managed languages - I don't hate C/C++ at all. I respect these languages because they have been fun for me to program in, they helped the world to become better, but we have to see their obvious defects as well. Thanks for reading.

modified 25-Sep-12 8:47am.

Richard MacCutchan19-Sep-12 4:03

Richard MacCutchan

19-Sep-12 4:03

pasztorpisti wrote:
The C and C++ languages are disastrous.

I think this is rather unfair. C was created to make the writing of operating system code much easier; C++ was an improvement but still based around the same design goals. The fact that people wrote other programs using those languages is the fault of the developers rather than the languages. Yes, there are shortcomings compared with some modern languages, but neither C nor C++ were designed to do some of the work that people expect of it these days.

One of these days I'm going to think of a really clever signature.

pasztorpisti19-Sep-12 5:11