|
As KevinXli pointed out, make sure you pass large enough buffers and set the nMaxFilexxx members
of the OPENFILENAME struct accordingly.
Mark
Mark Salsbery
Microsoft MVP - Visual C++
"Great job team! Head back to base for debriefing and cocktails."
|
|
|
|
|
I've already tried using GetOpenFileName, and I gave it required buffer size which was greater then MAX_PATH, but it still failed.
Here's example code:
void TestLongFileBrowse()
{
TCHAR acPath[2048] = _T("\0");
OPENFILENAME ofn;
ZeroMemory(&ofn,sizeof(OPENFILENAME));
ofn.lStructSize = sizeof(OPENFILENAME);
ofn.nMaxFile = 2048;
ofn.lpstrFile = acPath;
if (GetOpenFileName(&ofn)) {
printf("Path length: %d\n", _tcslen(ofn.lpstrFile));
printf("Path: %S\n", ofn.lpstrFile);
} else printf("CommDlgExtendedError(): %d\n");
}
Top ten member of C++ Expert Exchange.
http://www.experts-exchange.com/Cplusplus
|
|
|
|
|
Are you using the Unicode version of GetOpenFileName()? Only the Unicode APIs support full paths longer than MAX_PATH
|
|
|
|
|
I've tried it with both UNICODE and ANSI.
Top ten member of C++ Expert Exchange.
http://www.experts-exchange.com/Cplusplus
|
|
|
|
|
Axter wrote: http://www.experts-exchange.com/Cplusplus
Non-existent page.
"A good athlete is the result of a good and worthy opponent." - David Crow
"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne
|
|
|
|
|
Axter wrote: I've tried using GetOpenFileName, but I get a "File name is invalid" error...
Which is different than FNERR_BUFFERTOOSMALL.
"A good athlete is the result of a good and worthy opponent." - David Crow
"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne
|
|
|
|
|
Will the following code get rid of any exception that might be thrown in a destructor
Session::~Session()
{ try {
logDestruction(this);
}
catch (...) { }
}
What are the scenarios in which a destructor is likely to riase an exception?
I have not seen in any prodution code with a destrcutor having a try/catch clause like above?
Comments
|
|
|
|
|
Throwing exceptions from constructors or destructors is a bad idea.
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001
|
|
|
|
|
That is what I thought. Isn't there something in the C++ standards about this?
"The clue train passed his station without stopping." - John Simmons / outlaw programmer
|
|
|
|
|
John Simmons / outlaw programmer wrote: Throwing exceptions from constructors or destructors is a bad idea
I don't think so.
BTW the OP snipped doesn't show an exception thrown from the contructor, it shows an exception handled inside it.
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
|
|
|
|
|
John Simmons / outlaw programmer wrote: Throwing exceptions from constructors or destructors is a bad idea.
Huh?  ;)
Mark Salsbery
Microsoft MVP - Visual C++
"Great job team! Head back to base for debriefing and cocktails."
|
|
|
|
|
It's just something I don't do.
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001
|
|
|
|
|
I don't know about the ctors but for the dtors, reference Effective C++ Third Edition by Scott Meyers.
Specifically, "Item 8: Prevent exceptions from leaving destructors"
There seem to be many schools of thought on this type of issue so I'm not claiming this is the gospel truth but it's worth a read.
|
|
|
|
|
I wasn't necessarily agreeing or disagreeing with John's comment. I meant more to open up a
discussion.
As far as destructors goes, I agree. It makes no sense. Destructors aren't called explicitly
and when they are called, one would have to have complete knowledge of when. It could be during
the unwinding of another exception. It doesn't even make sense for something exceptional to
happen during destruction anyway.
For constructors, I don't throw exceptions either. Maybe I'm old-school, but I prefer a two-part
construction/initialization if error handling is necessary.
For constructors I don't agree that one shouldn't throw exceptions. I don't think exceptions
should be used for error handling, nor do I think they were meant to be used that way. IMO they
were meant for exceptional cirumstances - something that happens out of the programmer and user's
control that is unrecoverable.
For framework/library development, however, where a programmer may use a class the wrong way, it
may be ok. An exception during the design/implementation phase can be useful to me at that
stage, maybe providing enough info to show me immediately what I did wrong.
Just my rambling 2-cents
Cheers,
Mark
Mark Salsbery
Microsoft MVP - Visual C++
"Great job team! Head back to base for debriefing and cocktails."
|
|
|
|
|
Mark Salsbery wrote: Maybe I'm old-school, but I prefer a two-part
construction/initialization if error handling is necessary.
I must be old school, too, because that is along the lines of my thinking. I have never put exception handling in the constructors/destructors and I don't plan on doing so. That's my 2 cents 
"The clue train passed his station without stopping." - John Simmons / outlaw programmer
|
|
|
|
|
Mark Salsbery wrote: Mark Salsbery
Microsoft MVP - Visual C++
congrats for becoming MVP!
"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow
cheers,
Alok Gupta
VC Forum Q&A :- I/ IV
Support CRY- Child Relief
|
|
|
|
|
Thank you Alok!
Are you a Visual C++ MVP??
Mark
Mark Salsbery
Microsoft MVP - Visual C++
"Great job team! Head back to base for debriefing and cocktails."
|
|
|
|
|
Mark Salsbery wrote: Are you a Visual C++ MVP??
yeah i am Visual C++ MVP too! [ ] but it is secret
"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow
cheers,
Alok Gupta
VC Forum Q&A :- I/ IV
Support CRY- Child Relief
|
|
|
|
|
ThatsAlok wrote: but it is secret
Well if I knew about it I'd say Congratulations to you as well! And I'd say I noticed you have
been an MVP for a while.
But since it's a secret, I know nothing
Cheers!
Mark
Mark Salsbery
Microsoft MVP - Visual C++
"Great job team! Head back to base for debriefing and cocktails."
|
|
|
|
|
Mark Salsbery wrote: And I'd say I noticed you have
been an MVP for a while.
i am mvp for past two year.. but still doing soul searching for same [ ].. he he he it nice to see you here
"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow
cheers,
Alok Gupta
VC Forum Q&A :- I/ IV
Support CRY- Child Relief
|
|
|
|
|
I have used similar code in my remote communications classes. My DTOR will close the comm connection, but if the reason the DTOR is being called is because the connection was already broken/disconnected, I needed to ensure that no exception interrupted the normal DTOR chain.
It may not be quite what the C++ designers had in mind but it works. At least with MS VC++. Besides, if they didn't want it to work, it woud have explicitly stated so in the ARM.
|
|
|
|
|
|
I have a program codeing under VC2005.
Now,I add a code block which works well in VC6.
But when I add the block to my VC2005 project,there are some linking errors occured.
I know it because the codes using template .but why it would work under VC6?
GOOD LUCK.
|
|
|
|
|
What errors? What template? 
Mark
Mark Salsbery
Microsoft MVP - Visual C++
"Great job team! Head back to base for debriefing and cocktails."
|
|
|
|
|
Now,I has found the problems.The codes used third part library with some templates it.I complied the third part library using VC2005,the error has gone.
Thanks all the same.
Best wishes
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
