C / C++ / MFC

Help about Message loop please

6-May-09 1:36

Does this[^] help? If so, can I point you to the source[^] of all my wisdom.

Java, Basic, who cares - it's all a bunch of tree-hugging hippy cr*p

reply2am5-May-09 23:53

5-May-09 23:53

Hi There,
I am using the following example to make Win32 tab control without using MFC.
Win32 SDK C Tab Control made easy[^]

There are some business reasons that I can only use Win32 API for this.

I am able to create the tab pages. But finding weird behaviour with the messageloop.

I am making an XLL, so my dialog is opened from a selection from Excel menu item.I get a dialog box with tabs on clicking this certain menu item. Each tab has some edit boxes and buttons. which all work fine except the TAB key doesnt work to move from one item to another.

I have implemented it the same way as in above program. The problem i face are:

1. When i click on the tabs, it shows me the correct child dialog. when i change the selection of tab, it goes to the correct next dialog. so everything works fine here. But when i click on any area in the child dialog (i.e to activate the message loop), The tab key starts working on that particular selected tab, BUT after this i am not able to select any other tab. On clickin on any other tab takes me to the first tab (iSel=0)
2. When I close the dialog box from the X button in top right corner; It closes the dialog box BUT it also closes my Excel window which i dont want.

This application I am developing to configure and test some connections. so I need the excel window open after i am done with the configurations.
Please reply if you read this message. I will appreciate any help.
Regards
Ajay
ajaymat@gmail.com

The code for message loop is here

HACCEL CAuthenticationAddin::CreateAccTable (VOID)
{
   static  ACCEL  aAccel[1];
   static  HACCEL  hAccel;

   aAccel[0].fVirt=FVIRTKEY;
   aAccel[0].key=VK_ESCAPE;
   aAccel[0].cmd=CMD_VK_ESCAPE;

   aAccel[1].fVirt=FVIRTKEY;
   aAccel[1].key=VK_RETURN;
   aAccel[1].cmd=CMD_VK_RETURN;

   hAccel=CreateAcceleratorTable(aAccel,1);
   return hAccel;
}


void CAuthenticationAddin::TabPageMessageLoop (HWND hwnd)
{
   MSG      msg;
   int      status;
   BOOL handled = FALSE;

   // Create Accelerator table

   HACCEL hAccTable = CAuthenticationAddin::CreateAccTable();

   while((status = GetMessage(&msg, NULL, 0, 0 )) != 0 && !stopTabPageMessageLoop)
   { 
      if (status == -1) // Exception

      {
         return;
      }
      else
      {
         // Dialogs do not have a WM_KEYDOWN message so we will seperate

         // the desired keyboard events here

         handled = TranslateAccelerator(hwnd,hAccTable,&msg);

         // Perform default dialog message processing using IsDialogM...

         if(!handled)
            handled=IsDialogMessage(hwnd,&msg);

         // Non dialog message handled in the standard way.

         if(!handled)
         {

            TranslateMessage(&msg);
            DispatchMessage(&msg);
         }
      }
   }
   if(stopTabPageMessageLoop) //Reset: do not PostQuitMessage(0)

   {
      DestroyAcceleratorTable(hAccTable);
      stopTabPageMessageLoop = FALSE;
      return;
   }

   // Default: Re-post the Quit message

   DestroyAcceleratorTable(hAccTable);
   PostQuitMessage(0);
   return;
}

VOID CAuthenticationAddin::ResetTabPageMessageLoop (HWND hwnd)
{
   //Toggle kill sw
   stopTabPageMessageLoop=TRUE;
   stopTabPageMessageLoop=FALSE;

   SetFocus(hwnd);
   CAuthenticationAddin::TabPageMessageLoop(hwnd);
}

Stuart Dootson6-May-09 1:40

6-May-09 1:40

Can I suggest you try debugging the XLL? It's just a DLL, so tell it to use Excel as its executable in the project's Debugging properties, set breakpoints on the relevant handlers and off you go.

Java, Basic, who cares - it's all a bunch of tree-hugging hippy cr*p

serzh836-May-09 1:54

serzh83

6-May-09 1:54

Can You list all code ?
Mey be you do not need this messgae loop.
May be you need only Tab WndProc.

reply2am6-May-09 4:32

6-May-09 4:32

Thanks for the reponses
I have debugged it ...
it all goes fine as long as you dont click on the tab(LBUTTONDOWN) or VK_DOWN ( to focus on the page) to start the message loop.
Once you start it, Id doesnt stop i guess.
during the debug:
1. When I only clicked on the tabs and NOT on the tab dialogs( meaning not called TabPageMessageLoop() function) I can change the tabs, use the buttons int he tabs ( without the tab key working for the traversal on the controls)
2. Once i click on the tab page, or i click the down key( which start the messahe loop so that the Tab key can work in the controls), Now the tab key starts working, but only on the currentl page and when u select another tab, it displays Tab number 0( the first tab) always. so in a way the tab selection doesnt work any more.

attached is the whole code required to analyse.
Please help me finding out where the loop resets the m_lptc pointer that it always points to tab-0.
Regards

 typedef struct TabControl 
	  {
	     HWND hTab;
	     HWND hVisiblePage;
	     HWND* hTabPages;
	     LPSTR *tabNames;
	     LPSTR *dlgNames;
	     int tabPageCount;
	     BOOL blStretchTabs;

	     // Function pointer to Parent Dialog Proc
	     BOOL (CALLBACK *ParentProc)(HWND, UINT, WPARAM, LPARAM);

	     // Function pointer to Tab Page Size Proc
	     void (*TabPage_OnSize)(HWND hwnd, UINT state, int cx, int cy);

	     // Pointers to shared functions
	     BOOL (*Notify) (LPNMHDR);
	     BOOL (*StretchTabPage) (HWND, INT);
	     BOOL (*CenterTabPage) (HWND, INT);
 
	  }TABCTRL, *LPTABCTRL;
     // static TABCTRL m_lptc;
	 static TABCTRL TabCtrl_1;
     static LPTABCTRL m_lptc;
#define CMD_VK_ESCAPE	101
#define CMD_VK_RETURN	102
///////////////////////////////////////////////////////////////////////////////
// Constants
///////////////////////////////////////////////////////////////////////////////
HINSTANCE g_hinst;     // Handle to application instance.
HWND hWndSummit;
static SIZE gMinSize;



static HWND frmMain;


static BOOL stopTabPageMessageLoop=FALSE;


void CAuthenticationAddin::Configure()
{
   try
   {
      g_hinst = m_hInstance;
      InitCommonControls();
      DialogBox(m_hInstance, MAKEINTRESOURCE(IDD_AUTH_TAB),NULL, (DLGPROC)AuthDialogProc); 
   }
   catch (CBaseException &e)
   {
      LoggedMessageBox(e, "Configure");
   }
   catch (...)
   {
      LoggedMessageBox("Unexpected exception", "Configure");
   }

   Log("CAuthenticationAddin::Configure() - after DisplayDialog()");
}





VOID CAuthenticationAddin::TabCtrl_OnKeyDown(LPARAM lParam)
{
	TC_KEYDOWN *tk=(TC_KEYDOWN *)lParam;
	int itemCount=TabCtrl_GetItemCount(tk->hdr.hwndFrom);
	int currentSel=TabCtrl_GetCurSel(tk->hdr.hwndFrom);
	
	if(itemCount <= 1) return; // Ignore if only one TabPage
	
	//BOOL verticalTabs = GetWindowLong(m_lptc->hTab, GWL_STYLE) & TCS_VERTICAL;
	switch (tk->wVKey)
	{
	case VK_NEXT: //select the previous page
		{
			if(0==currentSel) return;
			TabCtrl_SetCurSel(tk->hdr.hwndFrom, currentSel-1);
			//TabCtrl_SelectTab (tk->hdr.hwndFrom, currentSel-1);
			TabCtrl_SetCurFocus(tk->hdr.hwndFrom, currentSel-1);
		}
		break;
	case VK_LEFT: //select the previous page
		{
			if(0==currentSel) return;
			TabCtrl_SetCurSel(tk->hdr.hwndFrom, currentSel-1);
			TabCtrl_SetCurFocus(tk->hdr.hwndFrom, currentSel);
		}
		break;
	case VK_PRIOR: //select the next page
		{
			TabCtrl_SetCurSel(tk->hdr.hwndFrom, currentSel+1);
			TabCtrl_SetCurFocus(tk->hdr.hwndFrom,currentSel+1);
		}
		break;
	case VK_RIGHT: //select the next page
		{
			TabCtrl_SetCurSel(tk->hdr.hwndFrom, currentSel+1);
			TabCtrl_SetCurFocus(tk->hdr.hwndFrom,currentSel);
		}
		break;
	case VK_UP: //navagate within selected child tab page
		{
			SetFocus(m_lptc->hTabPages[currentSel]);
			CAuthenticationAddin::TabPageMessageLoop (m_lptc->hTabPages[currentSel]);
		}
		break;
	case VK_DOWN: //navagate within selected child tab page
		{
	           SetFocus(m_lptc->hTabPages[currentSel]);
               CAuthenticationAddin::TabPageMessageLoop (m_lptc->hTabPages[currentSel]);
		}
		break;  
	default: return;
	}
	
}

VOID CAuthenticationAddin::TabControl_GetClientRect(HWND hwnd,RECT* prc)
{
   RECT rtab_0;
   LONG lStyle = GetWindowLong(hwnd,GWL_STYLE); 

   // Calculate the tab control's display area
   GetWindowRect(hwnd, prc);
   ScreenToClient(GetParent(hwnd), (POINT*)&prc->left);
   ScreenToClient(hwnd, (POINT*)&prc->right);
   TabCtrl_GetItemRect(hwnd,0,&rtab_0); //The tab itself

   
   prc->top = prc->top + (6 + rtab_0.bottom-rtab_0.top); //x coord
   prc->left = prc->left + 4; //y coord
   prc->bottom = prc->bottom - (16 + rtab_0.bottom-rtab_0.top); // height
   prc->right = prc->right - 12; // width
   
}


BOOL CAuthenticationAddin::TabCtrl_OnSelChanged(VOID)
{
   stopTabPageMessageLoop = TRUE;
   int curSel = TabCtrl_GetCurSel(m_lptc->hTab);

   //Hide the current child dialog box, if any.
   ShowWindow(m_lptc->hVisiblePage,FALSE);

   //Show the new child dialog box.
   ShowWindow(m_lptc->hTabPages[curSel],TRUE);

   // Save the current child
   m_lptc->hVisiblePage = m_lptc->hTabPages[curSel];

   return TRUE;
}


BOOL CAuthenticationAddin::Notify (LPNMHDR pnm)
{
   // Update m_lptc pointer
   m_lptc = (LPTABCTRL) GetWindowLong(pnm->hwndFrom,GWL_USERDATA);

   switch (pnm->code)
   {
      case TCN_KEYDOWN:
         TabCtrl_OnKeyDown((LPARAM)pnm);
         // fall through to call TabCtrl_OnSelChanged() on each keydown

      case TCN_SELCHANGE:
         return TabCtrl_OnSelChanged();
   }
   return FALSE;
}


VOID CAuthenticationAddin::TabControl_Destroy(LPTABCTRL tc)
{
   for (int i=0;i<tc->tabPageCount;i++)
      DestroyWindow(tc->hTabPages[i]);

   free (tc->hTabPages);
}



BOOL CAuthenticationAddin::StretchTabPage (HWND hTab, INT iPage)
{
   RECT rect;

   // Update m_lptc pointer
   m_lptc = (LPTABCTRL) GetWindowLong(hTab,GWL_USERDATA);

   TabControl_GetClientRect(hTab, &rect); // left, top, width, height

   // Move the child and put it on top
   return SetWindowPos(m_lptc->hTabPages[iPage], HWND_TOP,
         rect.left, rect.top, rect.right, rect.bottom,
         0);

   return FALSE;//TEST
}
BOOL CAuthenticationAddin::CenterTabPage (HWND hTab, INT iPage)
{
   RECT rect, rclient;

   // Update m_lptc pointer
   m_lptc = (LPTABCTRL) GetWindowLong(hTab,GWL_USERDATA);

   TabControl_GetClientRect(hTab, &rect); // left, top, width, height

   // Get the tab page size
   GetClientRect(m_lptc->hTabPages[iPage], &rclient);
   rclient.right=rclient.right-rclient.left;// width
   rclient.bottom=rclient.bottom-rclient.top;// height
   rclient.left= rect.left;
   rclient.top= rect.top;

   // Center the tab page, or cut it off at the edge of the tab control(bad)
   if(rclient.right<rect.right)
      rclient.left += (rect.right-rclient.right)/2;

   if(rclient.bottom<rect.bottom)
      rclient.top += (rect.bottom-rclient.bottom)/2;

   // Move the child and put it on top
   return SetWindowPos(m_lptc->hTabPages[iPage], HWND_TOP,
         rclient.left, rclient.top, rclient.right, rclient.bottom,
         0);

   return FALSE;//TEST
}
VOID CAuthenticationAddin::TabPage_OnSize(HWND hwnd, UINT state, INT cx, INT cy)
{
   // Dummy function when no external on size function is
   // desired.
}

VOID CAuthenticationAddin::New_TabControl(LPTABCTRL lptc,
      HWND hTab,
      LPSTR *tabNames,
      LPSTR *dlgNames,
      BOOL (CALLBACK* ParentProc)(HWND, UINT, WPARAM, LPARAM),
      //BOOL CALLBACK (*ParentProc)(HWND, UINT, WPARAM, LPARAM)
      VOID (*OnSize)(HWND, UINT, int, int),
      BOOL fStretch)
{
   static TCITEM tie;
   m_lptc=lptc;

   //Link struct m_lptc pointer to hTab
   SetWindowLong(hTab,GWL_USERDATA,(long)m_lptc);

   m_lptc->hTab=hTab;
   m_lptc->tabNames=tabNames;
   m_lptc->dlgNames=dlgNames;
   m_lptc->blStretchTabs=fStretch;

   // Point to external functions
   m_lptc->ParentProc=ParentProc;
   /*if(NULL!=OnSize) //external size function
     m_lptc->TabPage_OnSize=OnSize;
     else //internal dummy size function
     m_lptc->TabPage_OnSize=TabPage_OnSize; */


   // Point to internal public functions
   m_lptc->Notify=&Notify;
   m_lptc->StretchTabPage=&StretchTabPage;
   m_lptc->CenterTabPage=&CenterTabPage;

   // Determine number of tab pages to insert based on DlgNames
   m_lptc->tabPageCount = 0;
   LPSTR* ptr=m_lptc->dlgNames;
   while(*ptr++) m_lptc->tabPageCount++;


   //create array based on number of pages
   m_lptc->hTabPages = (HWND*)malloc(m_lptc->tabPageCount * sizeof(HWND*));

   // Add a tab for each name in tabnames (list ends with 0)
   tie.mask = TCIF_TEXT | TCIF_IMAGE;
   tie.iImage = -1;



   for (int i = 0; i< m_lptc->tabPageCount; i++)
   {
      tie.pszText = m_lptc->tabNames[i]; 
      TabCtrl_InsertItem(m_lptc->hTab, i, &tie);

      // Add page to each tab
      if (i==0)
         m_lptc->hTabPages[i] = CreateDialog(g_hinst,
               m_lptc->dlgNames[i],
               GetParent(m_lptc->hTab),
               (DLGPROC)ConfigureSummitDialogProc);
      if (i==1)
         m_lptc->hTabPages[i] = CreateDialog(g_hinst,
               m_lptc->dlgNames[i],
               GetParent(m_lptc->hTab),
               (DLGPROC ) ConfigureRiskDialogProc);
      if (i==2)
         m_lptc->hTabPages[i] = CreateDialog(g_hinst,
               m_lptc->dlgNames[i],
               GetParent(m_lptc->hTab),
               (DLGPROC) ConfigureUtilDialogProc);
      if (i==3)
         m_lptc->hTabPages[i] = CreateDialog(g_hinst,
               m_lptc->dlgNames[i],
               GetParent(m_lptc->hTab),
               (DLGPROC) ConfigureExtDataDialogProc); 

      // Set initial tab page position
      if(m_lptc->blStretchTabs)
         m_lptc->StretchTabPage(m_lptc->hTab, i);
      else
         m_lptc->CenterTabPage(m_lptc->hTab, i);
   }
   // Show first tab
   ShowWindow(m_lptc->hTabPages[0],SW_SHOW);

   // Save the current child
   m_lptc->hVisiblePage = m_lptc->hTabPages[0];
}





HACCEL CAuthenticationAddin::CreateAccTable (VOID)
{
   static  ACCEL  aAccel[1];
   static  HACCEL  hAccel;

   aAccel[0].fVirt=FVIRTKEY;
   aAccel[0].key=VK_ESCAPE;
   aAccel[0].cmd=CMD_VK_ESCAPE;

   aAccel[1].fVirt=FVIRTKEY;
   aAccel[1].key=VK_RETURN;
   aAccel[1].cmd=CMD_VK_RETURN;

   hAccel=CreateAcceleratorTable(aAccel,1);
   return hAccel;
}


void CAuthenticationAddin::TabPageMessageLoop (HWND hwnd)
{
   MSG      msg;
   int      status;
   BOOL handled = FALSE;

   // Create Accelerator table

   HACCEL hAccTable = CAuthenticationAddin::CreateAccTable();

   while((status = GetMessage(&msg, NULL, 0, 0 )) != 0 && !stopTabPageMessageLoop)
   { 
      if (status == -1) // Exception

      {
         return;
      }
      else
      {
         // Dialogs do not have a WM_KEYDOWN message so we will seperate

         // the desired keyboard events here

         handled = TranslateAccelerator(hwnd,hAccTable,&msg);

         // Perform default dialog message processing using IsDialogM...

         if(!handled)
            handled=IsDialogMessage(hwnd,&msg);

         // Non dialog message handled in the standard way.

         if(!handled)
         {

            TranslateMessage(&msg);
            DispatchMessage(&msg);
         }
      }
   }
   if(stopTabPageMessageLoop) //Reset: do not PostQuitMessage(0)

   {
      DestroyAcceleratorTable(hAccTable);
      stopTabPageMessageLoop = FALSE;
      return;
   }

   // Default: Re-post the Quit message

   DestroyAcceleratorTable(hAccTable);
   PostQuitMessage(0);
   return;
}

VOID CAuthenticationAddin::ResetTabPageMessageLoop (HWND hwnd)
{
   //Toggle kill sw
   stopTabPageMessageLoop=TRUE;
   stopTabPageMessageLoop=FALSE;

   SetFocus(hwnd);
   CAuthenticationAddin::TabPageMessageLoop(hwnd);
}


BOOL CAuthenticationAddin::FormMain_OnNotify(HWND hwnd, INT id, LPNMHDR pnm)
{
   switch(id)
   {
      case TAB_CONTROL_1:
         return TabCtrl_1.Notify(pnm);

   }
   return FALSE;
}


void CAuthenticationAddin::FormMain_OnSize(HWND hwnd, UINT state, int cx, int cy)
{
   RECT  rc;
   GetClientRect(hwnd,&rc);

   MoveWindow(TabCtrl_1.hTab,0,0,(rc.right - rc.left)/2-4,rc.bottom - rc.top,FALSE);
   for(int i=0;i<TabCtrl_1.tabPageCount;i++)
      TabCtrl_1.StretchTabPage(TabCtrl_1.hTab,i);

   //Refresh(hwnd);
}
void CAuthenticationAddin::FormMain_OnClose(HWND hwnd)
{
   PostQuitMessage(0);// turn off message loop
   TabControl_Destroy(&TabCtrl_1);

   EndDialog(hwnd, 0);
}


void CAuthenticationAddin::InitHandles (HWND hwndParent)
{
   BOOL initialized=FALSE;
   if(!initialized)
   {
      if (frmMain != hwndParent) frmMain = hwndParent;
      initialized=TRUE;
   }
}

BOOL CAuthenticationAddin::FormMain_OnInitDialog(HWND hwnd, HWND hwndFocus, LPARAM lParam)
{
   InitHandles (hwnd); 
   static LPSTR tabnames[]= {"Summit", "Risk", "Utility", "External Data", 0};
   static LPSTR dlgnames[]= {MAKEINTRESOURCE(IDD_SB_DLG),
                             MAKEINTRESOURCE(IDD_RDB_DLG),
                             MAKEINTRESOURCE(IDD_UTILITY_DLG),
                             MAKEINTRESOURCE(IDD_EXTDATA_DLG),0};

   New_TabControl( &TabCtrl_1, //address of TabControl struct
                   GetDlgItem(hwnd, TAB_CONTROL_1), // handle to tab control
                   tabnames, // text for each tab
                   dlgnames, // dialog id's of each tab page dialog
                   &AuthDialogProc, // address of main proc
                   NULL,//&TabCtrl1_TabPages_OnSize, // optional address of size function or NULL
                   TRUE); // stretch tab page to fit tab ctrl
 
   //Get the initial Width and height of the dialog
   //in order to fix the minimum size of dialog
   RECT rc;
   GetWindowRect(hwnd,&rc);
   gMinSize.cx = (rc.right - rc.left);
   gMinSize.cy = (rc.bottom - rc.top);

   return 0;
}

void CAuthenticationAddin::FormMain_OnCommand(HWND hWndDlg, int id, HWND hwndCtl, UINT codeNotify)
{
	static bool warnOnSaveState      = true;
	static DisplayEnum rateDisplay   = REAL_VAL;
	static DisplayEnum spreadDisplay = REAL_VAL;
	static bool keyFileState         = false;
	
	switch(id)
	{
	
	case IDOKSB:
		
		
	case IDCANCELSB :
		
		EndDialog(hWndDlg, IDCANCELSB);
		EndDialog(GetParent(hWndDlg),IDCANCELSB);
		
		break;

		
		//END 
		
		
	case IDOKRDB:
		
		
		
		break;
		
	case IDCANCELRDB :
		
		break;
		
	case IDC_TEST_BUTTON_RDB :
		{
			
		}
		break;
		//END:RISKCOMMANDS
		
		//UTIL COMMANDS
	case IDC_CHECK_KEYFILE :
		{
			
		}
		break;
	case IDC_RATE1 :
	case IDC_RATE2 :
	case IDC_RATE3 :
		rateDisplay = RateDisplayFromButtonID(codeNotify);
		CAuthenticationAddin::GetObject().SetRateDisplay(rateDisplay);
		break;
		
	case IDC_SPREAD1 :
	case IDC_SPREAD2 :
	case IDC_SPREAD3 :
		
		
	case IDOKUTIL:
		
		
		
		break;
	case IDCANCELUTIL :
		
		
	case IDC_TEST_BUTTON_UTIL :
		{
			
		}
		break;
		//END 
		
		//
	case IDOKED:
		
		break;
		
	case IDC_TEST_BUTTON_ED :
		{
			
		}
		break;
	case IDCANCELED :
		
		//END EXTDATACOMMANDS
		
	case IDCANCEL :
		
}

}

//Main dialog box which creates the tabs to hold other dialogs. 

BOOL CALLBACK CAuthenticationAddin::AuthDialogProc(
												   HWND hWndDlg, 
												   UINT message, 
												   WPARAM wParam, 
												   LPARAM lParam)
{
	try
	{
		switch(message) 
		{   
			HANDLE_MSG (hWndDlg, WM_COMMAND, FormMain_OnCommand);
			HANDLE_MSG (hWndDlg, WM_INITDIALOG, FormMain_OnInitDialog);
			HANDLE_MSG (hWndDlg, WM_SIZE, FormMain_OnSize);
			HANDLE_MSG (hWndDlg, WM_NOTIFY, FormMain_OnNotify);
			//HANDLE_MSG (hWndDlg, WM_CLOSE, FormMain_OnClose);
		default:
			return FALSE;
		}
	}
	catch (CBaseException &e)
	{
		CAuthenticationAddin::GetObject().LoggedMessageBox(e, "AuthDialogProc");
	}
	catch(...)
	{
		CAuthenticationAddin::GetObject().LoggedMessageBox("Unexpected exception", "AuthDialogProc");
	}
	
	return TRUE;
}


VOID CAuthenticationAddin::TabPage_OnLButtonDown(HWND hwnd, BOOL fDoubleClick, INT x, INT y, UINT keyFlags)
{
   // If Mouse click in tab page but not on control
   CAuthenticationAddin::ResetTabPageMessageLoop (hwnd);
}

VOID CAuthenticationAddin::SummitTabPage_OnCommand(HWND hwnd, INT id, HWND hwndCtl, UINT codeNotify)
{
	
	
	if(CMD_VK_ESCAPE==id)
	{
		stopTabPageMessageLoop=TRUE; // cause message loop to return
		SetFocus(m_lptc->hTab); // focus to tab control
		//SetFocus(GetParent(hwnd));
		return;
	}
	else if(CMD_VK_RETURN==id)
	{
		//
		// TODO: We may want to handle this
		//  ex: If we are editing a tree view on a tab,
		//  this will make the Enter key work
		//  TreeView_EndEditLabelNow(hTree,FALSE);
		//
	}
	
	if(codeNotify == EN_KILLFOCUS && id == IDC_CONFIG_SERVER_SB) 
	{
		SetServerName(GetDlgItemString(hwnd, IDC_CONFIG_SERVER_SB));
	}
	
	.
	.
	.
	
	
	
	ForwardWMCommand(hwnd,id,hwndCtl,codeNotify);
}


VOID CAuthenticationAddin::RiskTabPage_OnCommand(HWND hwnd, INT id, HWND hwndCtl, UINT codeNotify)
{
	if(CMD_VK_ESCAPE==id)
	{
		stopTabPageMessageLoop=TRUE; // cause message loop to return
		SetFocus(m_lptc->hTab); // focus to tab control
		//SetFocus(GetParent(hwnd));
		return;
	}
	else if(CMD_VK_RETURN==id)
	{
		//
		// TODO: We may want to handle this
		//  ex: If we are editing a tree view on a tab,
		//  this will make the Enter key work
		//  TreeView_EndEditLabelNow(hTree,FALSE);
		//
	}
	.
	.
	.
	
	
	ForwardWMCommand(hwnd,id,hwndCtl,codeNotify);
	
	
}


VOID CAuthenticationAddin::UtilTabPage_OnCommand(HWND hwnd, INT id, HWND hwndCtl, UINT codeNotify)
{
	if(CMD_VK_ESCAPE==id)
	{
		stopTabPageMessageLoop=TRUE; // cause message loop to return
		SetFocus(m_lptc->hTab); // focus to tab control
		//SetFocus(GetParent(hwnd));
		return;
	}
	else if(CMD_VK_RETURN==id)
	{
		//
		// TODO: We may want to handle this
		//  ex: If we are editing a tree view on a tab,
		//  this will make the Enter key work
		//  TreeView_EndEditLabelNow(hTree,FALSE);
		//
	}
	.
	.
	.
	
	
	ForwardWMCommand(hwnd,id,hwndCtl,codeNotify);
}

VOID CAuthenticationAddin::ExtTabPage_OnCommand(HWND hwnd, INT id, HWND hwndCtl, UINT codeNotify)
{
	if(CMD_VK_ESCAPE==id)
	{
		stopTabPageMessageLoop=TRUE; // cause message loop to return
		SetFocus(m_lptc->hTab); // focus to tab control
		//SetFocus(GetParent(hwnd));
		return;
	}
	else if(CMD_VK_RETURN==id)
	{
		//
		// TODO: We may want to handle this
		//  ex: If we are editing a tree view on a tab,
		//  this will make the Enter key work
		//  TreeView_EndEditLabelNow(hTree,FALSE);
		//
	}
	.
	.
	
	
	ForwardWMCommand(hwnd,id,hwndCtl,codeNotify);
	
	
}


VOID CAuthenticationAddin::ForwardWMCommand(HWND hwnd, INT id,HWND hwndCtl,UINT codeNotify)
{
	//Forward all other commands to the main dialog box WM_COMMAND
	FORWARD_WM_COMMAND (hwnd,id,hwndCtl,codeNotify,m_lptc->ParentProc);
	
	// Mouse clicks on a control should engage the Message Loop
	
	// If this WM_COMMAND message is a notification to parent window
	// ie: EN_SETFOCUS being sent when an edit control is initialized
	// do not engage the Message Loop or send any messages.
	if(codeNotify!=0) return;
	
	ResetTabPageMessageLoop (hwnd);
	//Toggling WM_NEXTDLGCTL ensures that default focus moves to selected
	//Control (This must follow call to ResetTabPageMessageLoop()) 
	SendMessage(hwnd , WM_NEXTDLGCTL, (WPARAM)0, FALSE);
	SendMessage(hwnd , WM_NEXTDLGCTL, (WPARAM)1, FALSE);
}


/**
 * Dialog procedure for IDD_CONFIG_DLG in configuration mode.
 * This dialog proc sets allows the user to test the host connection,
 * retrieves data when the dialog is closed, updates the settings
 * in the addin and saves them.
 */

BOOL CALLBACK CAuthenticationAddin::ConfigureSummitDialogProc(
															  HWND hWndDlg, 
															  UINT message, 
															  WPARAM wParam, 
															  LPARAM lParam) 
{
	hWndSummit = hWndDlg;
	
	try 
	{
		static bool warnOnSaveState = true;
	
		switch(message) 
		{   
		
			HANDLE_MSG (hWndDlg, WM_COMMAND, SummitTabPage_OnCommand);
			HANDLE_MSG (hWndDlg, WM_LBUTTONDOWN, TabPage_OnLButtonDown);
			
		case WM_INITDIALOG:
			{
				
				
				SetDlgItemString(hWndDlg, IDC_SB_USER, username);
				SetDlgItemString(hWndDlg, IDC_SB_PASS, password);
				
				.
				.
				
				
				return DefWindowProc(hWndDlg, message, wParam, lParam);
				
			}
			break;
			
		case WM_HELP :
			
			CAuthenticationAddin::GetObject().DoHelp(s_ConfigureDialogHelpContext);
			
			break;
			
			
		default:
			
			return FALSE;
			//return DefWindowProc(hWndDlg, message, wParam, lParam);
			
		}
	}
	
	
	return TRUE;
	
}

BOOL CALLBACK CAuthenticationAddin::ConfigureRiskDialogProc(
															HWND hWndDlg, 
															UINT message, 
															WPARAM wParam, 
															LPARAM lParam)
{
	std::string d ="";
	long rr=0; 
	try
	{
		static bool warnOnSaveState = true;
		
		switch(message) 
		{        
			HANDLE_MSG (hWndDlg, WM_COMMAND, RiskTabPage_OnCommand);
			HANDLE_MSG (hWndDlg, WM_LBUTTONDOWN, TabPage_OnLButtonDown);
		case WM_INITDIALOG:
			{
				.
				.
				.
				return DefWindowProc(hWndDlg, message, wParam, lParam);
			}
			break;
			
		case WM_HELP :
			
			CAuthenticationAddin::GetObject().DoHelp(s_ConfigureDialogHelpContext);
			
			break;
			
			
		default:
			
			return FALSE;
		}
	}
	return TRUE;
	
}



BOOL CALLBACK CAuthenticationAddin::ConfigureUtilDialogProc(
      HWND hWndDlg, 
      UINT message, 
      WPARAM wParam, 
      LPARAM lParam)
{
   try
   {
      static bool warnOnSaveState = true;
      static DisplayEnum rateDisplay = REAL_VAL;
      static DisplayEnum spreadDisplay = REAL_VAL;
      static bool keyFileState = false;

      switch(message) 
      {        
         HANDLE_MSG (hWndDlg, WM_COMMAND, UtilTabPage_OnCommand);
         HANDLE_MSG (hWndDlg, WM_LBUTTONDOWN, TabPage_OnLButtonDown);
         case WM_INITDIALOG:
         {
            .
            .
            .
            
            return DefWindowProc(hWndDlg, message, wParam, lParam);
         }
         break;

         
         case WM_HELP :

         CAuthenticationAddin::GetObject().DoHelp(s_ConfigureDialogHelpContext);

         break;


         default:

         return FALSE;
      }
   }
   

   return TRUE;
}


BOOL CALLBACK CAuthenticationAddin::ConfigureExtDataDialogProc(
      HWND hWndDlg, 
      UINT message, 
      WPARAM wParam, 
      LPARAM lParam)
{
   try
   {
      static bool warnOnSaveState = true;

      switch(message) 
      {        
         HANDLE_MSG (hWndDlg, WM_COMMAND, ExtTabPage_OnCommand);
         HANDLE_MSG (hWndDlg, WM_LBUTTONDOWN, TabPage_OnLButtonDown);
         case WM_INITDIALOG:
         {
           .
           .
           .
           
           return DefWindowProc(hWndDlg, message, wParam, lParam);
         }
         break;

         case WM_HELP :

         CAuthenticationAddin::GetObject().DoHelp(s_ConfigureDialogHelpContext);

         break;


         default:

         return FALSE;
      }
   }
  
   return TRUE;
}

reply2am6-May-09 4:34

6-May-09 4:34

I use the following sample to do the it.
I do exactly the same, but my code doesnt work. http://www.codeproject.com/KB/winsdk/Win32SDK_C_TabCtrl.aspx

serzh836-May-09 5:33

serzh83

6-May-09 5:33

You already have messsage loop
Why do you call

CAuthenticationAddin::TabPageMessageLoop (m_lptc->hTabPages[currentSel]);

Try to comment all calls to it

reply2am8-May-09 0:49

8-May-09 0:49

Doesnt make a difference..
this line is there for KEY events.. but even for the onselchange it causes the problem.
i tried commenting them but it behaved the same Frown | :(

getting complete file path

KarstenK8-May-09 1:10

KarstenK

8-May-09 1:10

The default return of the Notify() should be true. You dont need to rerourte other notifications.

Press F1 for help or google it.
Greetings from Germany

MahaKh5-May-09 23:50

MahaKh

5-May-09 23:50

i m trying to get the complete file path on pressing a browse button....i know abt a method GetFilePath but it does not work

Rajesh R Subramanian5-May-09 23:52

Rajesh R Subramanian

5-May-09 23:52

Show us the code inside the browse button handler.

It is a crappy thing, but it's life -^ Carlo Pallini

MahaKh5-May-09 23:58

MahaKh

5-May-09 23:58

CFileDialog dlg(true);
CString path=dlg.getFileName();

this code returns only the file name...but what i want is comple path of that file...

«_Superman_»5-May-09 23:56

«_Superman_»

5-May-09 23:56

If you are using CFileDialog class you can use the CFileDialog::GetPathName.

«_Superman_»
I love work. It gives me something to do between weekends.

MahaKh6-May-09 0:02

MahaKh

6-May-09 0:02

ooh yes...sorry i have used getPathName method instead...it was the typing mistake.... i havnt got the result by using GetPathName method

Inconstitent CTreeCtrl due to Modal Dialog [modified]

Divyang Mithaiwala6-May-09 1:55

Divyang Mithaiwala

6-May-09 1:55

MahaKh wrote:
i have used getPathName

If that doesn't work then you may try GetFolderPath along with GetFileName of CFileDialog.

Do not trust a computer...
Always check what computer is doing

regards,
Divyang Mithaiwala
Software Engineer

__GJ__5-May-09 23:46

5-May-09 23:46

Hi,

I have a program that uses a tree for navigation and if you select a node it starts computing. In order to be able to abort the computation, I wanted to show an abort dialog. However if I continue clicking on the tree, while waiting for the dialog, it is possible to get the tree into a state, that it will always jump back a node (last clicked before the dialog popped up).
It doesn't happen with every popup, it has to do with the timing of the click and the dialog.
If the tree is in that state, you can select another node, it will show it as selected as long as the mouse button is pressed, if you release it it will jump back and show the other node as selected. The focus rectangle remain on the "correct" node, also the computation starts for the correct node.

I generated a small program, with Visual Studio 2008, a single dialog with visual studio layout. And the only code I added was a timer to popup the about dialog every 2 seconds (if it is not already shown).
Even in this program I am able to reproduce it. I tried varies things, such as giving the focus back to the dockable pane with the tree in it, moving the timer handler to the treectrl, tried to peekmessage and such, but nothing works and I'm running out of ideas.

Hopefully someone here can help me. Smile | :)

I uploaded the code to: file factory (sorry but I don't have another option atm Smile | :)

)

modified on Wednesday, May 6, 2009 6:06 AM

Stuart Dootson6-May-09 2:30

6-May-09 2:30

How do you pop up the dialog when the tree is processing? Does the processing occur in the same thread as the UI? Maybe you could deactivate the tree control while the processing is occurring so the user doesn't expect clicks on the tree to work?

__GJ__ wrote:
I uploaded the code to: file factory (sorry but I don't have another option atm )

That's a 14MB zip file? You expect people to dig through 14MB+ your code without any guidance as to where your issue is?

__GJ__ wrote:
sorry but I don't have another option atm

Yes you do - you can post the text of the minimal source code that exhibits this problem in a reply on this forum - and I don't mean the slightly modified VS dialog project - I mean the least amount of code that exhibits the problem - chop out anything that isn't relevant.

Java, Basic, who cares - it's all a bunch of tree-hugging hippy cr*p

__GJ__6-May-09 4:56

6-May-09 4:56

I set a timer in CMainFrame. In the OnTimer function it checks whether or not it should activate the dialog. I call DoModal in the same thread as the UI.

Cleared out the zip file(removed the debug directory) it now only 114kb. Code

With "no other option" i meant filefactory, since I don't have a server available. But that's besides the point, I don't really know where the problem lies, I think it has something to do with a Modal dialog interupting a message sequence from the TreeCtrl, but that's just guessing. Other than setting the timer I just used a default program setup generated by Visual Studio 2008.

It could be that it does not create the view or treectrl properly.

This is how the generated code from Visual Studio 2008 creates the View windows.
The CDockablePanes are created in the function CreateDockingWindows in CMainFrame

// Create class view
	CString strClassView;
	bNameValid = strClassView.LoadString(IDS_CLASS_VIEW);
	ASSERT(bNameValid);
	if (!m_wndClassView.Create(strClassView, this, CRect(0, 0, 200, 200), TRUE, ID_VIEW_CLASSVIEW, WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS | WS_CLIPCHILDREN | CBRS_LEFT | CBRS_FLOAT_MULTI))
	{
		TRACE0("Failed to create Class View window\n");
		return FALSE; // failed to create
	}

This leads to the onCreate of the FileView (also generated code)

int CFileView::OnCreate(LPCREATESTRUCT lpCreateStruct)
{
	if (CDockablePane::OnCreate(lpCreateStruct) == -1)
		return -1;

	CRect rectDummy;
	rectDummy.SetRectEmpty();

	// Create view:
	const DWORD dwViewStyle = WS_CHILD | WS_VISIBLE | TVS_HASLINES | TVS_LINESATROOT | TVS_HASBUTTONS;

	if (!m_wndFileView.Create(dwViewStyle, rectDummy, this, 4))
	{
		TRACE0("Failed to create file view\n");
		return -1;      // fail to create
	}

	// Load view images:
	m_FileViewImages.Create(IDB_FILE_VIEW, 16, 0, RGB(255, 0, 255));
	m_wndFileView.SetImageList(&m_FileViewImages, TVSIL_NORMAL);

	m_wndToolBar.Create(this, AFX_DEFAULT_TOOLBAR_STYLE, IDR_EXPLORER);
	m_wndToolBar.LoadToolBar(IDR_EXPLORER, 0, 0, TRUE /* Is locked */);

	OnChangeVisualStyle();

	m_wndToolBar.SetPaneStyle(m_wndToolBar.GetPaneStyle() | CBRS_TOOLTIPS | CBRS_FLYBY);

	m_wndToolBar.SetPaneStyle(m_wndToolBar.GetPaneStyle() & ~(CBRS_GRIPPER | CBRS_SIZE_DYNAMIC | CBRS_BORDER_TOP | CBRS_BORDER_BOTTOM | CBRS_BORDER_LEFT | CBRS_BORDER_RIGHT));

	m_wndToolBar.SetOwner(this);

	// All commands will be routed via this control , not via the parent frame:
	m_wndToolBar.SetRouteCommandsViaFrame(FALSE);

	// Fill in some static tree view data (dummy code, nothing magic here)
	FillFileView();
	AdjustLayout();

	return 0;
}

The timer, onAbout does DoModal (added by me)

void CMainFrame::OnTimer(UINT_PTR nIDEvent)
{
	switch(nIDEvent)
	{
	case IDT_MAINTIMER:
		{
			KillTimer(IDT_MAINTIMER);

			CTreeBugTestApp* pApp = (CTreeBugTestApp*) AfxGetApp();

			pApp->OnAppAbout();

			SetTimer(IDT_MAINTIMER, 2000, NULL);
			break;
		}
	}	
}

The generated OnAppAbout function

void CTreeBugTestApp::OnAppAbout()
{
	CAboutDlg aboutDlg;
	aboutDlg.DoModal();
}

Stuart Dootson6-May-09 6:44

6-May-09 6:44

I'm still not entirely sure what the problem is - OK, the tree-view loses focus. That's easily solved, with this (I've commented the lines I've added to your code):

// App command to run the dialog
void CTreeBugTestApp::OnAppAbout()
{
   CWnd* pFocusWnd = CWnd::GetFocus(); // Remember the focus window
   CAboutDlg aboutDlg;
   aboutDlg.DoModal();
   if (pFocusWnd) pFocusWnd->SetFocus(); // Reset the focus window
}

Any other issues?

Java, Basic, who cares - it's all a bunch of tree-hugging hippy cr*p

__GJ__6-May-09 20:44

6-May-09 20:44

Tried it and it didn't work.

Problem is that if you click a lot on the tree, while waiting for the dialog to pop up. And if you time it right, clicking at the exact time to the dialog popups up. It is possible to get the tree to think that the last clicked node should be displayed as selected.

In that case the tree keeps jumping back to the last clicked tree-node. Meaning you last clicked node1 in the tree before the dialog pops up, you close the dialog and click node 2. That node 2 is displayed as selected as long as your mouse button is pressed, but as soon as you release it jumps back and displays node 1 as selected. But it should display node 2 as selected!

__GJ__8-May-09 3:56