Visual Basic

25-Jan-16 22:15

Hello everyone,
I've been looking for the code to print my full DataGridView with Visual Basic 2010 Express for a long period and I tested all codes that are displayed with searches on google but in vain.
But finally I find a C # code that I converted to VB which suits me perfectly but the only problem is that it runs infinitely (infinite loop at the number of pages)
NOTE: The code doesn't generate an error and it's an urgent case because I need it for my job.
Thanks, Smile | :)

Here is my code:

VB.NET

Private Sub PrintDocument1_PrintPage(ByVal sender As System.Object, ByVal e As System.Drawing.Printing.PrintPageEventArgs) Handles PrintDocument1.PrintPage

Try
            Dim iHeaderHeight As Double
            'Set the left margin
            Dim iLeftMargin As Integer = e.MarginBounds.Left
            'Set the top margin
            Dim iTopMargin As Integer = e.MarginBounds.Top
            'Whether more pages have to print or not
            Dim bMorePagesToPrint As Boolean = False
            Dim iTmpWidth As Integer = 0
            'For the first page to print set the cell width and header height
            If bFirstPage Then
                For Each GridCol As DataGridViewColumn In DataGridView_impot.Columns
                    iTmpWidth = CType(Math.Floor(CType((CType(GridCol.Width, Double) / (CType(iTotalWidth, Double) * (CType(iTotalWidth, Double) * (CType(e.MarginBounds.Width, Double) / CType(iTotalWidth, Double))))), Double)), Integer)
                    iHeaderHeight = (CType(e.Graphics.MeasureString(GridCol.HeaderText, GridCol.InheritedStyle.Font, iTmpWidth).Height, Integer) + 11)
                    ' Save width and height of headers
                    arrColumnLefts.Add(iLeftMargin)
                    arrColumnWidths.Add(iTmpWidth)
                    iLeftMargin = (iLeftMargin + iTmpWidth)
                Next
            End If
 
            'Loop till all the grid rows not get printed
            Dim iRow As Double
            While (iRow <= (DataGridView_impot.Rows.Count - 1))
                Dim GridRow As DataGridViewRow = DataGridView_impot.Rows(iRow)
                'Set the cell height
                iCellHeight = (GridRow.Height + 5)
                Dim iCount As Integer = 0
                'Check whether the current page settings allows more rows to print
                If (iTopMargin + (iCellHeight >= (e.MarginBounds.Height + e.MarginBounds.Top))) Then
                    bNewPage = True
                    bFirstPage = False
                    bMorePagesToPrint = True
                    Exit While
                Else
                    If bNewPage Then
                        'Draw Header => raison sociale
                        e.Graphics.DrawString(Me.lbl_rs.Text, New Font(DataGridView_impot.Font, FontStyle.Bold), Brushes.Black, e.MarginBounds.Left, (e.MarginBounds.Top - (e.Graphics.MeasureString(Me.lbl_rs.Text, New Font(DataGridView_impot.Font, FontStyle.Bold), e.MarginBounds.Width).Height - 13)))
                        'Draw Date => date system
                        e.Graphics.DrawString(Me.lbl_date_now.Text, New Font(DataGridView_impot.Font, FontStyle.Bold), Brushes.Black, (e.MarginBounds.Left + (e.MarginBounds.Width - e.Graphics.MeasureString(Me.lbl_date_now.Text, New Font(DataGridView_impot.Font, FontStyle.Bold), e.MarginBounds.Width).Width)), (e.MarginBounds.Top - (e.Graphics.MeasureString(Me.lbl_rs.Text, New Font(New Font(DataGridView_impot.Font, FontStyle.Bold), FontStyle.Bold), e.MarginBounds.Width).Height - 13)))
                        'Draw Columns                 
                        iTopMargin = e.MarginBounds.Top
                        For Each GridCol As DataGridViewColumn In DataGridView_impot.Columns
                            e.Graphics.FillRectangle(New SolidBrush(Color.LightGray), New Rectangle(CType(arrColumnLefts(iCount), Integer), iTopMargin, CType(arrColumnWidths(iCount), Integer), iHeaderHeight))
                            e.Graphics.DrawRectangle(Pens.Black, New Rectangle(CType(arrColumnLefts(iCount), Integer), iTopMargin, CType(arrColumnWidths(iCount), Integer), iHeaderHeight))
                            e.Graphics.DrawString(GridCol.HeaderText, GridCol.InheritedStyle.Font, New SolidBrush(GridCol.InheritedStyle.ForeColor), New RectangleF(CType(arrColumnLefts(iCount), Integer), iTopMargin, CType(arrColumnWidths(iCount), Integer), iHeaderHeight), strFormat)
                            iCount = (iCount + 1)
                        Next
                        bNewPage = False
                        iTopMargin = (iTopMargin + iHeaderHeight)
                    End If
 
                    iCount = 0
                    'Draw Columns Contents
                    For Each Cel As DataGridViewCell In GridRow.Cells
                        If (Not (Cel.Value) Is Nothing) Then
                            e.Graphics.DrawString(Cel.Value.ToString, Cel.InheritedStyle.Font, New SolidBrush(Cel.InheritedStyle.ForeColor), New RectangleF(CType(arrColumnLefts(iCount), Integer), CType(iTopMargin, Single), CType(arrColumnWidths(iCount), Integer), CType(iCellHeight, Single)), strFormat)
                        End If
 
                        'Drawing Cells Borders 
                        e.Graphics.DrawRectangle(Pens.Black, New Rectangle(CType(arrColumnLefts(iCount), Integer), iTopMargin, CType(arrColumnWidths(iCount), Integer), iCellHeight))
                        iCount = (iCount + 1)
                    Next
                End If
 
                iRow = (iRow + 1)
                iTopMargin = (iTopMargin + iCellHeight)
 
            End While
 
            'If more lines exist, print another page.
            If bMorePagesToPrint Then
                e.HasMorePages = True
            Else
                e.HasMorePages = False
            End If
 
        Catch exc As Exception
            MessageBox.Show(exc.Message, "Error", MessageBoxButtons.OK, MessageBoxIcon.Error)
        End Try
 
 
    End Sub

Sascha Lefèvre25-Jan-16 22:40

25-Jan-16 22:40

"Urgent" doesn't work too well here - it tends to annoy people who are spending their time answering questions on a voluntary basis.

And why do you repost your exact same question?

If the brain were so simple we could understand it, we would be so simple we couldn't. — Lyall Watson

Dorsaf Ouersighni25-Jan-16 22:52

25-Jan-16 22:52

actually, I need some help and there is no one answering Dead | X|

Sascha Lefèvre25-Jan-16 23:00

25-Jan-16 23:00

Well, as I said, we're volunteers here. So you have to accept that it may take a while to get an answer. Marking it as "urgent" can very well lead to the opposite of the intended effect.

And your problem sounds like it can easily be identified by running your code step by step in the debugger. Did you do that?

If the brain were so simple we could understand it, we would be so simple we couldn't. — Lyall Watson

Dorsaf Ouersighni25-Jan-16 23:33

25-Jan-16 23:33

Thank you Sascha for you're answer Smile | :)

Yes I know that you are volunteers but i said it's "urgent" because it been so long that i'm looking for a solution.
I've run it step by step and it dosen't make changes and for that reason i didn't know what to do :/
and i'm sure that the problem is in that part.
Thanks again Smile | :)

Sascha Lefèvre26-Jan-16 0:06

26-Jan-16 0:06

iRow is a Double which makes little sense for a row counter. I don't think it's the cause of the problem but I'd change it to Integer.

As iRow is incremented unconditionally and all other loops are For-Each-loops it's not obvious to me where and why this code would loop indefinitely.

Dorsaf Ouersighni wrote:
I've run it step by step and it dosen't make changes

So your next task for debugging is to determine why it doesn't make changes (which would lead to a loop termination).

If the brain were so simple we could understand it, we would be so simple we couldn't. — Lyall Watson

Dorsaf Ouersighni26-Jan-16 1:36

26-Jan-16 1:36

I really don't know why The WHY is what i'm looking for.
and As you said " all other loops are For-Each-loops it's not obvious to me where and why this code would loop indefinitely. "
Even when i changed iRow to Integer, nothing changes and there is nothing warning in the project; no erreurs and no warning
That's disturbing Confused | :confused:

Sascha Lefèvre26-Jan-16 2:03

26-Jan-16 2:03

Dorsaf Ouersighni wrote:
I really don't know why The WHY is what i'm looking for.

If a loop gets executed indefinitely it's because its condition to keep running keeps evaluating to true. So, if it's the while-loop that executes indefinitely

While (iRow <= (DataGridView_impot.Rows.Count - 1))

then it has to be because iRow always has a value lower than the amount of rows. That's not intended of course - so you would have to find out (using the debugger) why this is so in order to fix it.

If the brain were so simple we could understand it, we would be so simple we couldn't. — Lyall Watson

Dorsaf Ouersighni26-Jan-16 2:44

26-Jan-16 2:44

Thanks a lot Sascha Smile | :)

I think that's TRUE. When i changed iRow bigger than the condition, it stop executing indefinitely.
I will try to fix it immediatly.
I really appreciate you're effort and thank you very much Rose | [Rose]

I will send you back the result
Have a nice day
By the way you have a beautiful name Smile | :)

Sascha Lefèvre26-Jan-16 4:01

26-Jan-16 4:01

I'm guessing that the infinite looping doesn't occur within the posted Sub. Instead, I assume, e.HasMorePages always gets set to true so that the PrintPage-event automatically gets fired again so the Sub gets called again. You can verify this by placing a debug-breakpoint on this line:

If bMorePagesToPrint Then

When you get there, inspect the value of bMorePagesToPrint (I suspect it will always be true) and then press F5 (continue execution until next breakpoint) which will probably get you to that same line again and again.

If this is the case, then the condition on this line

If (iTopMargin + (iCellHeight >= (e.MarginBounds.Height + e.MarginBounds.Top))) Then

never evaluates to false so that bMorePagesToPrint always gets set to true. Then you would have to figure out why this condition never evaluates to false - this is hard to guess for me by looking at the code only.

Dorsaf Ouersighni wrote:
By the way you have a beautiful name

Thank you

If the brain were so simple we could understand it, we would be so simple we couldn't. — Lyall Watson

Dorsaf Ouersighni26-Jan-16 4:36

26-Jan-16 4:36

thanks a lot Sascha Smile | :)

The whole problem was "()" wrong and when i remove it, it doesn't execute infinitly

If (iTopMargin + iCellHeight >= (e.MarginBounds.Height + e.MarginBounds.Top)) Then

instead of

If (iTopMargin + (iCellHeight >= (e.MarginBounds.Height + e.MarginBounds.Top))) Then

it stays just to reorganize my DataGridView in the previw dialog before printing it Big Grin | :-D

Sascha Lefèvre26-Jan-16 4:45

26-Jan-16 4:45

Dorsaf Ouersighni wrote:
thanks a lot Sascha

You're welcome! Smile | :)

If the brain were so simple we could understand it, we would be so simple we couldn't. — Lyall Watson

Sascha Lefèvre26-Jan-16 5:05

26-Jan-16 5:05

I would recommend you to always use

Option Strict On

(at the very top of your code files).

With that option active Visual Studio would have given you an error (along the lines "can't implicitly convert from boolean to integer") for that line where you got the brackets wrong. Basically it forces you to always express your intent clearly and thus avoids situations like these.

If the brain were so simple we could understand it, we would be so simple we couldn't. — Lyall Watson

Dorsaf Ouersighni26-Jan-16 21:04

26-Jan-16 21:04

I really appreciate your help Smile | :)

I will use it. Thank you very much Smile | :)

Jörgen Andersson26-Jan-16 22:52

Jörgen Andersson

26-Jan-16 22:52

I would go one step further than what Sascha recommends.

Open Tools > Options
In the left pane select Projects and Solutions > VB Defaults
On the right side set Option Strict to On.

Now all new projects have this as a default setting.

For your current project right click the project in the Solution Explorer and select Properties.
In the left pane select Compile.
Set Option Strict to On.

From now on you have these settings for all files.

And in my personal opinion you should do the same for Option Explicit and Option Infer.

Wrong is evil and must be defeated. - Jeff Ello

Dorsaf Ouersighni27-Jan-16 2:39

27-Jan-16 2:39

Thanks Jörgen Smile | :)

That was really helpful Thumbs Up | :thumbsup:

Jörgen Andersson27-Jan-16 3:22

Jörgen Andersson

27-Jan-16 3:22

You're welcome.

Wrong is evil and must be defeated. - Jeff Ello

Sascha Lefèvre26-Jan-16 2:29

26-Jan-16 2:29

I didn't pay enough attention to what you wrote in your original post: "infinite loop at the number of pages". What exactly do you mean by that?

If the brain were so simple we could understand it, we would be so simple we couldn't. — Lyall Watson

Dorsaf Ouersighni26-Jan-16 2:48

26-Jan-16 2:48

I mean that when it counts the number of pages to print it doesn't stop counting

Dave Kreskowiak26-Jan-16 2:40

Dave Kreskowiak

26-Jan-16 2:40

Dorsaf Ouersighni wrote:
I really don't know why The WHY is what i'm looking for.

That's the entire point behind using the debugger. The debugger isn't there to tell you what's wrong with your code. It's there to tell you what's wrong with your understanding of it. Seriously, the debugger is there to debug YOU, not really the code. Using the debugger is the fastest way to learn about the code you've written and the conditions under which it runs.

A guide to posting questions on CodeProject

Click this: Asking questions is a skill.
Seriously, do it.

Dave Kreskowiak

Dorsaf Ouersighni26-Jan-16 3:23

26-Jan-16 3:23

thanks Dave

Richard MacCutchan26-Jan-16 2:28

Richard MacCutchan

26-Jan-16 2:28

Dim iRow As Double
While (iRow <= (DataGridView_impot.Rows.Count - 1))

Firstly you should not use a Double as a loop counter, always use integers. Secondly, you should initialise the variable to zero to begin the loop. Uninitialised variables generally contain garbage, and could quite conceivably contain some extremely large negative value.

Richard Deeming26-Jan-16 2:43

Richard Deeming

26-Jan-16 2:43

Richard MacCutchan wrote:
Uninitialised variables generally contain garbage, and could quite conceivably contain some extremely large negative value.

That's true in C/C++, but not in .NET code. The variable will always be initialized to its default value.

However, it's still a good idea to explicitly initialize it. In C#, you'd get a compiler error if you didn't.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Dorsaf Ouersighni26-Jan-16 3:01