WPF Discussion Boards

Pete O'Hanlon4-Mar-14 8:16

4-Mar-14 8:16

There's a couple of ways you could do this. One way is to hook into the property itself and call the method when you're changing the value. The other way is to use RX to observe the property and call the method whenever the property changes. There's a pretty decent primer here[^] that should give you a heads up.

Kevin Marois11-Mar-14 6:15

11-Mar-14 6:15

Pete,

Can you explain what you mean by 'Hook into the property'?

Thanks

If it's not broken, fix it until it is

Pete O'Hanlon11-Mar-14 6:20

11-Mar-14 6:20

It's just a case of adding a piece of logic into your property setter and calling your method if the value has changed.

Matt T Heffron4-Mar-14 8:37

4-Mar-14 8:37

I'd suggest looking into the PropertyObserver class from Josh Smith's MVVM Foundation library[^].
This will let you watch for the NotifyPropertyChanged event.

Specific info at: One way to avoid messy PropertyChanged event handling[^]

Kevin Marois11-Mar-14 5:50

11-Mar-14 5:50

Well I implemented this and it doesn't work. I registered the property, compiled, and ran it. Nothing happens. The method I registered doesn't get called. The property IS changed, but the callback doesn't get called.

Too bad, it looked promising.

[UPDATE]

So here's what I just found....

I have a GridView bound to a list of JobAssignmentEntities and who's SelectedItem is bound to a property in my VM called SelectedJobAssignment.

In the CTOR of the VM I did

propertyObserver = new PropertyObserver<JobAssignmentHeaderEntity>(this.SelectedJobAssignment)
                        .RegisterHandler(n => n.PhaseStart, n => this.phaseStartChanged(n));

In order to register it the property must not be null, because of a null ref check in the register method.

So I moved the block above inside the SelectedJobAssignment's Getter and it works.

sooo, I will need to find a way to register EACH time the SelectedJobAssignment is set.

If it's not broken, fix it until it is

modified 11-Mar-14 11:59am.

Matt T Heffron11-Mar-14 7:51

11-Mar-14 7:51

Yes, this makes sense.
The PropertyObserver constructor attaches to the current value (this.SelectedJobAssignment) of the passed property.
It does not automatically track if that property itself changes. (I.e., it doesn't notice if this.SelectedJobAssignment changes)
The registration tracks if the referenced property of that value changes. (I.e., it only notices if this.SelectedJobAssignment.PhaseStart changes)

Matt T Heffron11-Mar-14 7:53

11-Mar-14 7:53

Why not move it into the SelectedJobAssignment's Setter ?

Kevin Marois11-Mar-14 8:00

11-Mar-14 8:00

In ref to this and your prior posting....

I see how it works, it just looks kludgy.

First, I could see something like

propertyObserver.Register(typeof(theType), x => x.Property, MyHandler());

this way you can register multiple type, and only need to have this on one place.

Having to re-register each time the property changes is ugly

If it's not broken, fix it until it is

Matt T Heffron11-Mar-14 8:13

11-Mar-14 8:13

You just use a different property observer.
One for "the class" that checks when specific properties are changed.
In the handlers for that observers, you register handlers for the properties on the values of the "properties of the class".
This way the PropertyObserver handles the general case.

Kevin Marois11-Mar-14 8:18

11-Mar-14 8:18

Ya I know. THe idea is great, just not the cleanest implementation.

If it's not broken, fix it until it is

WPF Bind Window Activated Event To Command

pradeep surya5-Mar-14 7:31

pradeep surya

5-Mar-14 7:31

Hi,

Simply you can achieve this by using triggers.
Write an Event Trigger with event name as Click and bind an ICommand property which is in the viewmodel.
So whenever there is a click on the checkbox(either select or deselect this method triggers)
Then you can write the logic according to your functionality.

There are so many ways to achieve this as well.

Kevin Marois3-Mar-14 10:40

3-Mar-14 10:40

I'm trying to bind a window's Activated event to a command:

So I have:

xmlns:i="clr-namespace:System.Windows.Interactivity;assembly=System.Windows.Interactivity"

and

<Window.Resources>
    <ResourceDictionary>
            
        <ResourceDictionary.MergedDictionaries>
            <ResourceDictionary Source="..\AppResources.xaml"/>
        </ResourceDictionary.MergedDictionaries>

        <i:Interaction.Triggers>
            <i:EventTrigger EventName="Activated">
                <i:InvokeCommandAction Command="{Binding WindowActivatedCommand}"/>
            </i:EventTrigger>
        </i:Interaction.Triggers>

    </ResourceDictionary>
</Window.Resources>

I get a compilation error

"Property 'Triggers' is not attachable to elements of type 'ResourceDictionary'"

What's wrong here??

Thanks

If it's not broken, fix it until it is

Pete O'Hanlon3-Mar-14 10:53

3-Mar-14 10:53

Move it outside the Window.Resources section. All you need do is add it after the opening Window tag.

Kevin Marois3-Mar-14 11:11

3-Mar-14 11:11

Thanks Pete. That did it.

The Getter for the command fires, but the execute never does.

My code is pretty standard:

private ICommand _WindowActivatedCommand;
public ICommand WindowActivatedCommand
{
    get
    {
        if (_WindowActivatedCommand == null)
            _WindowActivatedCommand = new RelayCommand(p => windowActivated(), p => windowCanActivate());

        return _WindowActivatedCommand;
    }
}

private bool windowCanActivate()
{
    return true;
}
private void windowActivated()
{

}

Neither windowCanActivate nor windowActivated ever fire. How do I know if the Event is calling the command?

If it's not broken, fix it until it is

Pete O'Hanlon3-Mar-14 11:16

3-Mar-14 11:16

How have you assigned your DataContext?

Kevin Marois3-Mar-14 11:17

3-Mar-14 11:17

Yes.

If it's not broken, fix it until it is

Pete O'Hanlon3-Mar-14 11:18

3-Mar-14 11:18

I think you need to read my question again.

Kevin Marois3-Mar-14 11:19

3-Mar-14 11:19

About the DC? Yes, I assigned it.

This window is working. It's just THIS piece that's not working.

If it's not broken, fix it until it is

Pete O'Hanlon3-Mar-14 11:37

3-Mar-14 11:37

I asked how have you assigned the DC, not have you assigned it? It's entirely possible that you have created it after the Activated event has fired.

Kevin Marois3-Mar-14 11:39

3-Mar-14 11:39

oh oh, my bad. I'm sorry. I totally missed the word 'how'

I did it in the code behind after the InitializeComponent.

If it's not broken, fix it until it is

Pete O'Hanlon3-Mar-14 12:33

3-Mar-14 12:33

It's my fault - I just reread your post - the getter is being hit, so the DataContext has been hooked up.

In order to test your Activated event, bring another window to the front and then reselect your application. See if it fires then (it should).

Kevin Marois3-Mar-14 12:48

3-Mar-14 12:48

You're right - it fired AFTER I re-activated it.

It just doesn't fire on startup, which is what I want.

[UPDATE]
According to this[^]

the Window is activated when "The window is first opened."

The Activate command fires AFTER I lose and regain focus, but not on first startup.

[UPDATE 2]
I replaced the command with the event subscription in the code begind and it DOES fire on startup, so for some reason the command isn't firing until later on.

If it's not broken, fix it until it is

modified 3-Mar-14 18:57pm.

Kevin Marois4-Mar-14 7:44

4-Mar-14 7:44

FYI - Resolved this using the Loaded event.

If it's not broken, fix it until it is

Pete O'Hanlon5-Mar-14 12:13